Re: [PATCH-for-7.2] target/ppc: Fix build warnings when building with 'disable-tcg'

[Vaibhav Jain <vaibhav@linux.ibm.com>]

Hi Philippe,

Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> Oops sorry.
>
> Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc")
Thanks for figuring and pointing this out

>
>> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
>> index a05a2ed595..94adcb766b 100644
>> --- a/target/ppc/excp_helper.c
>> +++ b/target/ppc/excp_helper.c
>> @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, target_ulong arg2,
>>   #endif
>>   #endif
>>   
>> +#ifdef CONFIG_TCG
>>   static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t lane)
>>   {
>>       const uint16_t c = 0xfffc;
>> @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true)
>>   HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false)
>>   HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true)
>>   HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false)
>> +#endif /* CONFIG_TCG */
>
> Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk")
>
Thanks

> Hmm this is another fix... You could split your patch in 2,
> but not a big deal. Regardless:

This being a trivial patch, descided against splitting it in 2.


> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,


-- 
Cheers
~ Vaibhav