From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5281FECAAA1 for ; Mon, 24 Oct 2022 18:11:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F3CF10E6D3; Mon, 24 Oct 2022 18:11:26 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6450810E6D3; Mon, 24 Oct 2022 18:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666635083; x=1698171083; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5z5J6hyo+xzhPJHRSqQ2l3yOfGRRo8+TjXETgVVrD8A=; b=FVYR0n9zOXJnS/P/R0ocvn+vdcyRzuQ2zPhFwbEQiqnOADKe1u5j2JbB oYmfXOZ1pMdthwNAj3hU+lzEku1wJtl0Vfz8936vdqyuH4fvxI5HuJ1oa cHmCVRNESbMijTnbstkiNfISqdPzFZgN9zqiNCGAhRpksTBg4siH5Qvw2 voD/JM+ySWa1Q8IzwkfAqdR783neBSLpljQ0xaGKCwm/u8LQXtS5fPMjU aR3MkmKisShWTpNJRPZraZpMgmD+B3iqrpLWBYUzdt3upeMoaG9WeRmBK JCS7sJdNoMUuCYKKDIZun829SJNkb0Fe7LyCCNYJF6LzV/JldhpQei70b Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="371707016" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="371707016" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:22 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="609286400" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="609286400" Received: from emontau-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.221]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:11 -0700 From: Jani Nikula To: Akihiko Odaki , Hans de Goede In-Reply-To: <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221024113513.5205-1-akihiko.odaki@daynix.com> <746e5cc6-516f-8f69-9d4b-8fe237de8fd6@redhat.com> <60672af8-05d2-113c-12b9-d635608be0dd@redhat.com> <7373e258-f7cc-4416-9b1c-c8c9dab59ada@daynix.com> <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Date: Mon, 24 Oct 2022 21:11:08 +0300 Message-ID: <87o7u1drcz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Ike Panhc , "Rafael J. Wysocki" , dri-devel@lists.freedesktop.org, Azael Avalos , Mattia Dongili , Daniel Dadap , Henrique de Moraes Holschuh , David Airlie , Daniel Thompson , Jonathan Woithe , Jonathan Corbet , "Lee, Chun-Yi" , Helge Deller , Lee Jones , Robert Moore , linux-acpi@vger.kernel.org, Cezary Jackiewicz , Len Brown , Kenneth Chan , Corentin Chary , intel-gfx@lists.freedesktop.org, acpi4asus-user@lists.sourceforge.net, Maxime Ripard , Mark Gross , Rodrigo Vivi , Daniel Vetter , platform-driver-x86@vger.kernel.org, devel@acpica.org, ibm-acpi-devel@lists.sourceforge.net, Jingoo Han , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , Pali =?utf-8?Q?Roh=C3=A1r?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 25 Oct 2022, Akihiko Odaki wrote: > That aside, the first patch in this series can be applied without the > later patches so you may have a look at it. It's fine if you don't merge > it though since it does not fix really a pragmatic bug as its message says. I think it's problematic because it needlessly ties i915 backlight operation to existence of backlight devices that may not be related to Intel GPU at all. The direction should be multiple supported backlight devices, across GPUs and connectors, but only one per display. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6215DC67871 for ; Mon, 24 Oct 2022 19:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbiJXTov (ORCPT ); Mon, 24 Oct 2022 15:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233507AbiJXToE (ORCPT ); Mon, 24 Oct 2022 15:44:04 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4CA7194219; Mon, 24 Oct 2022 11:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666635141; x=1698171141; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5z5J6hyo+xzhPJHRSqQ2l3yOfGRRo8+TjXETgVVrD8A=; b=CTreJ/NTlalPXaOM+VYIQ30+UirYB0cafgqkos+0j5oy3cgHWYw7LuOZ H46KTgzh4inW7Y4JY3enkMEmQ4/H1dlplhzmigdzxecUwDWqD/4ENtikS MwoRzhj3NtFCfUMVT/oxF71d3HPGerykryaksqMgcFQu2btBXj5aOtubb r3ZCCUugQ8xKTDDKAyn6oX7tNUDDmhZoOb/2OveaOVrnDCMEx1Q6+khI0 ptZhdXud2mHLmsXw48XlobER/BC++TMPpW/sLVwCZb4bmjteJ3B+Hi932 krtHztMHY9HLvk4quni6YmhdKxT/cHBkDkI8PeiJz+gE47LrRq+5qUkuz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="393805616" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="393805616" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:22 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="609286400" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="609286400" Received: from emontau-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.221]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:11 -0700 From: Jani Nikula To: Akihiko Odaki , Hans de Goede Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , "Lee, Chun-Yi" , Mark Gross , Corentin Chary , Cezary Jackiewicz , Matthew Garrett , Pali =?utf-8?Q?Roh=C3=A1r?= , Jonathan Woithe , Ike Panhc , Daniel Dadap , Kenneth Chan , Mattia Dongili , Henrique de Moraes Holschuh , Azael Avalos , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Robert Moore , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, ibm-acpi-devel@lists.sourceforge.net, linux-fbdev@vger.kernel.org, devel@acpica.org Subject: Re: [PATCH 00/22] Fallback to native backlight In-Reply-To: <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221024113513.5205-1-akihiko.odaki@daynix.com> <746e5cc6-516f-8f69-9d4b-8fe237de8fd6@redhat.com> <60672af8-05d2-113c-12b9-d635608be0dd@redhat.com> <7373e258-f7cc-4416-9b1c-c8c9dab59ada@daynix.com> <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Date: Mon, 24 Oct 2022 21:11:08 +0300 Message-ID: <87o7u1drcz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, 25 Oct 2022, Akihiko Odaki wrote: > That aside, the first patch in this series can be applied without the > later patches so you may have a look at it. It's fine if you don't merge > it though since it does not fix really a pragmatic bug as its message says. I think it's problematic because it needlessly ties i915 backlight operation to existence of backlight devices that may not be related to Intel GPU at all. The direction should be multiple supported backlight devices, across GPUs and connectors, but only one per display. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B1B3ECAAA1 for ; Mon, 24 Oct 2022 18:11:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8413010E704; Mon, 24 Oct 2022 18:11:27 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6450810E6D3; Mon, 24 Oct 2022 18:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666635083; x=1698171083; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=5z5J6hyo+xzhPJHRSqQ2l3yOfGRRo8+TjXETgVVrD8A=; b=FVYR0n9zOXJnS/P/R0ocvn+vdcyRzuQ2zPhFwbEQiqnOADKe1u5j2JbB oYmfXOZ1pMdthwNAj3hU+lzEku1wJtl0Vfz8936vdqyuH4fvxI5HuJ1oa cHmCVRNESbMijTnbstkiNfISqdPzFZgN9zqiNCGAhRpksTBg4siH5Qvw2 voD/JM+ySWa1Q8IzwkfAqdR783neBSLpljQ0xaGKCwm/u8LQXtS5fPMjU aR3MkmKisShWTpNJRPZraZpMgmD+B3iqrpLWBYUzdt3upeMoaG9WeRmBK JCS7sJdNoMUuCYKKDIZun829SJNkb0Fe7LyCCNYJF6LzV/JldhpQei70b Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="371707016" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="371707016" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:22 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="609286400" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="609286400" Received: from emontau-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.221]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 11:11:11 -0700 From: Jani Nikula To: Akihiko Odaki , Hans de Goede Subject: Re: [PATCH 00/22] Fallback to native backlight In-Reply-To: <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221024113513.5205-1-akihiko.odaki@daynix.com> <746e5cc6-516f-8f69-9d4b-8fe237de8fd6@redhat.com> <60672af8-05d2-113c-12b9-d635608be0dd@redhat.com> <7373e258-f7cc-4416-9b1c-c8c9dab59ada@daynix.com> <78ad5d7b-4078-0b8e-f4aa-6c8113631359@daynix.com> Date: Mon, 24 Oct 2022 21:11:08 +0300 Message-ID: <87o7u1drcz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Ike Panhc , "Rafael J. Wysocki" , dri-devel@lists.freedesktop.org, Azael Avalos , Mattia Dongili , Daniel Dadap , Henrique de Moraes Holschuh , Daniel Thompson , Jonathan Woithe , Jonathan Corbet , "Lee, Chun-Yi" , Helge Deller , Lee Jones , Robert Moore , linux-acpi@vger.kernel.org, Cezary Jackiewicz , Len Brown , Matthew Garrett , Kenneth Chan , Corentin Chary , intel-gfx@lists.freedesktop.org, acpi4asus-user@lists.sourceforge.net, Mark Gross , Rodrigo Vivi , platform-driver-x86@vger.kernel.org, devel@acpica.org, Tvrtko Ursulin , ibm-acpi-devel@lists.sourceforge.net, Jingoo Han , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , Pali =?utf-8?Q?Roh=C3=A1r?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 25 Oct 2022, Akihiko Odaki wrote: > That aside, the first patch in this series can be applied without the > later patches so you may have a look at it. It's fine if you don't merge > it though since it does not fix really a pragmatic bug as its message says. I think it's problematic because it needlessly ties i915 backlight operation to existence of backlight devices that may not be related to Intel GPU at all. The direction should be multiple supported backlight devices, across GPUs and connectors, but only one per display. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center