From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A3EC433FE for ; Sun, 9 Oct 2022 10:38:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6A43715C1; Sun, 9 Oct 2022 12:37:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6A43715C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665311921; bh=CcsjqTcGwAj+ziFLJaJ3Zrse5rKCk5qYV1LVd7EwuTo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=izhtUQJHKXD0iaIsWD4zVwX7utBg3JZ1UATW+m44O23L5AYbyuuvPPAqZRKFS94RP /3QpWuuSJGzUHjOm4DRbRpPShwvpXVTmjtAZV8pBCYhdruCfxixAJu9yQkRHEBOcbb 0n8YrHUH7vLe6232cLjFK18I6T/1UgfcY0ohACrE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E9C98F80137; Sun, 9 Oct 2022 12:37:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78667F804CB; Sun, 9 Oct 2022 12:37:49 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 982CFF80137 for ; Sun, 9 Oct 2022 12:37:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 982CFF80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="hE7TRBfq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="RkW7uCHn" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE3261F38C; Sun, 9 Oct 2022 10:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1665311862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JwhURA7Ncq8Yvl2ywlztpEJAOr3Of+5oYqA7BiFiE0=; b=hE7TRBfqj/Xj07ZzCU040aimpIoE8OrIC781KGtQc/+WrN1fIdIiMGYa5GV9/KddtYNx3r Um3KP+KAa3556Lhia5WR+nie9+uvyUMCA9eOnF6M/sQLMrR5XuAhMonPrPy7tBgHWRo2Cb vTw7FdDmx7VpstzT3xj602hhMHpNDEI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1665311862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JwhURA7Ncq8Yvl2ywlztpEJAOr3Of+5oYqA7BiFiE0=; b=RkW7uCHnMlsgu310MQUFsNNtFEIlcEQkNyULBTMbVXWtcPPPYimLNQb/SNkKgsRhPEre8F h1SLceaYjq3kNkAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DD41139F0; Sun, 9 Oct 2022 10:37:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DJMpHXakQmPZegAAMHmgww (envelope-from ); Sun, 09 Oct 2022 10:37:42 +0000 Date: Sun, 09 Oct 2022 12:37:41 +0200 Message-ID: <87o7ulffka.wl-tiwai@suse.de> From: Takashi Iwai To: Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= Subject: Re: [PATCH] ALSA: hda: Update register polling macros In-Reply-To: <20221007084856.1638302-1-amadeuszx.slawinski@linux.intel.com> References: <20221007084856.1638302-1-amadeuszx.slawinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Cc: Cezary Rojewski , alsa-devel@alsa-project.org, Takashi Iwai , Jon Hunter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 07 Oct 2022 10:48:56 +0200, Amadeusz Sławiński wrote: > > Recent commit d91857059def ("ALSA: hda: Rework snd_hdac_stream_reset() to use macros") > missed that on some devices register access needs to be done with > unaligned access helper. Change polling macros to use > read_poll_timeout_atomic() in order to specify register read function. > > Reported-by: Jon Hunter > Link: https://lore.kernel.org/alsa-devel/20220818141517.109280-1-amadeuszx.slawinski@linux.intel.com/T/#m1270737db52b5ef163eff73cb5f862d16a07a428 > Reviewed-by: Cezary Rojewski > Signed-off-by: Amadeusz Sławiński Thanks, applied with Fixes tag. Takashi