From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AFCC07E9D for ; Tue, 27 Sep 2022 15:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231167AbiI0PQA (ORCPT ); Tue, 27 Sep 2022 11:16:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbiI0PP6 (ORCPT ); Tue, 27 Sep 2022 11:15:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF516F4C; Tue, 27 Sep 2022 08:15:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BE0961A22; Tue, 27 Sep 2022 15:15:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92B89C433C1; Tue, 27 Sep 2022 15:15:54 +0000 (UTC) References: <20220926124359.304770-1-patrice.chotard@foss.st.com> User-agent: mu4e 1.8.9; emacs 28.2 From: Felipe Balbi To: patrice.chotard@foss.st.com Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Serge Semin , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Audu Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name Date: Tue, 27 Sep 2022 18:15:18 +0300 In-reply-to: <20220926124359.304770-1-patrice.chotard@foss.st.com> Message-ID: <87o7v0g860.fsf@balbi.sh> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org writes: > From: Patrice Chotard > > Update node's child name from "dwc3" to "usb", this fixes > the following issue: > > [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node > > Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name") > > Reported-by: Jerome Audu > Signed-off-by: Patrice Chotard > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 166b5bde45cb..6c14a79279f9 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "dwc3"); > + child = of_get_child_by_name(node, "usb"); there could be DTBs in the wild which have `dwc3' as the child name. It seems to me that you should try both names, instead. -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5AE97C6FA8E for ; Tue, 27 Sep 2022 15:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z897o73kzkArmvbfXNLYiQGDRkNBrmcqpX6QLyv5IIs=; b=GjnOasrmI1Qxyb uIEAktGBFeSilcRbmKlLVo2yP6MHBUZ2IeMm+DjCNPffVdxrUq+y+9kxvF2+Gsl1uamtqjDt5HdZm 0HE5wMDmHlcsKJhoAzCzWg838QZ5OvtYT9rLCWhZuPiTRd2yVHu8Az/uATC/cWAkipml2Kl9xyndM u950cOs4gwT2SmaxyRFsUPePo2+jiH2c6vBdLnZ1QRlOzRQXAxMiVziG3X6Q5UE5VtGMKUr27ZbpY Lz+ABhxxP59x3bDuTEA5PGE8Y0btA2fpwDgwkYPZlItnvnj4nWlj53qRUnoxfGk6YocMgRE4CC0Qm DV0p1fxeyf8P3+4hwjfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCJU-00BOt3-Q9; Tue, 27 Sep 2022 15:16:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odCJS-00BOsP-Pv for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 15:16:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5739E61A1D; Tue, 27 Sep 2022 15:15:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92B89C433C1; Tue, 27 Sep 2022 15:15:54 +0000 (UTC) References: <20220926124359.304770-1-patrice.chotard@foss.st.com> User-agent: mu4e 1.8.9; emacs 28.2 From: Felipe Balbi To: patrice.chotard@foss.st.com Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Serge Semin , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Audu Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name Date: Tue, 27 Sep 2022 18:15:18 +0300 In-reply-to: <20220926124359.304770-1-patrice.chotard@foss.st.com> Message-ID: <87o7v0g860.fsf@balbi.sh> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_081558_915848_D917151A X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org writes: > From: Patrice Chotard > > Update node's child name from "dwc3" to "usb", this fixes > the following issue: > > [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node > > Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name") > > Reported-by: Jerome Audu > Signed-off-by: Patrice Chotard > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 166b5bde45cb..6c14a79279f9 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "dwc3"); > + child = of_get_child_by_name(node, "usb"); there could be DTBs in the wild which have `dwc3' as the child name. It seems to me that you should try both names, instead. -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel