From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF57DECAAD3 for ; Wed, 14 Sep 2022 07:32:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C5273165D; Wed, 14 Sep 2022 09:31:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C5273165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1663140731; bh=eGJEEQGaWbXVMP2wdS5hU6cS1e8CCUpICd1zdnYhApo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Qq9hOu6rGdoH5PdLQn4tM6oTIIxtFZGYHC+M0VXiI2gp/DOa7RskXKSyFYLlWTmM9 MCa7Eauuoi+lJInqbVFe6KWN1DIuEqX8H99/YTIHReLWKtYR1ZL6rLeI8hgX0gvOw1 nLD4MBMXy+ad/q1o1nnS2P6nlidLNQePfXDuPvWg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4F74AF8014B; Wed, 14 Sep 2022 09:31:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF500F8014E; Wed, 14 Sep 2022 09:31:19 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 73347F800C0 for ; Wed, 14 Sep 2022 09:31:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 73347F800C0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DTdfEEt8"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5b5knvF0" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 270F95CD19; Wed, 14 Sep 2022 07:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663140676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QnGQU0HXe/e+xbNYokwocBTfSdmim06SFOGKj93RpFk=; b=DTdfEEt8fc+MHm7XSJtHwSVn07nU1UcNfaGG91BNtwjCDBHz84SzMI+TaVVTe2CV8xHQbe tCxYFZfF+fglWLugQW46zYtGOmq1FdEPm0a9sbeRKXM0wpFHu3xif0c/FoMDjp2vbq1H1e 1QunjnQkAIXbvETmU2ZTQdq/+qj31rI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663140676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QnGQU0HXe/e+xbNYokwocBTfSdmim06SFOGKj93RpFk=; b=5b5knvF0WrF8zpEjYpDJPtKFUTaW82VDvMEswxW8S7sCzGEJ1twcGxyxzk+pXrdh9X+Wbo dV+EJFbwLoKmobAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0DDA3134B3; Wed, 14 Sep 2022 07:31:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LGW8AkSDIWM7bwAAMHmgww (envelope-from ); Wed, 14 Sep 2022 07:31:16 +0000 Date: Wed, 14 Sep 2022 09:31:15 +0200 Message-ID: <87o7vie7jw.wl-tiwai@suse.de> From: Takashi Iwai To: acheronfail Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5560 laptop In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 14 Sep 2022 08:41:01 +0200, acheronfail wrote: > > This is my first patch, so let me know if I need to do anything > differently. :) > > The Dell Precision 5570 uses the same 4-speakers-on-ALC289 just like the > previous Precision 5560. I replicated that patch onto this one, and can > confirm that the audio is much better (the woofers are now working); > I've tested it on my Dell Precision 5570. The code change looks OK, but please put your Signed-off-by tag to the patch. This is a legal requirement; it has to be with a real name and a mail address. Also, a comment like a greeting in the above can be placed below the line "---" (between that and diffstat lines). It will be truncated when applying the patch, so you can put only the text that should be included in the git commit log in the patch description. Last but not least, it's better to add maintainers to Cc. In this case, put me. Could you fix it and resubmit a v2 patch? thanks, Takashi > > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 799f6bf266dd..b0ad4856b877 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9130,6 +9130,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1028, 0x0a9d, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x0a9e, "Dell Latitude 5430", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x0b19, "Dell XPS 15 9520", ALC289_FIXUP_DUAL_SPK), > + SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), > SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), > -- > 2.37.3 >