From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FEEECAAD5 for ; Fri, 2 Sep 2022 15:22:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236087AbiIBPWD (ORCPT ); Fri, 2 Sep 2022 11:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235745AbiIBPVm (ORCPT ); Fri, 2 Sep 2022 11:21:42 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9DE158A84; Fri, 2 Sep 2022 07:54:24 -0700 (PDT) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 622B9C0002; Fri, 2 Sep 2022 14:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662130461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjA2LlA0OrAFyjrKnUOD6lqWgwSmggNzmFY+qSRLKb0=; b=PTdNAZVwA2xm8zcn9E4iVOSVlfj7soqVTvmq3U3gLI2i+Vj/tu2xTrsXJhjJBsrVgBBiRs ZLwnSU9whjJGWXjM1tjC+PfxhI5MxD6iFpQwxUJiDhErjUia5FA1xpDi69q5CP5dL0ARg4 KsUqiO51UaJmFO+334VsE1DJBcuPYkCVIVX8NvGLmQY/+92TxQmnqY48VHayy4p4Zf6Rp1 zXos+tqeEmY8hEin0h0mcpLULx+rl2qNfKwenCWYvZyfKEPX/OIRxYUHKepqRuoYZbWyh7 yH4dVRux5TRjQouYK6vOdn5P2LIIUBhPDIBL0modfKp4Zu2Iu3slK78+1qrSVQ== From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Rob Herring , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] PCI: mvebu: Add support for error interrupt In-Reply-To: <20220817230036.817-1-pali@kernel.org> References: <20220817230036.817-1-pali@kernel.org> Date: Fri, 02 Sep 2022 16:54:20 +0200 Message-ID: <87o7vxesir.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Pali Roh=C3=A1r writes: > PCI mvebu error interrupt source is triggered for non-INTx event. > So e.g. when AER or PME event occurs. > > This patch series adds support for reporting AER and PME interrupts on > Marvell PCIe Root Ports which allows use to kernel AER and PME drivers. > > Without this change kernel AER and PME drivers do not work at all. > > DT bindings for this support is currently provided only for Kirkwood and > Dove platforms as other new mvebu SoCs requires extension to armada IRQ > driver, which is currently disallowed. > > Without new DTS files, pci-mvebu.c driver acts as before this change, > there is no AER and PME kernel support. > > I have tested this change on Armada 385 board (with additional changes > to A385 DTS files and IRQ driver, not included there) and AER interrupt > is delivered to kernel AER driver correctly. > > Pali Roh=C3=A1r (4): > dt-bindings: PCI: mvebu: Update information about error interrupt > PCI: mvebu: Implement support for interrupts on emulated bridge > ARM: dts: kirkwood: Add definitions for PCIe error interrupts > ARM: dts: dove: Add definitions for PCIe error interrupts Applied both dts patches on mvebu/dt Thanks, Gregory > > .../devicetree/bindings/pci/mvebu-pci.txt | 1 + > arch/arm/boot/dts/dove.dtsi | 8 +- > arch/arm/boot/dts/kirkwood-6192.dtsi | 4 +- > arch/arm/boot/dts/kirkwood-6281.dtsi | 4 +- > arch/arm/boot/dts/kirkwood-6282.dtsi | 8 +- > arch/arm/boot/dts/kirkwood-98dx4122.dtsi | 4 +- > drivers/pci/controller/pci-mvebu.c | 256 ++++++++++++++++-- > 7 files changed, 252 insertions(+), 33 deletions(-) > > --=20 > 2.20.1 > --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C39E7ECAAD5 for ; Fri, 2 Sep 2022 14:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w4NqxOLJq48nBmLSKjUNTQuV8CYYty0q3Mm88iOEGQ8=; b=2EUSdQQfRBxww+ GhpTj2woNwOJzcOcxmNMc68NMiptf51l0z1cHUgjK4LbddyucVuT6vJgenCHn9Zqgs7zQVV0D0WSk 6blldiZUQg+YicUuNfNKKMswmav+GO1xo6WK1r7U4Mu0asN8aSO91Ph27teX69WYDpaOvIDWbn6oy YuoKBXU2JhLWyInHBdy7BMD1isj4iBmDvQE8DX8sF+1/DavDyFsvMhfQiJk/SHu2fiSVpDKhpZqVB Brf7sZ5GoAHor+Eb6VpuscgQ8QF7pzsrMEa8T/ZjeFvsspVW2eyzq6Gr4Sm+MqVQ5oSCgmt8EITSt ny1hJQaBWkig3RluROEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU84I-005pph-H8; Fri, 02 Sep 2022 14:54:51 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU83v-005pUN-Go for linux-arm-kernel@lists.infradead.org; Fri, 02 Sep 2022 14:54:29 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 622B9C0002; Fri, 2 Sep 2022 14:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1662130461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjA2LlA0OrAFyjrKnUOD6lqWgwSmggNzmFY+qSRLKb0=; b=PTdNAZVwA2xm8zcn9E4iVOSVlfj7soqVTvmq3U3gLI2i+Vj/tu2xTrsXJhjJBsrVgBBiRs ZLwnSU9whjJGWXjM1tjC+PfxhI5MxD6iFpQwxUJiDhErjUia5FA1xpDi69q5CP5dL0ARg4 KsUqiO51UaJmFO+334VsE1DJBcuPYkCVIVX8NvGLmQY/+92TxQmnqY48VHayy4p4Zf6Rp1 zXos+tqeEmY8hEin0h0mcpLULx+rl2qNfKwenCWYvZyfKEPX/OIRxYUHKepqRuoYZbWyh7 yH4dVRux5TRjQouYK6vOdn5P2LIIUBhPDIBL0modfKp4Zu2Iu3slK78+1qrSVQ== From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Rob Herring , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] PCI: mvebu: Add support for error interrupt In-Reply-To: <20220817230036.817-1-pali@kernel.org> References: <20220817230036.817-1-pali@kernel.org> Date: Fri, 02 Sep 2022 16:54:20 +0200 Message-ID: <87o7vxesir.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220902_075427_717895_666B0A2C X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4gd3JpdGVzOgoKPiBQQ0kgbXZlYnUgZXJyb3Ig aW50ZXJydXB0IHNvdXJjZSBpcyB0cmlnZ2VyZWQgZm9yIG5vbi1JTlR4IGV2ZW50Lgo+IFNvIGUu Zy4gd2hlbiBBRVIgb3IgUE1FIGV2ZW50IG9jY3Vycy4KPgo+IFRoaXMgcGF0Y2ggc2VyaWVzIGFk ZHMgc3VwcG9ydCBmb3IgcmVwb3J0aW5nIEFFUiBhbmQgUE1FIGludGVycnVwdHMgb24KPiBNYXJ2 ZWxsIFBDSWUgUm9vdCBQb3J0cyB3aGljaCBhbGxvd3MgdXNlIHRvIGtlcm5lbCBBRVIgYW5kIFBN RSBkcml2ZXJzLgo+Cj4gV2l0aG91dCB0aGlzIGNoYW5nZSBrZXJuZWwgQUVSIGFuZCBQTUUgZHJp dmVycyBkbyBub3Qgd29yayBhdCBhbGwuCj4KPiBEVCBiaW5kaW5ncyBmb3IgdGhpcyBzdXBwb3J0 IGlzIGN1cnJlbnRseSBwcm92aWRlZCBvbmx5IGZvciBLaXJrd29vZCBhbmQKPiBEb3ZlIHBsYXRm b3JtcyBhcyBvdGhlciBuZXcgbXZlYnUgU29DcyByZXF1aXJlcyBleHRlbnNpb24gdG8gYXJtYWRh IElSUQo+IGRyaXZlciwgd2hpY2ggaXMgY3VycmVudGx5IGRpc2FsbG93ZWQuCj4KPiBXaXRob3V0 IG5ldyBEVFMgZmlsZXMsIHBjaS1tdmVidS5jIGRyaXZlciBhY3RzIGFzIGJlZm9yZSB0aGlzIGNo YW5nZSwKPiB0aGVyZSBpcyBubyBBRVIgYW5kIFBNRSBrZXJuZWwgc3VwcG9ydC4KPgo+IEkgaGF2 ZSB0ZXN0ZWQgdGhpcyBjaGFuZ2Ugb24gQXJtYWRhIDM4NSBib2FyZCAod2l0aCBhZGRpdGlvbmFs IGNoYW5nZXMKPiB0byBBMzg1IERUUyBmaWxlcyBhbmQgSVJRIGRyaXZlciwgbm90IGluY2x1ZGVk IHRoZXJlKSBhbmQgQUVSIGludGVycnVwdAo+IGlzIGRlbGl2ZXJlZCB0byBrZXJuZWwgQUVSIGRy aXZlciBjb3JyZWN0bHkuCj4KPiBQYWxpIFJvaMOhciAoNCk6Cj4gICBkdC1iaW5kaW5nczogUENJ OiBtdmVidTogVXBkYXRlIGluZm9ybWF0aW9uIGFib3V0IGVycm9yIGludGVycnVwdAo+ICAgUENJ OiBtdmVidTogSW1wbGVtZW50IHN1cHBvcnQgZm9yIGludGVycnVwdHMgb24gZW11bGF0ZWQgYnJp ZGdlCgoKPiAgIEFSTTogZHRzOiBraXJrd29vZDogQWRkIGRlZmluaXRpb25zIGZvciBQQ0llIGVy cm9yIGludGVycnVwdHMKPiAgIEFSTTogZHRzOiBkb3ZlOiBBZGQgZGVmaW5pdGlvbnMgZm9yIFBD SWUgZXJyb3IgaW50ZXJydXB0cwoKQXBwbGllZCBib3RoIGR0cyBwYXRjaGVzIG9uIG12ZWJ1L2R0 CgpUaGFua3MsCgpHcmVnb3J5CgoKPgo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvbXZl YnUtcGNpLnR4dCAgICAgfCAgIDEgKwo+ICBhcmNoL2FybS9ib290L2R0cy9kb3ZlLmR0c2kgICAg ICAgICAgICAgICAgICAgfCAgIDggKy0KPiAgYXJjaC9hcm0vYm9vdC9kdHMva2lya3dvb2QtNjE5 Mi5kdHNpICAgICAgICAgIHwgICA0ICstCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2tpcmt3b29kLTYy ODEuZHRzaSAgICAgICAgICB8ICAgNCArLQo+ICBhcmNoL2FybS9ib290L2R0cy9raXJrd29vZC02 MjgyLmR0c2kgICAgICAgICAgfCAgIDggKy0KPiAgYXJjaC9hcm0vYm9vdC9kdHMva2lya3dvb2Qt OThkeDQxMjIuZHRzaSAgICAgIHwgICA0ICstCj4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNp LW12ZWJ1LmMgICAgICAgICAgICB8IDI1NiArKysrKysrKysrKysrKysrLS0KPiAgNyBmaWxlcyBj aGFuZ2VkLCAyNTIgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCj4KPiAtLSAKPiAyLjIw LjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRlZCBMaW51eCBhbmQgS2Vy bmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=