From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF3D7ECAAD4 for ; Wed, 31 Aug 2022 11:52:33 +0000 (UTC) Received: from localhost ([::1]:39746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTMGm-0000TQ-R2 for qemu-devel@archiver.kernel.org; Wed, 31 Aug 2022 07:52:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMFR-0007PL-7W for qemu-devel@nongnu.org; Wed, 31 Aug 2022 07:51:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:55615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTMFO-000624-Jo for qemu-devel@nongnu.org; Wed, 31 Aug 2022 07:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661946666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xHmCbNrgJwDnNg22Njswu5KH/HUaa7Hz87QKj//j62A=; b=T2iJ9pLJQn4L0D/oQJM6u1PusLMMFnZJp4g0zDLqrPPoW9J64mBS2eFGMKE6S/jzSJfJaA eFO8EnqixMvanN0DQQl/Kchs6irEixCJVkZ/H4vEGp25BPw+JtdnaHQIXLNhqFrfO7M2qw yQZwq2e2TZQZ/Nd3G3tzqP0VxMjJXoI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-O3TbfGgTN6iHBpgSt1ep2A-1; Wed, 31 Aug 2022 07:51:02 -0400 X-MC-Unique: O3TbfGgTN6iHBpgSt1ep2A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 512643C01DA0; Wed, 31 Aug 2022 11:51:02 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 27D274010D43; Wed, 31 Aug 2022 11:51:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0FF4121E6900; Wed, 31 Aug 2022 13:51:01 +0200 (CEST) From: Markus Armbruster To: Victor Toso Cc: qemu-devel@nongnu.org, Eric Blake , John Snow , Michael Roth Subject: Re: [PATCH v1 04/16] qapi: fix example of query-rocker-of-dpa-flows command References: <20220830161545.84198-1-victortoso@redhat.com> <20220830161545.84198-5-victortoso@redhat.com> Date: Wed, 31 Aug 2022 13:51:01 +0200 In-Reply-To: <20220830161545.84198-5-victortoso@redhat.com> (Victor Toso's message of "Tue, 30 Aug 2022 18:15:33 +0200") Message-ID: <87o7w0aaxm.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Victor Toso writes: > Example output has an extra ',' delimiter and a foreign comment > format. Fix it. > > Problem was noticed when trying to load the example into python's json > library. > > Signed-off-by: Victor Toso > --- > qapi/rocker.json | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qapi/rocker.json b/qapi/rocker.json > index b48e49a89b..6ae8689026 100644 > --- a/qapi/rocker.json > +++ b/qapi/rocker.json > @@ -251,8 +251,7 @@ > # "cookie": 0, > # "action": {"goto-tbl": 10}, > # "mask": {"in-pport": 4294901760} > -# }, > -# {...more...}, > +# } > # ]} > # > ## Review of previous patch applies.