From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168F9CCA487 for ; Thu, 21 Jul 2022 13:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbiGUNeQ (ORCPT ); Thu, 21 Jul 2022 09:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiGUNeP (ORCPT ); Thu, 21 Jul 2022 09:34:15 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DB02643C0 for ; Thu, 21 Jul 2022 06:34:14 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id d8so2307156wrp.6 for ; Thu, 21 Jul 2022 06:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=m9tu5kfLkLBgd8ubz/EUC+KagXbqcDn5HWzdWJeSb3Y=; b=6v6Hu/g3Zo0GWLuMb/6idFPyuTqciNcRwGDVx+n8h2Rqq65ZCYzPnMS6hb3+hpO23F 8wEH+HIznFFlGbx8xvFvRSSV6krJRDxtCTbvWGXiTuIsk5Ab0S1+Wu9UG0kbhA7RaGb5 cea6QvDNyrFOH2+4jTRq53uq/wOo/xiG/PQA0q8jj8jDWiTqn4LTpinsH6p9meJUhpc/ R+E17VM4zjcQvngCUXrU91UwkqlvtXEzfIHOVaDG5TS6XLvyhD5kbZ7v5t45lo1e107K utNwAJI1DYsHvrguolIH1iwujd59CZEAOjkrTNQE2zvhMVUs+FN8UeMrU1ebDv40k3Se v8PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=m9tu5kfLkLBgd8ubz/EUC+KagXbqcDn5HWzdWJeSb3Y=; b=yP7sZ/sVtCQ8TVVnx56SycoG0L08BxN7wWNL60PZIE2hCds1ZdFJwaRBrOXP1keTDX ryjCMQWCkDgsO8sRP5AzFMaLlswZVJZh1wWnut1H9xJRoLT8p9KH8r4Soic33CxQsAxN 8JCMfQozzckrSLkFiE68KsqBc/KSXd79tPs8s4fTOIIW782mw59cF2sIV63F6Gsxo9uj QUN+ZuRxEeda7iCfPkmjlc5tMlz8e9WmE/13xXXqcbY39DbkRrnXSjzPxyApuTanBCR2 8BwXVVeXNSRXytelGjENnWphRRFmv0461LT9uPZRccKKoecT9+rfmqo8Zp9xTRtGrW6G T23g== X-Gm-Message-State: AJIora/zDAYn8kpadTat7isg6eP+Ovh1bezbxmXkcP9291DWB/p6AFOh a8metQLUHOLmqrrsTMKKbTXvTQ== X-Google-Smtp-Source: AGRyM1vFMRoTO4e+uNQGZXhzHMNWPBJJ+oaO5moEg5utkAab7eiYnQAw585oYLpHYefDneVsptGijA== X-Received: by 2002:a5d:6848:0:b0:21e:5e37:b2e4 with SMTP id o8-20020a5d6848000000b0021e5e37b2e4mr11612wrw.530.1658410452448; Thu, 21 Jul 2022 06:34:12 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id p10-20020adff20a000000b0021baf5e590dsm1907554wro.71.2022.07.21.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 06:34:12 -0700 (PDT) From: Mattijs Korpershoek To: AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys In-Reply-To: References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-3-ef9fc29dbff4@baylibre.com> Date: Thu, 21 Jul 2022 15:34:11 +0200 Message-ID: <87o7xih9nw.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Jul 21, 2022 at 10:40, AngeloGioacchino Del Regno wrote: > Il 20/07/22 16:48, Mattijs Korpershoek ha scritto: >> MediaTek keypad has 2 modes of detecting key events: >> - single key: each (row, column) can detect one key >> - double key: each (row, column) is a group of 2 keys >> >> Currently, only single key detection is supported (by default) >> Add an optional property, mediatek,double-keys to support double >> key detection. >> >> Double key support exists to minimize cost, since it reduces the number >> of pins required for physical keys. >> >> Signed-off-by: Mattijs Korpershoek >> >> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> index ca8ae40a73f7..03c9555849e5 100644 >> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> @@ -49,6 +49,12 @@ properties: >> maximum: 256 >> default: 16 >> >> + mediatek,double-keys: >> + description: | >> + use double key matrix instead of single key >> + when set, each (row,column) is a group that can detect 2 keys > > We can make it shorter and (imo) easier to understand, like: > > mediatek,double-keys: > > description: Each (row, column) group has two keys > > ...also because, if we say that the group "can detect" two keys, it may be > creating a misunderstandment such as "if I press one key, it gives me two > different input events for two different keys.", which is something that > wouldn't make a lot of sense, would it? :-) Hi AngeloGioacchino, Thank you for the suggestion. I like your description better as well :) Will use it in v2. > >> + type: boolean >> + >> required: >> - compatible >> - reg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87BBBC433EF for ; Thu, 21 Jul 2022 13:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KDTEB8vb7XIeVkgsFp89WuChINll9jdumyfdLYTLtBw=; b=r1u/66pV9dn4Nn WmGtiN7MxyXPxgwdDb8PAEZnqRFXr0rnorAtDjw5NicqI5JTZ4K0AoplMWstG+NgzmjhEepNGepsu BqPtuwSRyraRf81FXF9xPhJPXgJ4+lRX1FW1D6xnfGkwvjSVXtg0Mu20Tj4pks7tq0GMvkQEjS/38 1o0VKM8hIR4gG6tryHPZZmErDc6DNTr2xKCpTcRxoz3Kdk4bUHttbNc6R4p7VFsiUgYbuV3pgnrao FyPwky4UmPkhpo7xqsfNepKi3snw5Q+Z96Czb/dAQHTq1qS82OQuPhi3WJdM8dImAnirsc2uVTqSQ 4IPpfM7FrMZFTrCM05XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEWNy-0079HB-BY; Thu, 21 Jul 2022 13:38:38 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEWJi-0075h2-13 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 13:34:15 +0000 Received: by mail-wr1-x435.google.com with SMTP id bk26so2285651wrb.11 for ; Thu, 21 Jul 2022 06:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=m9tu5kfLkLBgd8ubz/EUC+KagXbqcDn5HWzdWJeSb3Y=; b=6v6Hu/g3Zo0GWLuMb/6idFPyuTqciNcRwGDVx+n8h2Rqq65ZCYzPnMS6hb3+hpO23F 8wEH+HIznFFlGbx8xvFvRSSV6krJRDxtCTbvWGXiTuIsk5Ab0S1+Wu9UG0kbhA7RaGb5 cea6QvDNyrFOH2+4jTRq53uq/wOo/xiG/PQA0q8jj8jDWiTqn4LTpinsH6p9meJUhpc/ R+E17VM4zjcQvngCUXrU91UwkqlvtXEzfIHOVaDG5TS6XLvyhD5kbZ7v5t45lo1e107K utNwAJI1DYsHvrguolIH1iwujd59CZEAOjkrTNQE2zvhMVUs+FN8UeMrU1ebDv40k3Se v8PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=m9tu5kfLkLBgd8ubz/EUC+KagXbqcDn5HWzdWJeSb3Y=; b=rKhpGxvFvAmmuxp+db/H2jfpE2dlri45cLLRoMHkfZbA308SeqPgdlq5xynpCebkhK qIaNlgLu3dDJdUNT/gKPkmNpDN6qBBF5ZVk2bqUY5uKmGN3a7weC9F0pwbPX9etYEamc VEWdVv0ANmrPfg/slWglgcs58hUv87HUCOkzctnsPewjjds7LYwRdelaTe+fV6JIcVCQ Cr2ez7vNsBOiXDac3T8tHwKzLQ0zi9979U8oTy6tju3Y5ipkSv9B3FAg0tgXirfMh24X qDqal7bd70AsoeKYnKAMCn2FZEd9KmbPbVaYH/StHE13COBiu1tLRNhMISNAHtBBnh8F zKjA== X-Gm-Message-State: AJIora/yIFrF0nft22BbEuuxZGzi0tOiocd3WtwKuuxgtYW25WtoSGDH 0WICICu1cgNz0Xm3FmyDBInDgA== X-Google-Smtp-Source: AGRyM1vFMRoTO4e+uNQGZXhzHMNWPBJJ+oaO5moEg5utkAab7eiYnQAw585oYLpHYefDneVsptGijA== X-Received: by 2002:a5d:6848:0:b0:21e:5e37:b2e4 with SMTP id o8-20020a5d6848000000b0021e5e37b2e4mr11612wrw.530.1658410452448; Thu, 21 Jul 2022 06:34:12 -0700 (PDT) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id p10-20020adff20a000000b0021baf5e590dsm1907554wro.71.2022.07.21.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 06:34:12 -0700 (PDT) From: Mattijs Korpershoek To: AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Dmitry Torokhov , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys In-Reply-To: References: <20220720-mt8183-keypad-v1-0-ef9fc29dbff4@baylibre.com> <20220720-mt8183-keypad-v1-3-ef9fc29dbff4@baylibre.com> Date: Thu, 21 Jul 2022 15:34:11 +0200 Message-ID: <87o7xih9nw.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_063414_099231_680E50DB X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 21, 2022 at 10:40, AngeloGioacchino Del Regno wrote: > Il 20/07/22 16:48, Mattijs Korpershoek ha scritto: >> MediaTek keypad has 2 modes of detecting key events: >> - single key: each (row, column) can detect one key >> - double key: each (row, column) is a group of 2 keys >> >> Currently, only single key detection is supported (by default) >> Add an optional property, mediatek,double-keys to support double >> key detection. >> >> Double key support exists to minimize cost, since it reduces the number >> of pins required for physical keys. >> >> Signed-off-by: Mattijs Korpershoek >> >> diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> index ca8ae40a73f7..03c9555849e5 100644 >> --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml >> @@ -49,6 +49,12 @@ properties: >> maximum: 256 >> default: 16 >> >> + mediatek,double-keys: >> + description: | >> + use double key matrix instead of single key >> + when set, each (row,column) is a group that can detect 2 keys > > We can make it shorter and (imo) easier to understand, like: > > mediatek,double-keys: > > description: Each (row, column) group has two keys > > ...also because, if we say that the group "can detect" two keys, it may be > creating a misunderstandment such as "if I press one key, it gives me two > different input events for two different keys.", which is something that > wouldn't make a lot of sense, would it? :-) Hi AngeloGioacchino, Thank you for the suggestion. I like your description better as well :) Will use it in v2. > >> + type: boolean >> + >> required: >> - compatible >> - reg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel