From: Richard Palethorpe <rpalethorpe@suse.de>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] security/dirtyc0w: fix typo
Date: Mon, 11 Jul 2022 11:02:52 +0100 [thread overview]
Message-ID: <87o7xwneq7.fsf@suse.de> (raw)
In-Reply-To: <1657190760-2272-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hello,
Yang Xu <xuyang2018.jy@fujitsu.com> writes:
> s/dirtyc0w/dirtycow/
I assume it's l33t speak, not a typo. Did the spelling cause a problem?
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> runtest/cve | 2 +-
> runtest/syscalls | 2 +-
> testcases/kernel/security/dirtyc0w/.gitignore | 2 --
> testcases/kernel/security/dirtycow/.gitignore | 2 ++
> testcases/kernel/security/{dirtyc0w => dirtycow}/Makefile | 2 +-
> .../security/{dirtyc0w/dirtyc0w.c => dirtycow/dirtycow.c} | 6 +++---
> .../dirtyc0w_child.c => dirtycow/dirtycow_child.c} | 0
> 7 files changed, 8 insertions(+), 8 deletions(-)
> delete mode 100644 testcases/kernel/security/dirtyc0w/.gitignore
> create mode 100644 testcases/kernel/security/dirtycow/.gitignore
> rename testcases/kernel/security/{dirtyc0w => dirtycow}/Makefile (86%)
> rename testcases/kernel/security/{dirtyc0w/dirtyc0w.c => dirtycow/dirtycow.c} (94%)
> rename testcases/kernel/security/{dirtyc0w/dirtyc0w_child.c => dirtycow/dirtycow_child.c} (100%)
>
> diff --git a/runtest/cve b/runtest/cve
> index 9ab6dc282..3727f58c3 100644
> --- a/runtest/cve
> +++ b/runtest/cve
> @@ -9,7 +9,7 @@ cve-2015-7550 keyctl02
> cve-2016-4470 keyctl01.sh
> cve-2015-3290 cve-2015-3290
> cve-2016-4997 setsockopt03
> -cve-2016-5195 dirtyc0w
> +cve-2016-5195 dirtycow
> cve-2016-7042 cve-2016-7042
> cve-2016-7117 cve-2016-7117
> cve-2016-8655 setsockopt06
> diff --git a/runtest/syscalls b/runtest/syscalls
> index efef18136..111ef6f90 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -1034,7 +1034,7 @@ process_vm_writev01 process_vm01 -w
> process_vm_writev02 process_vm_writev02
>
> prot_hsymlinks prot_hsymlinks
> -dirtyc0w dirtyc0w
> +dirtycow dirtycow
> dirtypipe dirtypipe
>
> pselect01 pselect01
> diff --git a/testcases/kernel/security/dirtyc0w/.gitignore b/testcases/kernel/security/dirtyc0w/.gitignore
> deleted file mode 100644
> index 7700d91a3..000000000
> --- a/testcases/kernel/security/dirtyc0w/.gitignore
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -dirtyc0w
> -dirtyc0w_child
> diff --git a/testcases/kernel/security/dirtycow/.gitignore b/testcases/kernel/security/dirtycow/.gitignore
> new file mode 100644
> index 000000000..ad36ce53c
> --- /dev/null
> +++ b/testcases/kernel/security/dirtycow/.gitignore
> @@ -0,0 +1,2 @@
> +dirtycow
> +dirtycow_child
> diff --git a/testcases/kernel/security/dirtyc0w/Makefile b/testcases/kernel/security/dirtycow/Makefile
> similarity index 86%
> rename from testcases/kernel/security/dirtyc0w/Makefile
> rename to testcases/kernel/security/dirtycow/Makefile
> index bf26d9eb6..07759a0e3 100644
> --- a/testcases/kernel/security/dirtyc0w/Makefile
> +++ b/testcases/kernel/security/dirtycow/Makefile
> @@ -4,5 +4,5 @@
> top_srcdir ?= ../../../..
>
> include $(top_srcdir)/include/mk/testcases.mk
> -dirtyc0w_child: CFLAGS+=-pthread
> +dirtycow_child: CFLAGS+=-pthread
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/testcases/kernel/security/dirtyc0w/dirtyc0w.c b/testcases/kernel/security/dirtycow/dirtycow.c
> similarity index 94%
> rename from testcases/kernel/security/dirtyc0w/dirtyc0w.c
> rename to testcases/kernel/security/dirtycow/dirtycow.c
> index 7924285a7..881e376c5 100644
> --- a/testcases/kernel/security/dirtyc0w/dirtyc0w.c
> +++ b/testcases/kernel/security/dirtycow/dirtycow.c
> @@ -55,7 +55,7 @@ static void setup(void)
> nobody_gid = pw->pw_gid;
> }
>
> -void dirtyc0w_test(void)
> +void dirtycow_test(void)
> {
> int i, fd, pid, fail = 0;
> char c;
> @@ -70,7 +70,7 @@ void dirtyc0w_test(void)
> if (!pid) {
> SAFE_SETGID(nobody_gid);
> SAFE_SETUID(nobody_uid);
> - SAFE_EXECLP("dirtyc0w_child", "dirtyc0w_child", NULL);
> + SAFE_EXECLP("dirtycow_child", "dirtycow_child", NULL);
> }
>
> TST_CHECKPOINT_WAIT(0);
> @@ -100,7 +100,7 @@ static struct tst_test test = {
> .forks_child = 1,
> .needs_root = 1,
> .setup = setup,
> - .test_all = dirtyc0w_test,
> + .test_all = dirtycow_test,
> .tags = (const struct tst_tag[]) {
> {"linux-git", "4ceb5db9757a"},
> {"linux-git", "19be0eaffa3a"},
> diff --git a/testcases/kernel/security/dirtyc0w/dirtyc0w_child.c b/testcases/kernel/security/dirtycow/dirtycow_child.c
> similarity index 100%
> rename from testcases/kernel/security/dirtyc0w/dirtyc0w_child.c
> rename to testcases/kernel/security/dirtycow/dirtycow_child.c
> --
> 2.27.0
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-07-11 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 10:46 [LTP] [PATCH] security/dirtyc0w: fix typo Yang Xu
2022-07-11 10:02 ` Richard Palethorpe [this message]
2022-07-11 10:21 ` Li Wang
2022-07-12 1:28 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7xwneq7.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.