All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Romain Naour <romain.naour@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/upower: bump to version 0.99.19
Date: Tue, 28 Jun 2022 08:04:19 +0200	[thread overview]
Message-ID: <87o7ydqq70.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220619173206.812991-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sun, 19 Jun 2022 19:32:06 +0200")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > - Switch site to get latest release
 > - Switch to meson-package (autotools dropped since version 0.99.14)
 > - libusb is not a dependency since
 >   https://gitlab.freedesktop.org/upower/upower/-/commit/64582256a8c75127c3de23f5542c8467e2e9484a
 > - Update indentation in hash file (two spaces)

 > https://gitlab.freedesktop.org/upower/upower/-/blob/v0.99.19/NEWS

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/upower/Config.in   |  9 +++------
 >  package/upower/upower.hash |  4 ++--
 >  package/upower/upower.mk   | 20 ++++++++++++--------
 >  3 files changed, 17 insertions(+), 16 deletions(-)

 > diff --git a/package/upower/Config.in b/package/upower/Config.in
 > index 612a2b74b9..e2bcdd12c3 100644
 > --- a/package/upower/Config.in
 > +++ b/package/upower/Config.in
 > @@ -1,12 +1,10 @@
 >  config BR2_PACKAGE_UPOWER
 >  	bool "upower"
 >  	depends on BR2_PACKAGE_HAS_UDEV
 > -	depends on BR2_TOOLCHAIN_HAS_THREADS # libgudev, libusb
 > -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb

thermald selects upower, but you forgot to drop the gcc dependency from
thermald.
 
 > -UPOWER_CONF_OPTS = --disable-man-pages --disable-tests
 > +UPOWER_CONF_OPTS = \
 > +	-Dgtk-doc=false \
 > +	-Dman=false \
 > +	-Dsystemdsystemunitdir=/usr/lib/systemd/system \
 > +	-Dudevhwdbdir=/lib/udev/hwdb.d \
 > +	-Dudevrulesdir=/lib/udev/rules.d

No flag to disable tests?

Committed with the dependencies of thermald fixed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-06-28  6:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19 17:32 [Buildroot] [PATCH 1/1] package/upower: bump to version 0.99.19 Fabrice Fontaine
2022-06-28  6:04 ` Peter Korsgaard [this message]
2022-06-28  6:41   ` Fabrice Fontaine
2022-06-28 13:34     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7ydqq70.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=fontaine.fabrice@gmail.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.