From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8696C433F5 for ; Mon, 28 Feb 2022 15:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4jA56QvLIa4whJmUSDjTfUCs/aEeQNpH8V+D4rpaiXs=; b=jXnGtKGVWITSmt h0U9gSM16qgLCR+UaVEoMYcHELNheowQBjOMRVsZIe4dkTVvVtrSiQrNpsj8UFlE5X8bRQLKtTshp 3yt58fnMjRFwKi1OgU7O56hgeonEFm1LC++Nej8eKWAGXc8GEoZUl5WTpoRkCwK3JBmSPSdKteRvT ue8Yt+uPMx1MCksY9XQHUCSAZXuU7alKFi9hhczOqpwvvxqPz0Zn18CcDYhmOUMKJVoMfQkN14uV3 ahISYLVCIbd5i/kTXR/NjkTDdt5HXSg71LWxrhg6D7xCNiGDn7QcK9rM2hIDkYV2P5znDTfTLHvG2 NyTrs3rUDjI1djWpyQog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOi9H-00DBVm-Ao; Mon, 28 Feb 2022 15:41:19 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOi9C-00DBU5-4H for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 15:41:16 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C14271BF215; Mon, 28 Feb 2022 15:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646062869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8tsZThgKft3qP4HSBatGAgCaNYLDfrbq75zRz5W1SA=; b=kLvkovtrQ4QLgwOf4DxCC4CISYznEeyG1gMt4QPzLOB8QAgQqBN5nzSLTdu+iH4z6Hijwr E6TMLlNU4quO/5zrcje2BvmU9d1hcIc7eMEGq9ZH5e0QT2boAe1ribA5PZoaxDujlaHu9y O4kkYnB32k7xsZzsq0QOu3Km//48yu+t2wDlyv6+6DAnDYaL/Q4pRfUtIupupcd/B6AAK5 nGTqeyRMleiWKOXSb0cNgSXnzpIRhllYw5IB3Bp3vVdaWbeEaXAlQwiDY4H15YT/mBTBWf 0a73ifR65GcOVV48f3lBTuqfIwivNWV4vUxrtaNgiRt+gMu1Q2y2LqxvLwyqJQ== From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Marek =?utf-8?Q?Beh=C3=BAn?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: armada-37xx: Remap IO space to bus address 0x0 In-Reply-To: <20220218212526.16021-1-pali@kernel.org> References: <20220218212526.16021-1-pali@kernel.org> Date: Mon, 28 Feb 2022 16:41:06 +0100 Message-ID: <87o82r0zjh.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_074114_732576_0AD00ACD X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gUGFsaSwKCj4gUmVtYXAgUENJIEkvTyBzcGFjZSB0byB0aGUgYnVzIGFkZHJlc3MgMHgw IGluIHRoZSBBcm1hZGEgMzd4eAo+IGRldmljZS10cmVlIGluIG9yZGVyIHRvIHN1cHBvcnQgbGVn YWN5IEkvTyBwb3J0IGJhc2VkIGNhcmRzIHdoaWNoIGhhdmUKPiBoYXJkY29kZWQgSS9PIHBvcnRz IGluIGxvdyBhZGRyZXNzIHNwYWNlLgo+Cj4gU29tZSBsZWdhY3kgUENJIEkvTyBiYXNlZCBjYXJk cyBkbyBub3Qgc3VwcG9ydCAzMi1iaXQgSS9PIGFkZHJlc3NpbmcuCj4KPiBTaW5jZSBjb21taXQg NjRmMTYwZTE5ZTkyICgiUENJOiBhYXJkdmFyazogQ29uZmlndXJlIFBDSWUgcmVzb3VyY2VzIGZy b20KPiAncmFuZ2VzJyBEVCBwcm9wZXJ0eSIpIHRoaXMgZHJpdmVyIGNhbiB3b3JrIHdpdGggSS9P IHdpbmRvd3Mgd2hpY2gKPiBoYXZlCgpTaG91bGQgd2UgYWRkIGEgIkZpeGVzOiA2NGYxNjBlMTll OTIgKCJQQ0k6IGFhcmR2YXJrOiBDb25maWd1cmUgUENJZQpyZXNvdXJjZXMgZnJvbSAncmFuZ2Vz JyBEVCBwcm9wZXJ0eSIpIiB0YWcgPwoKR3JlZ29yeQoKPiBhIGRpZmZlcmVudCBhZGRyZXNzIGZv ciBDUFUgdGhhbiBmb3IgUENJIGJ1cyAodW5sZXNzIHRoZXJlIGlzIHNvbWUKPiBjb25mbGljdCB3 aXRoIG90aGVyIEEzN3h4IG1hcHBpbmcpLCB3aXRob3V0IG5lZWRpbmcgYWRkaXRpb25hbCBzdXBw b3J0Cj4gZm9yIHRoaXMgaW4gdGhlIGZpcm13YXJlLgo+Cj4gTm90ZSB0aGF0IEREUiBvbiBBMzd4 eCBpcyBtYXBwZWQgdG8gYnVzIGFkZHJlc3MgMHgwIGFuZCB0aGF0IG1hcHBpbmcgb2YKPiBJL08g c3BhY2UgY2FuIGJlIHNldCB0byBhZGRyZXNzIDB4MCB0b28gYmVjYXVzZSBNRU0gc3BhY2UgYW5k IEkvTyBzcGFjZQo+IGFyZSBzZXBhcmF0ZSBhbmQgc28gdGhleSBkbyBub3QgY29uZmxpY3QuCj4K PiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgo+IFJlcG9ydGVk LWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+IC0tLQo+ICBhcmNoL2FybTY0L2Jv b3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3MjAtdHVycmlzLW1veC5kdHMgfCAyICstCj4gIGFyY2gv YXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpICAgICAgICAgICB8IDIgKy0K PiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJp cy1tb3guZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJp cy1tb3guZHRzCj4gaW5kZXggNjU4MTA5MmMyYzkwLi43ZDFiOTE1M2E5MDEgMTAwNjQ0Cj4gLS0t IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1tb3guZHRz Cj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXR1cnJpcy1t b3guZHRzCj4gQEAgLTE2Myw3ICsxNjMsNyBAQAo+ICAJICovCj4gIAkjYWRkcmVzcy1jZWxscyA9 IDwzPjsKPiAgCSNzaXplLWNlbGxzID0gPDI+Owo+IC0JcmFuZ2VzID0gPDB4ODEwMDAwMDAgMCAw eGU4MDAwMDAwICAgMCAweGU4MDAwMDAwICAgMCAweDAxMDAwMDAwICAgLyogUG9ydCAwIElPICov Cj4gKwlyYW5nZXMgPSA8MHg4MTAwMDAwMCAwIDB4MDAwMDAwMDAgICAwIDB4ZTgwMDAwMDAgICAw IDB4MDEwMDAwMDAgICAvKiBQb3J0IDAgSU8gKi8KPiAgCQkgIDB4ODIwMDAwMDAgMCAweGU5MDAw MDAwICAgMCAweGU5MDAwMDAwICAgMCAweDA3MDAwMDAwPjsgLyogUG9ydCAwIE1FTSAqLwo+ICAK PiAgCS8qIGVuYWJsZWQgYnkgVS1Cb290IGlmIFBDSWUgbW9kdWxlIGlzIHByZXNlbnQgKi8KPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kg Yi9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaQo+IGluZGV4IDU0 OWMzZjdjNWIyNy4uYTA5OWI3Nzg3NDI5IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9k dHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9t YXJ2ZWxsL2FybWFkYS0zN3h4LmR0c2kKPiBAQCAtNTE1LDcgKzUxNSw3IEBACj4gIAkJCSAqICh0 b3RhbGluZyAxMjcgTWlCKSBmb3IgTUVNLgo+ICAJCQkgKi8KPiAgCQkJcmFuZ2VzID0gPDB4ODIw MDAwMDAgMCAweGU4MDAwMDAwICAgMCAweGU4MDAwMDAwICAgMCAweDA3ZjAwMDAwICAgLyogUG9y dCAwIE1FTSAqLwo+IC0JCQkJICAweDgxMDAwMDAwIDAgMHhlZmYwMDAwMCAgIDAgMHhlZmYwMDAw MCAgIDAgMHgwMDEwMDAwMD47IC8qIFBvcnQgMCBJTyovCj4gKwkJCQkgIDB4ODEwMDAwMDAgMCAw eDAwMDAwMDAwICAgMCAweGVmZjAwMDAwICAgMCAweDAwMTAwMDAwPjsgLyogUG9ydCAwIElPICov Cj4gIAkJCWludGVycnVwdC1tYXAtbWFzayA9IDwwIDAgMCA3PjsKPiAgCQkJaW50ZXJydXB0LW1h cCA9IDwwIDAgMCAxICZwY2llX2ludGMgMD4sCj4gIAkJCQkJPDAgMCAwIDIgJnBjaWVfaW50YyAx PiwKPiAtLSAKPiAyLjIwLjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpFbWJlZGRl ZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912D4C433F5 for ; Mon, 28 Feb 2022 15:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237611AbiB1Plz (ORCPT ); Mon, 28 Feb 2022 10:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237608AbiB1Ply (ORCPT ); Mon, 28 Feb 2022 10:41:54 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6994C7EB23 for ; Mon, 28 Feb 2022 07:41:13 -0800 (PST) Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C14271BF215; Mon, 28 Feb 2022 15:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646062869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8tsZThgKft3qP4HSBatGAgCaNYLDfrbq75zRz5W1SA=; b=kLvkovtrQ4QLgwOf4DxCC4CISYznEeyG1gMt4QPzLOB8QAgQqBN5nzSLTdu+iH4z6Hijwr E6TMLlNU4quO/5zrcje2BvmU9d1hcIc7eMEGq9ZH5e0QT2boAe1ribA5PZoaxDujlaHu9y O4kkYnB32k7xsZzsq0QOu3Km//48yu+t2wDlyv6+6DAnDYaL/Q4pRfUtIupupcd/B6AAK5 nGTqeyRMleiWKOXSb0cNgSXnzpIRhllYw5IB3Bp3vVdaWbeEaXAlQwiDY4H15YT/mBTBWf 0a73ifR65GcOVV48f3lBTuqfIwivNWV4vUxrtaNgiRt+gMu1Q2y2LqxvLwyqJQ== From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Marek =?utf-8?Q?Beh=C3=BAn?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: armada-37xx: Remap IO space to bus address 0x0 In-Reply-To: <20220218212526.16021-1-pali@kernel.org> References: <20220218212526.16021-1-pali@kernel.org> Date: Mon, 28 Feb 2022 16:41:06 +0100 Message-ID: <87o82r0zjh.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Pali, > Remap PCI I/O space to the bus address 0x0 in the Armada 37xx > device-tree in order to support legacy I/O port based cards which have > hardcoded I/O ports in low address space. > > Some legacy PCI I/O based cards do not support 32-bit I/O addressing. > > Since commit 64f160e19e92 ("PCI: aardvark: Configure PCIe resources from > 'ranges' DT property") this driver can work with I/O windows which > have Should we add a "Fixes: 64f160e19e92 ("PCI: aardvark: Configure PCIe resources from 'ranges' DT property")" tag ? Gregory > a different address for CPU than for PCI bus (unless there is some > conflict with other A37xx mapping), without needing additional support > for this in the firmware. > > Note that DDR on A37xx is mapped to bus address 0x0 and that mapping of > I/O space can be set to address 0x0 too because MEM space and I/O space > are separate and so they do not conflict. > > Signed-off-by: Pali Roh=C3=A1r > Reported-by: Arnd Bergmann > --- > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arc= h/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 6581092c2c90..7d1b9153a901 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -163,7 +163,7 @@ > */ > #address-cells =3D <3>; > #size-cells =3D <2>; > - ranges =3D <0x81000000 0 0xe8000000 0 0xe8000000 0 0x01000000 /* = Port 0 IO */ > + ranges =3D <0x81000000 0 0x00000000 0 0xe8000000 0 0x01000000 /* = Port 0 IO */ > 0x82000000 0 0xe9000000 0 0xe9000000 0 0x07000000>; /* Port 0 ME= M */ >=20=20 > /* enabled by U-Boot if PCIe module is present */ > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/bo= ot/dts/marvell/armada-37xx.dtsi > index 549c3f7c5b27..a099b7787429 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -515,7 +515,7 @@ > * (totaling 127 MiB) for MEM. > */ > ranges =3D <0x82000000 0 0xe8000000 0 0xe8000000 0 0x07f00000 /= * Port 0 MEM */ > - 0x81000000 0 0xeff00000 0 0xeff00000 0 0x00100000>; /* Port 0 = IO*/ > + 0x81000000 0 0x00000000 0 0xeff00000 0 0x00100000>; /* Port 0 = IO */ > interrupt-map-mask =3D <0 0 0 7>; > interrupt-map =3D <0 0 0 1 &pcie_intc 0>, > <0 0 0 2 &pcie_intc 1>, > --=20 > 2.20.1 > --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com