From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE
Date: Mon, 24 Jan 2022 14:33:52 +0200 [thread overview]
Message-ID: <87o8412tzj.fsf@intel.com> (raw)
In-Reply-To: <20220122004259.sgd6ewxg6oll7tgi@ldmartin-desk2>
On Fri, 21 Jan 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Fri, Jan 21, 2022 at 03:29:57PM +0200, Jani Nikula wrote:
>>In general, we should avoid redefining kernel macros like this. It can
>>get confusing, and what gets used will depend on whether the header is
>>included or not. Moreover, we should prefer drm_WARN_ON() and
>>drm_WARN_ON_ONCE() anyway, which include the stringified error condition
>>in the message.
>>
>>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-01-24 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 13:29 [Intel-gfx] [PATCH] drm/i915: nuke local versions of WARN_ON/WARN_ON_ONCE Jani Nikula
2022-01-21 14:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-01-21 15:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-21 19:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-01-22 0:42 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2022-01-24 12:33 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8412tzj.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.