From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9C26310E12B
 for <igt-dev@lists.freedesktop.org>; Mon, 24 Jan 2022 16:40:14 +0000 (UTC)
Date: Mon, 24 Jan 2022 08:29:45 -0800
Message-ID: <87o841p05i.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20220124023833.13535-1-chuansheng.liu@intel.com>
References: <20220124023833.13535-1-chuansheng.liu@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with
 right ctx id
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Sun, 23 Jan 2022 18:38:33 -0800, Chuansheng Liu wrote:
>
> This patch corrects the ctx id accordindly. Furthermore,
> there are other code places with similar mistakes, will
> try to send out the fixes further.

Yes we know about this issue. Maybe a single patch which fixes these
globally is preferred (to avoid having separate commit messages
etc.). Anyway for this:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> ---
>  tests/i915/gem_busy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index b4757736..b8a61084 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -517,7 +517,7 @@ igt_main
>		igt_hang_t hang;
>
>		igt_fixture {
> -			hang = igt_allow_hang(fd, 0, 0);
> +			hang = igt_allow_hang(fd, ctx->id, 0);
>		}
>
>		test_each_engine("hang", fd, ctx, e) {
> --
> 2.25.0.rc2