From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id C42A810F0CB for ; Thu, 6 Jan 2022 13:20:01 +0000 (UTC) Date: Thu, 06 Jan 2022 05:20:02 -0800 Message-ID: <87o84p9f25.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: References: <20220105064945.9640-1-zbigniew.kempczynski@intel.com> <20220105064945.9640-3-zbigniew.kempczynski@intel.com> <87sfu1a9f5.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t 2/3] tests/i915/gem_softpin: Add safe-start test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: On Thu, 06 Jan 2022 01:55:50 -0800, Zbigniew Kempczy=F1ski wrote: > > On Wed, Jan 05, 2022 at 06:24:14PM -0800, Dixit, Ashutosh wrote: > > On Tue, 04 Jan 2022 22:49:44 -0800, Zbigniew Kempczy=F1ski wrote: > > > > > > + offset1 =3D gem_detect_min_start_offset_for_region(i915, region1); > > > + offset2 =3D gem_detect_min_start_offset_for_region(i915, region2); > > > + alignment =3D gem_detect_safe_alignment(i915); > > > + igt_debug("safe alignment: %llx\n", (long long) alignment); > > > + igt_debug("safe start offset: %llx\n", > > > + (long long) gem_detect_safe_start_offset(i915)); > > > + igt_debug("minimum object1 start offset: %llx\n", (long long) offse= t1); > > > + igt_debug("minimum object2 start offset: %llx\n", (long long) offse= t2); > > > > Maybe also add print for the min_alignment value here? > > You want to print minimum alignment for same region? Yes, just the min alignment for the pair or regions above. Otherwise please go ahead and merge. The series is: Reviewed-by: Ashutosh Dixit