From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9421C433F5 for ; Wed, 22 Sep 2021 15:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81DB8610A1 for ; Wed, 22 Sep 2021 15:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236304AbhIVPRz convert rfc822-to-8bit (ORCPT ); Wed, 22 Sep 2021 11:17:55 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56421 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233737AbhIVPRy (ORCPT ); Wed, 22 Sep 2021 11:17:54 -0400 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B80F9E0006; Wed, 22 Sep 2021 15:16:22 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it In-Reply-To: <20210922105433.11744-6-pali@kernel.org> References: <20210922105433.11744-1-pali@kernel.org> <20210922105433.11744-6-pali@kernel.org> Date: Wed, 22 Sep 2021 17:16:22 +0200 Message-ID: <87o88k63p5.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello Pali, > This change defines DT node for UART clock "marvell,armada-3700-uart-clock" > and use this UART clock as a base clock for all UART devices. Sorry to not have pointed this earlier but I found something a little unusual, see below: > > Signed-off-by: Pali Rohár > --- > arch/arm64/boot/dts/marvell/armada-3720-db.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin.dtsi | 4 ++++ > .../boot/dts/marvell/armada-3720-turris-mox.dts | 4 ++++ > arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 4 ++++ > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 15 +++++++++++++-- > 5 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > index 3e5789f37206..accf014a6a1e 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts > @@ -191,6 +191,10 @@ > }; > }; > > +&uartclk { > + status = "okay"; I found unusual to have to enable the clock at device tree level. Usually the clock driver is always loaded and then the clock is really enabled or disabled through the clock framework. [...] > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index 9acc5d2b5a00..5bc61c9615f5 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -132,10 +132,21 @@ > reg = <0x11500 0x40>; > }; > > + uartclk: uartclk@12000 { > + compatible = "marvell,armada-3700-uart-clock"; > + reg = <0x12010 0x4>, <0x12210 0x4>; > + clocks = <&tbg 0>, <&tbg 1>, <&tbg 2>, > + <&tbg 3>, <&xtalclk>; > + clock-names = "TBG-A-P", "TBG-B-P", "TBG-A-S", > + "TBG-B-S", "xtal"; > + #clock-cells = <1>; I think you could remove the following line and thanks to this there won't be any change in the dts of the board: > + status = "disabled"; > + }; > + Gregory > uart0: serial@12000 { > compatible = "marvell,armada-3700-uart"; > reg = <0x12000 0x18>; > - clocks = <&xtalclk>; > + clocks = <&uartclk 0>; > interrupts = > , > , > @@ -147,7 +158,7 @@ > uart1: serial@12200 { > compatible = "marvell,armada-3700-uart-ext"; > reg = <0x12200 0x30>; > - clocks = <&xtalclk>; > + clocks = <&uartclk 1>; > interrupts = > , > ; > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B085C433EF for ; Wed, 22 Sep 2021 15:18:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61A9A611C6 for ; Wed, 22 Sep 2021 15:18:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 61A9A611C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bXh0ZUcnnYb02yT35tzQ4mu4omtnQcZ6JDjEP+87y/8=; b=XRbpOJdgGaRAaJ aOjniI4wRpLj7kfYRxuex4BFRl9fD6lUxEPhl0JULIub9hAPwJ61YWK0NOxHyOXO8rn4mtgz+pql+ hUVD0Vhdx3WJ2y/pZFnS6/lr7pvCWLUs37VelSi8oaBszUw06Jk85RopPeEWl39kWZ4rudV4mQ4iM soIgT8A1uYebrOTgasKMG5ho0KNdNVpHtZjQBdzbtIudgLOhpBS8QQ5hODlM0Q4flkRBWkZ01jAec ZuHplxY+TaGO4G71gi7Ied72aeHhbluw1eG8OQSNmtbHcYgmMjyjK/m+0l4bZGs38+DrfiPiioHdA P3tFeyqZqOlKMwUmj9mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT3z5-008v5E-ES; Wed, 22 Sep 2021 15:16:31 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT3z1-008v4V-Ry for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 15:16:30 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B80F9E0006; Wed, 22 Sep 2021 15:16:22 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Sebastian Hesselbarth , Vladimir Vid , Marek =?utf-8?Q?Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it In-Reply-To: <20210922105433.11744-6-pali@kernel.org> References: <20210922105433.11744-1-pali@kernel.org> <20210922105433.11744-6-pali@kernel.org> Date: Wed, 22 Sep 2021 17:16:22 +0200 Message-ID: <87o88k63p5.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_081628_085562_26019D8C X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gUGFsaSwKCj4gVGhpcyBjaGFuZ2UgZGVmaW5lcyBEVCBub2RlIGZvciBVQVJUIGNsb2Nr ICJtYXJ2ZWxsLGFybWFkYS0zNzAwLXVhcnQtY2xvY2siCj4gYW5kIHVzZSB0aGlzIFVBUlQgY2xv Y2sgYXMgYSBiYXNlIGNsb2NrIGZvciBhbGwgVUFSVCBkZXZpY2VzLgoKU29ycnkgdG8gbm90IGhh dmUgcG9pbnRlZCB0aGlzIGVhcmxpZXIgYnV0IEkgZm91bmQgc29tZXRoaW5nIGEgbGl0dGxlCnVu dXN1YWwsIHNlZSBiZWxvdzoKCj4KPiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFsaUBr ZXJuZWwub3JnPgo+IC0tLQo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3 MjAtZGIuZHRzICAgIHwgIDQgKysrKwo+ICAuLi4vYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcy MC1lc3ByZXNzb2Jpbi5kdHNpIHwgIDQgKysrKwo+ICAuLi4vYm9vdC9kdHMvbWFydmVsbC9hcm1h ZGEtMzcyMC10dXJyaXMtbW94LmR0cyAgIHwgIDQgKysrKwo+ICBhcmNoL2FybTY0L2Jvb3QvZHRz L21hcnZlbGwvYXJtYWRhLTM3MjAtdURQVS5kdHMgIHwgIDQgKysrKwo+ICBhcmNoL2FybTY0L2Jv b3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaSAgICAgIHwgMTUgKysrKysrKysrKysrKy0t Cj4gIDUgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3MjAtZGIu ZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLWRiLmR0cwo+IGlu ZGV4IDNlNTc4OWYzNzIwNi4uYWNjZjAxNGE2YTFlIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQv Ym9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC1kYi5kdHMKPiArKysgYi9hcmNoL2FybTY0L2Jv b3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3MjAtZGIuZHRzCj4gQEAgLTE5MSw2ICsxOTEsMTAgQEAK PiAgCX07Cj4gIH07Cj4gIAo+ICsmdWFydGNsayB7Cj4gKwlzdGF0dXMgPSAib2theSI7CgpJIGZv dW5kIHVudXN1YWwgdG8gaGF2ZSB0byBlbmFibGUgdGhlIGNsb2NrIGF0IGRldmljZSB0cmVlIGxl dmVsLgpVc3VhbGx5IHRoZSBjbG9jayBkcml2ZXIgaXMgYWx3YXlzIGxvYWRlZCBhbmQgdGhlbiB0 aGUgY2xvY2sgaXMgcmVhbGx5CmVuYWJsZWQgb3IgZGlzYWJsZWQgdGhyb3VnaCB0aGUgY2xvY2sg ZnJhbWV3b3JrLgoKWy4uLl0KCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFy dmVsbC9hcm1hZGEtMzd4eC5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFk YS0zN3h4LmR0c2kKPiBpbmRleCA5YWNjNWQyYjVhMDAuLjViYzYxYzk2MTVmNSAxMDA2NDQKPiAt LS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaQo+ICsrKyBi L2FyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzd4eC5kdHNpCj4gQEAgLTEzMiwx MCArMTMyLDIxIEBACj4gIAkJCQlyZWcgPSA8MHgxMTUwMCAweDQwPjsKPiAgCQkJfTsKPiAgCj4g KwkJCXVhcnRjbGs6IHVhcnRjbGtAMTIwMDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxs LGFybWFkYS0zNzAwLXVhcnQtY2xvY2siOwo+ICsJCQkJcmVnID0gPDB4MTIwMTAgMHg0PiwgPDB4 MTIyMTAgMHg0PjsKPiArCQkJCWNsb2NrcyA9IDwmdGJnIDA+LCA8JnRiZyAxPiwgPCZ0YmcgMj4s Cj4gKwkJCQkJPCZ0YmcgMz4sIDwmeHRhbGNsaz47Cj4gKwkJCQljbG9jay1uYW1lcyA9ICJUQkct QS1QIiwgIlRCRy1CLVAiLCAiVEJHLUEtUyIsCj4gKwkJCQkJIlRCRy1CLVMiLCAieHRhbCI7Cj4g KwkJCQkjY2xvY2stY2VsbHMgPSA8MT47CgpJIHRoaW5rIHlvdSBjb3VsZCByZW1vdmUgdGhlIGZv bGxvd2luZyBsaW5lIGFuZCB0aGFua3MgdG8gdGhpcyB0aGVyZQp3b24ndCBiZSBhbnkgY2hhbmdl IGluIHRoZSBkdHMgb2YgdGhlIGJvYXJkOgo+ICsJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiAr CQkJfTsKPiArCgpHcmVnb3J5CgoKPiAgCQkJdWFydDA6IHNlcmlhbEAxMjAwMCB7Cj4gIAkJCQlj b21wYXRpYmxlID0gIm1hcnZlbGwsYXJtYWRhLTM3MDAtdWFydCI7Cj4gIAkJCQlyZWcgPSA8MHgx MjAwMCAweDE4PjsKPiAtCQkJCWNsb2NrcyA9IDwmeHRhbGNsaz47Cj4gKwkJCQljbG9ja3MgPSA8 JnVhcnRjbGsgMD47Cj4gIAkJCQlpbnRlcnJ1cHRzID0KPiAgCQkJCTxHSUNfU1BJIDExIElSUV9U WVBFX0xFVkVMX0hJR0g+LAo+ICAJCQkJPEdJQ19TUEkgMTIgSVJRX1RZUEVfTEVWRUxfSElHSD4s Cj4gQEAgLTE0Nyw3ICsxNTgsNyBAQAo+ICAJCQl1YXJ0MTogc2VyaWFsQDEyMjAwIHsKPiAgCQkJ CWNvbXBhdGlibGUgPSAibWFydmVsbCxhcm1hZGEtMzcwMC11YXJ0LWV4dCI7Cj4gIAkJCQlyZWcg PSA8MHgxMjIwMCAweDMwPjsKPiAtCQkJCWNsb2NrcyA9IDwmeHRhbGNsaz47Cj4gKwkJCQljbG9j a3MgPSA8JnVhcnRjbGsgMT47Cj4gIAkJCQlpbnRlcnJ1cHRzID0KPiAgCQkJCTxHSUNfU1BJIDMw IElSUV9UWVBFX0VER0VfUklTSU5HPiwKPiAgCQkJCTxHSUNfU1BJIDMxIElSUV9UWVBFX0VER0Vf UklTSU5HPjsKPiAtLSAKPiAyLjIwLjEKPgoKLS0gCkdyZWdvcnkgQ2xlbWVudCwgQm9vdGxpbgpF bWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHA6Ly9ib290bGluLmNvbQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=