From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D977C4338F for ; Tue, 24 Aug 2021 07:55:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D85D56127B for ; Tue, 24 Aug 2021 07:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D85D56127B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIRHC-0002Ip-KZ for qemu-devel@archiver.kernel.org; Tue, 24 Aug 2021 03:55:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIRGW-0001Ma-9w for qemu-devel@nongnu.org; Tue, 24 Aug 2021 03:54:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIRFM-0006x6-2l for qemu-devel@nongnu.org; Tue, 24 Aug 2021 03:54:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629791602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7n8PzS6+2XZC5KrO8XsLKKkwXKhWd79WFspJr36T6Eo=; b=esA1WwlCYRCNUrvD8v0PlYpJYxau4tfzQ3n1WqnOvjBqH/KSOSmUptsb1UdPJ14M4FvRuq EtELKVo/eZKnip/wIiEmUoI2ofAonnXLlEjiniBl5CG8wpMl45vGKYgkxzD3Uzx+GmWrqH IFjH3nVX+L3nj0r7av9KauuS5wUrkHc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-lbwBmLzbMU2A510WcJrT6g-1; Tue, 24 Aug 2021 03:53:20 -0400 X-MC-Unique: lbwBmLzbMU2A510WcJrT6g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC25D94EE5; Tue, 24 Aug 2021 07:53:19 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9324B5C1A3; Tue, 24 Aug 2021 07:53:19 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 29CF211380A9; Tue, 24 Aug 2021 09:53:18 +0200 (CEST) From: Markus Armbruster To: Jean-Philippe Brucker Subject: Re: [PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu References: <20210811085842.2511545-1-jean-philippe@linaro.org> Date: Tue, 24 Aug 2021 09:53:18 +0200 In-Reply-To: <20210811085842.2511545-1-jean-philippe@linaro.org> (Jean-Philippe Brucker's message of "Wed, 11 Aug 2021 10:58:42 +0200") Message-ID: <87o89nnus1.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Did this series fall through the cracks for 6.1? Jean-Philippe Brucker writes: > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine > parameter definitions cannot use underscores, because keyval_dashify() > transforms them to dashes and the parser doesn't find the parameter. > > This affects option default_bus_bypass_iommu which was introduced in the > same release: > > $ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on > qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found > > Rename the parameter to "default-bus-bypass-iommu". Passing > "default_bus_bypass_iommu" is still valid since the underscore are > transformed automatically. > > Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option") > Signed-off-by: Jean-Philippe Brucker > --- > hw/arm/virt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index b4598d3fe6..7075cdc15e 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -2671,10 +2671,10 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) > "Set the IOMMU type. " > "Valid values are none and smmuv3"); > > - object_class_property_add_bool(oc, "default_bus_bypass_iommu", > + object_class_property_add_bool(oc, "default-bus-bypass-iommu", > virt_get_default_bus_bypass_iommu, > virt_set_default_bus_bypass_iommu); > - object_class_property_set_description(oc, "default_bus_bypass_iommu", > + object_class_property_set_description(oc, "default-bus-bypass-iommu", > "Set on/off to enable/disable " > "bypass_iommu for default root bus");