From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE99C432BE for ; Fri, 20 Aug 2021 13:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2D91610E6 for ; Fri, 20 Aug 2021 13:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240749AbhHTNMz convert rfc822-to-8bit (ORCPT ); Fri, 20 Aug 2021 09:12:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240739AbhHTNMy (ORCPT ); Fri, 20 Aug 2021 09:12:54 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDE7560F91; Fri, 20 Aug 2021 13:12:15 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH4Jh-006C42-Qa; Fri, 20 Aug 2021 14:12:13 +0100 Date: Fri, 20 Aug 2021 14:12:13 +0100 Message-ID: <87o89sqmz6.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Chester Lin , Rob Herring , s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , Li Yang , Fabio Estevam , Matteo Lisi , Frieder Schrempf , Tim Harvey , Jagan Teki , catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger , "Ivan T . Ivanov" , "Lee, Chun-Yi" Subject: Re: [PATCH 4/8] arm64: dts: add NXP S32G2 support In-Reply-To: References: <20210805065429.27485-1-clin@suse.com> <20210805065429.27485-5-clin@suse.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: afaerber@suse.de, clin@suse.com, robh+dt@kernel.org, s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, shawnguo@kernel.org, krzk@kernel.org, linux@rempel-privat.de, s.riedmueller@phytec.de, matthias.schiffer@ew.tq-group.com, leoyang.li@nxp.com, festevam@gmail.com, matteo.lisi@engicam.com, frieder.schrempf@kontron.de, tharvey@gateworks.com, jagan@amarulasolutions.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, matthias.bgg@gmail.com, iivanov@suse.de, jlee@suse.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, 12 Aug 2021 18:26:28 +0100, Andreas Färber wrote: > > Hi Chester et al., > > On 05.08.21 08:54, Chester Lin wrote: > > Add an initial dtsi file for generic SoC features of NXP S32G2. > > > > Signed-off-by: Chester Lin > > --- > > arch/arm64/boot/dts/freescale/s32g2.dtsi | 98 ++++++++++++++++++++++++ > > 1 file changed, 98 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/s32g2.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > > new file mode 100644 > > index 000000000000..3321819c1a2d > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi [...] > > + gic: interrupt-controller@50800000 { > > + compatible = "arm,gic-v3"; > > + #interrupt-cells = <3>; > > + interrupt-controller; > > + reg = <0 0x50800000 0 0x10000>, > > + <0 0x50880000 0 0x200000>, That's enough redistributor space for 16 CPUs. However, you only describe 4. Either the number of CPUs is wrong, the size is wrong, or the GIC has been configured for more cores than the SoC has. > > + <0 0x50400000 0 0x2000>, > > + <0 0x50410000 0 0x2000>, > > + <0 0x50420000 0 0x2000>; > > Please order reg after compatible by convention, and sort > interrupt-controller or at least #interrupt-cells (applying to > consumers) last, after the below one applying to this device itself. > > > + interrupts = > + IRQ_TYPE_LEVEL_HIGH)>; > > + }; > > CC'ing Marc for additional GIC scrutiny, often the sizes are wrong. There is more than just sizes. The interrupt specifier for the maintenance interrupt is also wrong. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD79C4338F for ; Fri, 20 Aug 2021 13:14:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16C11610D2 for ; Fri, 20 Aug 2021 13:14:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 16C11610D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SLeIBNzBxaWF51FtaVCqR9Olsw9f06uGxIUn3c8FbcQ=; b=jCFAovgaAoMrbZ F+GbPoEw5SfagVHR62fdMT8U0DXZJ+6zwqTT7d9uTBF4aPzEPSjpdCkkoe/2ZtnUM1r6vosQX/Yg5 C+wE3b+8OFCgUelYnVIzGVruEAfe3VaPQoyFoqg0Wjd/4rOJMF8BSVrlnAUBWyyTs/vHpznrFYng0 ++uMAQ8qwWM/YVrQ8GAoRINsCy2D9lxkv43fbO3m964SapkNu09oFMDvxBgluTANo9rwSA+lR5/Rj 5kkPX8M9PUJQ4mUIHYCTDhZaBJUgelUmY5xRtk3cll6bQZ3pfNnvgPSHQq60kZzaspERlXqhSNl1M mX+/a5uQZvkQZUE3Sbig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH4Jo-00BF8G-3v; Fri, 20 Aug 2021 13:12:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH4Jk-00BF7W-2N for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 13:12:17 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDE7560F91; Fri, 20 Aug 2021 13:12:15 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mH4Jh-006C42-Qa; Fri, 20 Aug 2021 14:12:13 +0100 Date: Fri, 20 Aug 2021 14:12:13 +0100 Message-ID: <87o89sqmz6.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: Chester Lin , Rob Herring , s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , Li Yang , Fabio Estevam , Matteo Lisi , Frieder Schrempf , Tim Harvey , Jagan Teki , catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger , "Ivan T . Ivanov" , "Lee, Chun-Yi" Subject: Re: [PATCH 4/8] arm64: dts: add NXP S32G2 support In-Reply-To: References: <20210805065429.27485-1-clin@suse.com> <20210805065429.27485-5-clin@suse.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: afaerber@suse.de, clin@suse.com, robh+dt@kernel.org, s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, shawnguo@kernel.org, krzk@kernel.org, linux@rempel-privat.de, s.riedmueller@phytec.de, matthias.schiffer@ew.tq-group.com, leoyang.li@nxp.com, festevam@gmail.com, matteo.lisi@engicam.com, frieder.schrempf@kontron.de, tharvey@gateworks.com, jagan@amarulasolutions.com, catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, matthias.bgg@gmail.com, iivanov@suse.de, jlee@suse.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_061216_198885_0ECBA330 X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMiBBdWcgMjAyMSAxODoyNjoyOCArMDEwMCwKQW5kcmVhcyBGw6RyYmVyIDxhZmFl cmJlckBzdXNlLmRlPiB3cm90ZToKPiAKPiBIaSBDaGVzdGVyIGV0IGFsLiwKPiAKPiBPbiAwNS4w OC4yMSAwODo1NCwgQ2hlc3RlciBMaW4gd3JvdGU6Cj4gPiBBZGQgYW4gaW5pdGlhbCBkdHNpIGZp bGUgZm9yIGdlbmVyaWMgU29DIGZlYXR1cmVzIG9mIE5YUCBTMzJHMi4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogQ2hlc3RlciBMaW4gPGNsaW5Ac3VzZS5jb20+Cj4gPiAtLS0KPiA+ICBhcmNoL2Fy bTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9zMzJnMi5kdHNpIHwgOTggKysrKysrKysrKysrKysrKysr KysrKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDk4IGluc2VydGlvbnMoKykKPiA+ICBjcmVhdGUg bW9kZSAxMDA2NDQgYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvczMyZzIuZHRzaQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvczMyZzIuZHRz aSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL3MzMmcyLmR0c2kKPiA+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLjMzMjE4MTljMWEyZAo+ID4gLS0t IC9kZXYvbnVsbAo+ID4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUvczMyZzIu ZHRzaQoKWy4uLl0KCj4gPiArCQlnaWM6IGludGVycnVwdC1jb250cm9sbGVyQDUwODAwMDAwIHsK PiA+ICsJCQljb21wYXRpYmxlID0gImFybSxnaWMtdjMiOwo+ID4gKwkJCSNpbnRlcnJ1cHQtY2Vs bHMgPSA8Mz47Cj4gPiArCQkJaW50ZXJydXB0LWNvbnRyb2xsZXI7Cj4gPiArCQkJcmVnID0gPDAg MHg1MDgwMDAwMCAwIDB4MTAwMDA+LAo+ID4gKwkJCSAgICAgIDwwIDB4NTA4ODAwMDAgMCAweDIw MDAwMD4sCgpUaGF0J3MgZW5vdWdoIHJlZGlzdHJpYnV0b3Igc3BhY2UgZm9yIDE2IENQVXMuIEhv d2V2ZXIsIHlvdSBvbmx5CmRlc2NyaWJlIDQuIEVpdGhlciB0aGUgbnVtYmVyIG9mIENQVXMgaXMg d3JvbmcsIHRoZSBzaXplIGlzIHdyb25nLCBvcgp0aGUgR0lDIGhhcyBiZWVuIGNvbmZpZ3VyZWQg Zm9yIG1vcmUgY29yZXMgdGhhbiB0aGUgU29DIGhhcy4KCj4gPiArCQkJICAgICAgPDAgMHg1MDQw MDAwMCAwIDB4MjAwMD4sCj4gPiArCQkJICAgICAgPDAgMHg1MDQxMDAwMCAwIDB4MjAwMD4sCj4g PiArCQkJICAgICAgPDAgMHg1MDQyMDAwMCAwIDB4MjAwMD47Cj4gCj4gUGxlYXNlIG9yZGVyIHJl ZyBhZnRlciBjb21wYXRpYmxlIGJ5IGNvbnZlbnRpb24sIGFuZCBzb3J0Cj4gaW50ZXJydXB0LWNv bnRyb2xsZXIgb3IgYXQgbGVhc3QgI2ludGVycnVwdC1jZWxscyAoYXBwbHlpbmcgdG8KPiBjb25z dW1lcnMpIGxhc3QsIGFmdGVyIHRoZSBiZWxvdyBvbmUgYXBwbHlpbmcgdG8gdGhpcyBkZXZpY2Ug aXRzZWxmLgo+IAo+ID4gKwkJCWludGVycnVwdHMgPSA8R0lDX1BQSSA5IChHSUNfQ1BVX01BU0tf U0lNUExFKDQpIHwKPiA+ICsJCQkJCQkgSVJRX1RZUEVfTEVWRUxfSElHSCk+Owo+ID4gKwkJfTsK PiAKPiBDQydpbmcgTWFyYyBmb3IgYWRkaXRpb25hbCBHSUMgc2NydXRpbnksIG9mdGVuIHRoZSBz aXplcyBhcmUgd3JvbmcuCgpUaGVyZSBpcyBtb3JlIHRoYW4ganVzdCBzaXplcy4gVGhlIGludGVy cnVwdCBzcGVjaWZpZXIgZm9yIHRoZQptYWludGVuYW5jZSBpbnRlcnJ1cHQgaXMgYWxzbyB3cm9u Zy4KCglNLgoKLS0gCldpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlz IG5vdCBwb3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK