From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: imammedo@redhat.com, alex.williamson@redhat.com,
eblake@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties
Date: Thu, 22 Jul 2021 15:25:53 +0200 [thread overview]
Message-ID: <87o8auh44e.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210719104033.185109-1-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 19 Jul 2021 12:40:31 +0200")
Since patch submitters tend to submit code that works for the success
case, I like to test a few failure cases before anything else. Gotcha:
$ qemu-system-x86_64 -machine pc,pflash0=xxx qemu-system-x86_64:
Property 'cfi.pflash01.drive' can't find value 'xxx'
The error message is misleading.
This is not a "must not commit" issue. Fixing a regression in time for
the release at the price of a bad error message is still a win. The bad
error message needs fixing all the same, just not necessarily before the
release.
Since mere thinking doesn't rock the release boat: any ideas on how this
could be fixed?
next prev parent reply other threads:[~2021-07-22 13:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 10:40 [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 10:40 ` [PATCH 1/2] qapi: introduce forwarding visitor Paolo Bonzini
2021-07-20 0:54 ` Eric Blake
2021-07-22 14:02 ` Markus Armbruster
2021-07-22 15:08 ` Paolo Bonzini
2021-07-22 15:34 ` Markus Armbruster
2021-07-23 9:49 ` Paolo Bonzini
2021-07-19 10:40 ` [PATCH 2/2] qom: use correct field name when getting/setting alias properties Paolo Bonzini
2021-07-19 11:51 ` Philippe Mathieu-Daudé
2021-07-20 1:00 ` Eric Blake
2021-07-21 9:51 ` Paolo Bonzini
2021-07-21 14:43 ` Markus Armbruster
2021-07-20 15:54 ` [PATCH 0/2] qapi/qom: " Markus Armbruster
2021-07-21 11:50 ` Paolo Bonzini
2021-07-22 13:25 ` Markus Armbruster [this message]
2021-07-22 13:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8auh44e.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.