From: John Ogness <john.ogness@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v3 6/6] printk: syslog: close window between wait and read
Date: Fri, 25 Jun 2021 16:20:09 +0206 [thread overview]
Message-ID: <87o8but4jy.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20210625093354.12384711@oasis.local.home>
On 2021-06-25, Steven Rostedt <rostedt@goodmis.org> wrote:
>> + * @syslog_lock is held when entering the read loop to prevent
>> + * another reader from modifying @syslog_seq.
>
> You should add to the above comment:
>
> * And the @syslog_lock is released before exiting the loop.
>
> Because it's not normal to enter a loop locked, and have it unlocked
> when exiting the loop. And I can envision in the future, someone might
> add a break (for error) while still holding the lock.
Agreed. Thanks.
John
next prev parent reply other threads:[~2021-06-25 14:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 11:11 [PATCH printk v3 0/6] printk: remove safe buffers John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 11:11 ` [PATCH printk v3 1/6] lib/nmi_backtrace: explicitly serialize banner and regs John Ogness
2021-06-24 12:26 ` Petr Mladek
2021-06-24 11:11 ` [PATCH printk v3 2/6] printk: track/limit recursion John Ogness
2021-06-24 12:55 ` Petr Mladek
2021-06-24 11:11 ` [PATCH printk v3 3/6] printk: remove safe buffers John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 14:49 ` Petr Mladek
2021-06-24 14:49 ` Petr Mladek
2021-06-24 14:49 ` Petr Mladek
2021-06-24 15:35 ` John Ogness
2021-06-24 15:35 ` John Ogness
2021-06-24 15:35 ` John Ogness
2021-06-25 12:41 ` Petr Mladek
2021-06-25 12:41 ` Petr Mladek
2021-06-25 12:41 ` Petr Mladek
2021-06-24 11:11 ` [PATCH printk v3 4/6] printk: remove NMI tracking John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-24 11:11 ` John Ogness
2021-06-25 12:36 ` Petr Mladek
2021-06-25 12:36 ` Petr Mladek
2021-06-25 12:36 ` Petr Mladek
2021-06-25 13:34 ` Russell King (Oracle)
2021-06-25 13:34 ` Russell King (Oracle)
2021-06-25 13:34 ` Russell King (Oracle)
2021-06-24 11:11 ` [PATCH printk v3 5/6] printk: convert @syslog_lock to mutex John Ogness
2021-06-24 11:11 ` [PATCH printk v3 6/6] printk: syslog: close window between wait and read John Ogness
2021-06-24 14:57 ` Petr Mladek
2021-06-24 15:25 ` Petr Mladek
2021-06-25 8:11 ` John Ogness
2021-06-25 14:55 ` Petr Mladek
2021-06-25 13:33 ` Steven Rostedt
2021-06-25 14:14 ` John Ogness [this message]
2021-06-28 14:35 ` Petr Mladek
2021-06-28 14:52 ` Steven Rostedt
2021-06-28 15:00 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8but4jy.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.