From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5A3C48BDF for ; Tue, 15 Jun 2021 09:48:44 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5CBD36143E for ; Tue, 15 Jun 2021 09:48:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CBD36143E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F10374A418; Tue, 15 Jun 2021 05:48:43 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1pOWBMTV4BzN; Tue, 15 Jun 2021 05:48:39 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BC1744B0B1; Tue, 15 Jun 2021 05:48:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BA10C4A418 for ; Tue, 15 Jun 2021 05:48:38 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3ZMgy1jKt9av for ; Tue, 15 Jun 2021 05:48:34 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9A9174A3A3 for ; Tue, 15 Jun 2021 05:48:34 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A8906143E; Tue, 15 Jun 2021 09:48:32 +0000 (UTC) Received: from [185.219.108.64] (helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lt5gL-007eHZ-0u; Tue, 15 Jun 2021 10:48:29 +0100 Date: Tue, 15 Jun 2021 10:48:28 +0100 Message-ID: <87o8c7ihlf.wl-maz@kernel.org> From: Marc Zyngier To: Yanan Wang Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files In-Reply-To: <20210615035019.35808-1-wangyanan55@huawei.com> References: <20210615035019.35808-1-wangyanan55@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, james.morse@arm.com, alexandru.elisei@arm.com, eric.auger@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, yuzenghui@huawei.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Will Deacon , Catalin Marinas , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, 15 Jun 2021 04:50:19 +0100, Yanan Wang wrote: > > These fixes introduce no functional change but just adjustment about > coding style issues for ARM64 vgic code. They mainly include identation > fix of function parameters/arguments, identation fix of structure > initialization, identation fix of comment, also the deletion of some > superfluous space lines. Please don't. This sort of patches bring little value, and make the backporting of important fixes more difficult because of pointless context change. Fixing these cosmetic details is fine when you are modifying the code. But as a standalone patch, this brings more pain than benefit. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214AEC48BE5 for ; Tue, 15 Jun 2021 19:33:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E10C561350 for ; Tue, 15 Jun 2021 19:33:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E10C561350 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yMHjRUf6Ok7/vLVdTBvFPbXl5Or+M46rDC2ae71ZAa8=; b=vQXdas8VpBRmu0 iUTOyAxIRfxh8c8IBvnuLMJd7luCSC5CvKz6ihklZB6+T57X5izMHKSp6TnYzO7Jjl7HSqiek3Amb +605JgoiGgZM6rSumY0U9BG8iyWlh+LjP3JkG2X3F5YwhC9xCALLPbLFxjiCY4RZpSrRNPhq/rh0U zGlRVK+d18Vo52eXM7erRfP3OzQnRfA2M/8ltrbgoJibCwKVbpfFtEpGvqpEFtOpbv5wDcBi9d8hl 8LVrkklP4zQLaBskTvU3PBNoWPnPdOEch/pgIlz+v3f3x6LcLbqOCBtalvX1ZnAVU6TCH0bmM7KDY Azo/dpHw5pupeP19rdsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEm6-002SDl-D5; Tue, 15 Jun 2021 19:31:03 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9HI-000DDm-0k for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:38:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CsH3m91phr5Qg1jO74arYQEewQpw9GPHy7HBIIx3NCc=; b=NhqSOi1DeuIRLzbHrhDZg49J4k mRMkxibbnYFRX4PVbqedGwFSysN8uJ4Jt6DfwqRp9pJM0bbG2RRHkkduwfzXKaok1IudhTUnRBY8z P0QXHisYXyTdsQNOz8iwCCiRNP/N0bXmDufcFeWR71Zgj7cKG0w9mHvnqTZ3P1WxHwqnHgNPm6+AE hfaj1t4m8GS4EqPapBe8R/pk60KWLWgmeSZba1oAV8jz2I0lM+su/nRwdZq/WQ5eRb8eg5RShnZYK 7UzXmZMkgd1w4bAHB4P05lyLp5ISvw/kHY89GvSrJewwk4zJ41KRqvEa0sgWCw7WvIP1GGHHjTA2/ 7siydy8Q==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt5gK-007gGg-9K for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 09:48:36 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A8906143E; Tue, 15 Jun 2021 09:48:32 +0000 (UTC) Received: from [185.219.108.64] (helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lt5gL-007eHZ-0u; Tue, 15 Jun 2021 10:48:29 +0100 Date: Tue, 15 Jun 2021 10:48:28 +0100 Message-ID: <87o8c7ihlf.wl-maz@kernel.org> From: Marc Zyngier To: Yanan Wang Cc: James Morse , Alexandru Elisei , Eric Auger , Catalin Marinas , Will Deacon , , , , , Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files In-Reply-To: <20210615035019.35808-1-wangyanan55@huawei.com> References: <20210615035019.35808-1-wangyanan55@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, james.morse@arm.com, alexandru.elisei@arm.com, eric.auger@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, yuzenghui@huawei.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_104835_324000_7C5449AF X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Jun 2021 04:50:19 +0100, Yanan Wang wrote: > > These fixes introduce no functional change but just adjustment about > coding style issues for ARM64 vgic code. They mainly include identation > fix of function parameters/arguments, identation fix of structure > initialization, identation fix of comment, also the deletion of some > superfluous space lines. Please don't. This sort of patches bring little value, and make the backporting of important fixes more difficult because of pointless context change. Fixing these cosmetic details is fine when you are modifying the code. But as a standalone patch, this brings more pain than benefit. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D5FC48BE8 for ; Tue, 15 Jun 2021 09:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46F6E61446 for ; Tue, 15 Jun 2021 09:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231458AbhFOJui (ORCPT ); Tue, 15 Jun 2021 05:50:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:58918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbhFOJug (ORCPT ); Tue, 15 Jun 2021 05:50:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A8906143E; Tue, 15 Jun 2021 09:48:32 +0000 (UTC) Received: from [185.219.108.64] (helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lt5gL-007eHZ-0u; Tue, 15 Jun 2021 10:48:29 +0100 Date: Tue, 15 Jun 2021 10:48:28 +0100 Message-ID: <87o8c7ihlf.wl-maz@kernel.org> From: Marc Zyngier To: Yanan Wang Cc: James Morse , Alexandru Elisei , Eric Auger , Catalin Marinas , Will Deacon , , , , , Subject: Re: [PATCH] KVM: arm64: Trival coding style fixes for all vgic-related files In-Reply-To: <20210615035019.35808-1-wangyanan55@huawei.com> References: <20210615035019.35808-1-wangyanan55@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, james.morse@arm.com, alexandru.elisei@arm.com, eric.auger@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, yuzenghui@huawei.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jun 2021 04:50:19 +0100, Yanan Wang wrote: > > These fixes introduce no functional change but just adjustment about > coding style issues for ARM64 vgic code. They mainly include identation > fix of function parameters/arguments, identation fix of structure > initialization, identation fix of comment, also the deletion of some > superfluous space lines. Please don't. This sort of patches bring little value, and make the backporting of important fixes more difficult because of pointless context change. Fixing these cosmetic details is fine when you are modifying the code. But as a standalone patch, this brings more pain than benefit. Thanks, M. -- Without deviation from the norm, progress is not possible.