From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris.p.wilson@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy
Date: Mon, 26 Apr 2021 14:53:03 +0300 [thread overview]
Message-ID: <87o8e15kkg.fsf@intel.com> (raw)
In-Reply-To: <39ebb433-1a1b-db1e-b7e6-9d4d7971d18c@intel.com>
On Fri, 23 Apr 2021, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote:
> On 21/04/2021 20:28, Umesh Nerlige Ramappa wrote:
>> +static int
>> +query_cs_cycles(struct drm_i915_private *i915,
>> + struct drm_i915_query_item *query_item)
>> +{
>> + struct drm_i915_query_cs_cycles __user *query_ptr;
>> + struct drm_i915_query_cs_cycles query;
>> + struct intel_engine_cs *engine;
>> + __ktime_func_t cpu_clock;
>> + int ret;
>> +
>> + if (INTEL_GEN(i915) < 6)
>> + return -ENODEV;
>> +
[...]
>> +
>> + if (IS_GEN(i915, 6) &&
>> + query.engine.engine_class != I915_ENGINE_CLASS_RENDER)
>> + return -ENODEV;
>
>
> Thanks a bunch for rebasing this.
>
> My only comment on this patch would be : don't we want
> IS_GEN_RANGE(i915, 1, 6) instead of IS_GEN(i915, 6) ?
Please see the new deprecation comments in i915_drv.h. We're moving from
GEN to VER. In short, please use the new VER macros for individual
components instead of the generic GEN.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-26 11:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 17:28 [Intel-gfx] [PATCH 0/1] Add support for querying engine cycles Umesh Nerlige Ramappa
2021-04-21 17:28 ` [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
2021-04-23 7:05 ` Lionel Landwerlin
2021-04-23 15:11 ` Umesh Nerlige Ramappa
2021-04-23 15:21 ` Lionel Landwerlin
2021-04-26 11:53 ` Jani Nikula [this message]
2021-04-21 18:26 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Add support for querying engine cycles Patchwork
2021-04-21 18:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-22 2:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-04-27 21:49 [Intel-gfx] [PATCH 0/1] " Umesh Nerlige Ramappa
2021-04-27 21:49 ` [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
2021-04-28 8:43 ` Jani Nikula
2021-04-28 19:24 ` Jason Ekstrand
2021-04-28 19:49 ` Lionel Landwerlin
2021-04-28 19:54 ` Jason Ekstrand
2021-04-28 20:14 ` Lionel Landwerlin
2021-04-28 20:16 ` Lionel Landwerlin
2021-04-28 20:45 ` Jason Ekstrand
2021-04-28 21:18 ` Lionel Landwerlin
2021-04-29 11:15 ` Daniel Vetter
2021-04-27 21:53 [Intel-gfx] [PATCH 0/1] Add support for querying engine cycles Umesh Nerlige Ramappa
2021-04-27 21:53 ` [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
2021-04-29 0:34 [Intel-gfx] [PATCH 0/1] Add support for querying engine cycles Umesh Nerlige Ramappa
2021-04-29 0:34 ` [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
2021-04-29 8:34 ` Lionel Landwerlin
2021-04-29 19:07 ` Jason Ekstrand
2021-04-30 22:26 ` Umesh Nerlige Ramappa
2021-04-30 23:00 ` Dixit, Ashutosh
2021-04-30 23:23 ` Dixit, Ashutosh
2021-05-01 0:35 ` Jason Ekstrand
2021-05-01 2:19 ` Umesh Nerlige Ramappa
2021-05-01 4:01 ` Dixit, Ashutosh
2021-05-01 15:27 ` Jason Ekstrand
2021-05-03 18:29 ` Umesh Nerlige Ramappa
2021-05-04 0:12 [Intel-gfx] [PATCH 0/1] Add support for querying engine cycles Umesh Nerlige Ramappa
2021-05-04 0:12 ` [Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8e15kkg.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.