From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Jain Date: Wed, 31 Mar 2021 03:50:12 +0000 Subject: Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH Message-Id: <87o8f0oud5.fsf@vajain21.in.ibm.com> List-Id: References: <20210329162259.536964-1-vaibhav@linux.ibm.com> <20210330161437.45872897@bahia.lan> <87r1jwpo3p.fsf@vajain21.in.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Gibson Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com, aneesh.kumar@linux.ibm.com, Greg Kurz , kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org, shivaprasadbhat@gmail.com, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, imammedo@redhat.com, ehabkost@redhat.com Thanks for looking into this patch, David Gibson writes: >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in the commit message would be a good idea. > Yes, its already part of v1 patch description as reference [1]. >> > >> > Having access to the excerpts from the PAPR addendum that describes >> > this hcall would _really_ help in reviewing. >> > >> The kernel documentation for H_SCM_HEALTH mentioned above captures most >> if not all parts of the PAPR addendum for this hcall. I believe it >> contains enough information to review the patch. If you still need more >> info than please let me know. > > We've missed the qemu-6.0 cutoff, so this will be 6.1 material. I'll > await v2 for further review. > Agree. Will send a v2 today incorporating current review comments. -- Cheers ~ Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B2DC433C1 for ; Wed, 31 Mar 2021 03:50:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE094619B9 for ; Wed, 31 Mar 2021 03:50:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE094619B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRRse-0008To-Ou for qemu-devel@archiver.kernel.org; Tue, 30 Mar 2021 23:50:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRRrb-0007xu-C1; Tue, 30 Mar 2021 23:49:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRRrZ-0005Am-IS; Tue, 30 Mar 2021 23:49:51 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12V3X2MJ033526; Tue, 30 Mar 2021 23:49:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=pp1; bh=UGudfjMlEZLfqlVSDmOnmDyvQ96ap/6ySNEkNaXapKw=; b=GTM9yj3DTlZ+CObdWSTnW7Ti60AIpB1DD8bx/5JfermBikCns6FKGLVRq1ETpjXyKxoC M3vtxB9eXlFItXnfEhduT3noYYDUM5j9h94OydqzV7Pt1zhOesv4IIx854LMNsO9bnkM a78JOmjlRHK3dhFZihAupQ/bQFtANmh6TeKLJscLEKBZzIJcSVWU8AMV+GA7Ggt/vpBp ymwW3emIn/WK1EhRswureNr0iADPHJ8rinK+lbdRrBEzf8cQ/7uXgKjxDBjHoC2jFvjZ jWy/PLPAAAd8kMwy6cpyxsL70EH2kz6ayKLDKflqmX1HsUYtZZ2BS23OQmLeLFy/ORX+ mg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 37mb4qytu6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Mar 2021 23:49:37 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 12V3YmCp043540; Tue, 30 Mar 2021 23:49:36 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 37mb4qyttn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Mar 2021 23:49:36 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12V3mcq9030521; Wed, 31 Mar 2021 03:49:34 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma02fra.de.ibm.com with ESMTP id 37maaqr4a8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Mar 2021 03:49:34 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12V3nCLI19857854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Mar 2021 03:49:12 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB88F11C058; Wed, 31 Mar 2021 03:49:31 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07B0911C04A; Wed, 31 Mar 2021 03:49:28 +0000 (GMT) Received: from vajain21.in.ibm.com (unknown [9.199.35.103]) by d06av25.portsmouth.uk.ibm.com (Postfix) with SMTP; Wed, 31 Mar 2021 03:49:27 +0000 (GMT) Received: by vajain21.in.ibm.com (sSMTP sendmail emulation); Wed, 31 Mar 2021 09:19:26 +0530 From: Vaibhav Jain To: David Gibson Subject: Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH In-Reply-To: References: <20210329162259.536964-1-vaibhav@linux.ibm.com> <20210330161437.45872897@bahia.lan> <87r1jwpo3p.fsf@vajain21.in.ibm.com> Date: Wed, 31 Mar 2021 09:19:26 +0530 Message-ID: <87o8f0oud5.fsf@vajain21.in.ibm.com> Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3l4_Pp94MnAf2UruDvx2Q97Q3CG-PIJJ X-Proofpoint-ORIG-GUID: Vu5cKAMR9g1BQsQvQjgcVMnbtcKqz1wo X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-31_01:2021-03-30, 2021-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103300000 definitions=main-2103310024 Received-SPF: pass client-ip=148.163.156.1; envelope-from=vaibhav@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com, aneesh.kumar@linux.ibm.com, Greg Kurz , kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org, shivaprasadbhat@gmail.com, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, imammedo@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Thanks for looking into this patch, David Gibson writes: >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in the commit message would be a good idea. > Yes, its already part of v1 patch description as reference [1]. >> > >> > Having access to the excerpts from the PAPR addendum that describes >> > this hcall would _really_ help in reviewing. >> > >> The kernel documentation for H_SCM_HEALTH mentioned above captures most >> if not all parts of the PAPR addendum for this hcall. I believe it >> contains enough information to review the patch. If you still need more >> info than please let me know. > > We've missed the qemu-6.0 cutoff, so this will be 6.1 material. I'll > await v2 for further review. > Agree. Will send a v2 today incorporating current review comments. -- Cheers ~ Vaibhav