From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Cc: linux-ext4@vger.kernel.org, Daniel Rosenberg <drosen@google.com>
Subject: Re: [PATCH v2 01/12] tune2fs: Allow enabling casefold feature after fs creation
Date: Mon, 07 Dec 2020 14:17:19 -0300 [thread overview]
Message-ID: <87o8j57cyo.fsf@collabora.com> (raw)
In-Reply-To: <20201127170116.197901-2-arnaud.ferraris@collabora.com> (Arnaud Ferraris's message of "Fri, 27 Nov 2020 18:01:05 +0100")
Arnaud Ferraris <arnaud.ferraris@collabora.com> writes:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> The main reason we didn't allow this before was because !CASEFOLDED
> directories were expected to be normalized(). Since this is no longer
> the case, and as long as the encrypt feature is not enabled, it should
> be safe to enable this feature.
>
> Disabling the feature is trickier, since we need to make sure there are
> no existing +F directories in the filesystem. Leave that for a future
> patch.
>
> Also, enabling strict mode requires some filesystem-wide verification,
> so ignore that for now.
>
For some reason, I wasn't CC'd in the cover letter, only on the patches
themselves. Anyway, in order to get more/the right attention, I think
you should CC Ted and Eric Biggers on the entire thread.
Can you send a v3 with a proper CC list?
I haven't taken a second look at the patches yet, but it is no my to list.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2020-12-07 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 17:01 [PATCH v2 00/12] e2fsprogs: improve case-insensitive fs support Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 01/12] tune2fs: Allow enabling casefold feature after fs creation Arnaud Ferraris
2020-12-07 17:17 ` Gabriel Krisman Bertazi [this message]
2020-11-27 17:01 ` [PATCH v2 02/12] tune2fs: Fix casefold+encrypt error message Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 03/12] ext2fs: Add method to validate casefolded strings Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 04/12] ext2fs: Implement faster CI comparison of strings Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 05/12] e2fsck: add new problem for casefolded name check Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 06/12] e2fsck: Fix entries with invalid encoded characters Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 07/12] e2fsck: Support casefold directories when rehashing Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 08/12] dict: Support comparison with context Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 09/12] e2fsck: Detect duplicated casefolded direntries for rehash Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 10/12] e2fsck: Add option to force encoded filename verification Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 11/12] e2fsck.8.in: Document check_encoding extended option Arnaud Ferraris
2020-11-27 17:01 ` [PATCH v2 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates Arnaud Ferraris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8j57cyo.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=arnaud.ferraris@collabora.com \
--cc=drosen@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.