From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECCEC4363D for ; Fri, 2 Oct 2020 07:07:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A6FA206DD for ; Fri, 2 Oct 2020 07:07:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G2HezEoD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6FA206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOFAT-0006Mc-6W for qemu-devel@archiver.kernel.org; Fri, 02 Oct 2020 03:07:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOF9G-0005vj-8O for qemu-devel@nongnu.org; Fri, 02 Oct 2020 03:06:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kOF9D-0000YH-TQ for qemu-devel@nongnu.org; Fri, 02 Oct 2020 03:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601622390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+0luwKo92VOanyliuaMMD7+7fjDSGp8JFpEfdV9Adk=; b=G2HezEoDEYvqGZ/JuWOoM87DV+StgmO1v2/3nAt+l8Lqmv09S/6vyzJFjI36MacbIoK/GI G6HlgBIBlXfLn/XjjyMnWm4ygwDWR/KS+U1DbU2WqqrgJjyViMsuX9SSYT9j5UqF3m2zyh fXbxL4YAV74BdbR1mjZmxtwGit0WsBI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-9JHC2yqqM0maI7ZkObn0Jg-1; Fri, 02 Oct 2020 03:06:29 -0400 X-MC-Unique: 9JHC2yqqM0maI7ZkObn0Jg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A43221074640; Fri, 2 Oct 2020 07:06:27 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-101.ams2.redhat.com [10.36.112.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D2EB55767; Fri, 2 Oct 2020 07:06:26 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 75A2A1132784; Fri, 2 Oct 2020 09:06:25 +0200 (CEST) From: Markus Armbruster To: Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Subject: Re: [PATCH qemu 1/4] drive-mirror: add support for sync=bitmap mode=never References: <20200922091418.53562-1-f.gruenbichler@proxmox.com> <20200922091418.53562-2-f.gruenbichler@proxmox.com> Date: Fri, 02 Oct 2020 09:06:25 +0200 In-Reply-To: <20200922091418.53562-2-f.gruenbichler@proxmox.com> ("Fabian =?utf-8?Q?Gr=C3=BCnbichler=22's?= message of "Tue, 22 Sep 2020 11:14:15 +0200") Message-ID: <87o8llrtse.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 01:13:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Ma Haocong , qemu-devel@nongnu.org, Max Reitz , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fabian Gr=C3=BCnbichler writes: > From: John Snow > > This patch adds support for the "BITMAP" sync mode to drive-mirror and > blockdev-mirror. It adds support only for the BitmapSyncMode "never," > because it's the simplest mode. > > This mode simply uses a user-provided bitmap as an initial copy > manifest, and then does not clear any bits in the bitmap at the > conclusion of the operation. > > Any new writes dirtied during the operation are copied out, in contrast > to backup. Note that whether these writes are reflected in the bitmap > at the conclusion of the operation depends on whether that bitmap is > actually recording! > > This patch was originally based on one by Ma Haocong, but it has since > been modified pretty heavily. > > Suggested-by: Ma Haocong > Signed-off-by: Ma Haocong > Signed-off-by: John Snow > Signed-off-by: Fabian Gr=C3=BCnbichler > --- [...] > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 2d94873ca0..dac5497084 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1961,10 +1961,19 @@ > # (all the disk, only the sectors allocated in the topmost image,= or > # only new I/O). > # > +# @bitmap: The name of a bitmap to use for sync=3Dbitmap mode. This argu= ment must > +# be present for bitmap mode and absent otherwise. The bitmap's What is "bitmap mode"? Do you mean "present when @bitmap-mode is, else absent"? > +# granularity is used instead of @granularity (since 5.2). > +# > +# @bitmap-mode: Specifies the type of data the bitmap should contain aft= er > +# the operation concludes. Must be present if sync is "bit= map". > +# Must NOT be present otherwise. (Since 5.2) > +# > # @granularity: granularity of the dirty bitmap, default is 64K > # if the image format doesn't have clusters, 4K if the clu= sters > # are smaller than that, else the cluster size. Must be a > -# power of 2 between 512 and 64M (since 1.4). > +# power of 2 between 512 and 64M. Must not be specified if > +# @bitmap is present (since 1.4). > # Is @granularity forbidden with @bitmap because it makes no sense? If yes, then it doesn't actually default to anything then, does it? Looks like we have sync 'bitmap' anything else ------------------------------------------------- bitmap required forbidden bitmap-mode required forbidden granularity forbidden optional Correct? > # @buf-size: maximum amount of data in flight from source to > # target (since 1.4). > @@ -2002,7 +2011,9 @@ > { 'struct': 'DriveMirror', > 'data': { '*job-id': 'str', 'device': 'str', 'target': 'str', > '*format': 'str', '*node-name': 'str', '*replaces': 'str', > - 'sync': 'MirrorSyncMode', '*mode': 'NewImageMode', > + 'sync': 'MirrorSyncMode', '*bitmap': 'str', > + '*bitmap-mode': 'BitmapSyncMode', > + '*mode': 'NewImageMode', > '*speed': 'int', '*granularity': 'uint32', > '*buf-size': 'int', '*on-source-error': 'BlockdevOnError', > '*on-target-error': 'BlockdevOnError', [Same for blockdev-mirror...]