From: Markus Armbruster <armbru@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org,
peterx@redhat.com, jean-philippe@linaro.org, qemu-arm@nongnu.org,
pbonzini@redhat.com, bbhushan2@marvell.com,
eric.auger.pro@gmail.com
Subject: Re: [PATCH v6 2/5] virtio-iommu: Implement RESV_MEM probe request
Date: Sat, 27 Jun 2020 09:08:31 +0200 [thread overview]
Message-ID: <87o8p5rno0.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200626103057.11263-3-eric.auger@redhat.com> (Eric Auger's message of "Fri, 26 Jun 2020 12:30:54 +0200")
Eric Auger <eric.auger@redhat.com> writes:
> This patch implements the PROBE request. At the moment,
> only THE RESV_MEM property is handled. The first goal is
> to report iommu wide reserved regions such as the MSI regions
> set by the machine code. On x86 this will be the IOAPIC MSI
> region, [0xFEE00000 - 0xFEEFFFFF], on ARM this may be the ITS
> doorbell.
>
> In the future we may introduce per device reserved regions.
> This will be useful when protecting host assigned devices
> which may expose their own reserved regions
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> ---
>
> v5 -> v6:
> - removed validation of s->reserved_regions[i].type in the
> probe request as it should rather happen in the realize()
Consider keeping the assertion. I'd makes it locally obvious that the
assignment to subtype is not supposed to truncate. The realize method
is in another file. This is not a demand.
[...]
next prev parent reply other threads:[~2020-06-27 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 10:30 [PATCH v6 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM Eric Auger
2020-06-26 10:30 ` [PATCH v6 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION Eric Auger
2020-06-26 10:30 ` [PATCH v6 2/5] virtio-iommu: Implement RESV_MEM probe request Eric Auger
2020-06-27 7:08 ` Markus Armbruster [this message]
2020-06-27 7:10 ` Auger Eric
2020-06-26 10:30 ` [PATCH v6 3/5] virtio-iommu: Handle reserved regions in the translation process Eric Auger
2020-06-26 10:30 ` [PATCH v6 4/5] virtio-iommu-pci: Add array of Interval properties Eric Auger
2020-06-27 7:03 ` Markus Armbruster
2020-06-27 7:08 ` Auger Eric
2020-06-26 10:30 ` [PATCH v6 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8p5rno0.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=bbhushan2@marvell.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.