From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40ABCC433E0 for ; Tue, 19 May 2020 14:23:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1495A20709 for ; Tue, 19 May 2020 14:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1495A20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9856989CCE; Tue, 19 May 2020 14:23:16 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ED3D89CCE for ; Tue, 19 May 2020 14:23:15 +0000 (UTC) IronPort-SDR: pH8meNGBsRaz9yWSIW4BQ55a/UVEGj08DvhEZSiu7uRqWojwJVxEbScdRZs6mJkUi/+Q+JJbva W/rlT1ZMjD+Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 07:23:14 -0700 IronPort-SDR: LHgvqh7AngOS1pANQbeAreiVwT6RRg/XWOxMsBq2wZJSKoZGDge6jMWoXltNN2g2WvRPahu5tf /FQvOwxkLtMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="267900216" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga006.jf.intel.com with ESMTP; 19 May 2020 07:23:13 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 916585C03F7; Tue, 19 May 2020 17:20:56 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200519063123.20673-4-chris@chris-wilson.co.uk> References: <20200519063123.20673-1-chris@chris-wilson.co.uk> <20200519063123.20673-4-chris@chris-wilson.co.uk> Date: Tue, 19 May 2020 17:20:56 +0300 Message-ID: <87o8qkt393.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 04/12] drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > When we look at i915_request_is_started() we must be careful in case we > are using a request that does not have the initial-breadcrumb and > instead the is-started is being compared against the end of the previous > request. This will make wait_for_submit() declare that a request has > been already submitted too early. submitted....started...handled_by_gpu. I guess wait_for_submit is generic enough to cater all cases but we actually do not wait for submit but we wait for gpu to reach it. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index b71f04db9c6e..f6949cd55e92 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -75,7 +75,7 @@ static bool is_active(struct i915_request *rq) > if (i915_request_on_hold(rq)) > return true; > > - if (i915_request_started(rq)) > + if (i915_request_has_initial_breadcrumb(rq) && i915_request_started(rq)) > return true; > > return false; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx