From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FEDC83003 for ; Wed, 29 Apr 2020 06:17:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66BDE2072A for ; Wed, 29 Apr 2020 06:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eNQP7XWp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66BDE2072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTg1x-0007A1-Hi for qemu-devel@archiver.kernel.org; Wed, 29 Apr 2020 02:17:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39430) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTfx3-0007Ju-FG for qemu-devel@nongnu.org; Wed, 29 Apr 2020 02:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTfx2-00035k-Ue for qemu-devel@nongnu.org; Wed, 29 Apr 2020 02:12:09 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20205 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jTfx2-00035d-Gj for qemu-devel@nongnu.org; Wed, 29 Apr 2020 02:12:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588140727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fz10Ss7/nZXlUzPCdGjrH9Ql4A9kWuqCsyigRO11rC8=; b=eNQP7XWpFRcRkA5B0WVFDJd6x0F7OcZAIOurdtJBir5T+S69JiXxHejag1mHqmOJz1pbo7 SvFrocBQDYcMPkWVKK3IsA/rZ1isrCszAiNdUOwnaq9m4jMPTAC33D4bZkNFM2CjEcxwQT xwK5jr4zyHkeZQwdcHw+hgHzDccc/EM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-QSsOnJmNN-iVTlF3UIsZVg-1; Wed, 29 Apr 2020 02:12:05 -0400 X-MC-Unique: QSsOnJmNN-iVTlF3UIsZVg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0E0C107ACCD; Wed, 29 Apr 2020 06:12:04 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-113-6.ams2.redhat.com [10.36.113.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9506826570; Wed, 29 Apr 2020 06:12:04 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1C29C11358BC; Wed, 29 Apr 2020 08:12:03 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init() References: <20200413213825.15584-1-f4bug@amsat.org> Date: Wed, 29 Apr 2020 08:12:03 +0200 In-Reply-To: <20200413213825.15584-1-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 13 Apr 2020 23:38:25 +0200") Message-ID: <87o8ravn0s.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 01:42:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , qemu-devel@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h \ > --include-headers --keep-comments --in-place \ > --sp-file \ > scripts/coccinelle/use-error_abort-in-instance_init.cocci > > Reviewed-by: C=C3=A9dric Le Goater > Acked-by: Cornelia Huck > Signed-off-by: Philippe Mathieu-Daud=C3=A9 This one clashes with my "[PATCH 00/17] qom: Spring cleaning". Where your patch replaces object_property_add_FOO(..., NULL); by object_property_add_FOO(..., &error_abort); mine drops the parameter outright. Does not fully replace your patch, which touches other functions, too.