From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88458C2BA19 for ; Wed, 15 Apr 2020 07:37:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 630C32078A for ; Wed, 15 Apr 2020 07:37:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 630C32078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E900F6E86F; Wed, 15 Apr 2020 07:37:51 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 001116E86F for ; Wed, 15 Apr 2020 07:37:50 +0000 (UTC) IronPort-SDR: acSmzxnPTehM/TWcMPNuuOZnbuWfwtMqNDWNUEeXt0OLEQZ7JtAGjBB9Bq1H3lOywTR9fTBSaB Hl8eZXns1Abg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 00:37:50 -0700 IronPort-SDR: A0V+iObypOdjSC+ep3HFpo9vMalWZpyvdaFGRwDSUc7f2dZuBNvdKqQ8Kx3o+gwB8ScNDmm88l lRYPjIRi56KQ== X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="427347799" Received: from ssolodk-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.48.37]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 00:37:47 -0700 From: Jani Nikula To: James Hilliard Subject: Re: [PATCH] component: Silence bind error on -EPROBE_DEFER In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200411054106.25366-1-james.hilliard1@gmail.com> <87lfmymilm.fsf@intel.com> Date: Wed, 15 Apr 2020 10:37:44 +0300 Message-ID: <87o8rt5hdj.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, "Rafael J . Wysocki" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 14 Apr 2020, James Hilliard wrote: > On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula wrote: >> >> On Fri, 10 Apr 2020, James Hilliard wrote: >> > If a component fails to bind due to -EPROBE_DEFER we should not log an >> > error as this is not a real failure. >> > >> > Fixes: >> > vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517 >> > vc4-drm soc:gpu: master bind failed: -517 >> >> I'd think the probe defer is useful information anyway. Maybe just tone >> down the severity and/or the message? > That's probably not needed as there's dev_dbg logging for -EPROBE_DEFER > elsewhere from what it looks like. If you say so; I don't have the time to go through all the code paths. BR, Jani. > > For example: > https://github.com/torvalds/linux/blob/v5.6/drivers/base/dd.c#L621 >> >> BR, >> Jani. >> >> > >> > Signed-off-by: James Hilliard >> > --- >> > drivers/base/component.c | 9 ++++++--- >> > 1 file changed, 6 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/base/component.c b/drivers/base/component.c >> > index e97704104784..157c6c790578 100644 >> > --- a/drivers/base/component.c >> > +++ b/drivers/base/component.c >> > @@ -256,7 +256,8 @@ static int try_to_bring_up_master(struct master *master, >> > ret = master->ops->bind(master->dev); >> > if (ret < 0) { >> > devres_release_group(master->dev, NULL); >> > - dev_info(master->dev, "master bind failed: %d\n", ret); >> > + if (ret != -EPROBE_DEFER) >> > + dev_info(master->dev, "master bind failed: %d\n", ret); >> > return ret; >> > } >> > >> > @@ -611,8 +612,10 @@ static int component_bind(struct component *component, struct master *master, >> > devres_release_group(component->dev, NULL); >> > devres_release_group(master->dev, NULL); >> > >> > - dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", >> > - dev_name(component->dev), component->ops, ret); >> > + if (ret != -EPROBE_DEFER) { >> > + dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", >> > + dev_name(component->dev), component->ops, ret); >> > + } >> > } >> > >> > return ret; >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B3AC2BA19 for ; Wed, 15 Apr 2020 07:38:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DF022078A for ; Wed, 15 Apr 2020 07:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2635201AbgDOHie (ORCPT ); Wed, 15 Apr 2020 03:38:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:58577 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2635193AbgDOHhu (ORCPT ); Wed, 15 Apr 2020 03:37:50 -0400 IronPort-SDR: DDmtRMW2cB+9waO7a+rQ1CcL+3GZNqUF2YWV6G31leaa8GCwBbVs1uqqh8ZFL2DeitfZ95jqz8 pJbsbNWMPgoQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 00:37:50 -0700 IronPort-SDR: A0V+iObypOdjSC+ep3HFpo9vMalWZpyvdaFGRwDSUc7f2dZuBNvdKqQ8Kx3o+gwB8ScNDmm88l lRYPjIRi56KQ== X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="427347799" Received: from ssolodk-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.48.37]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 00:37:47 -0700 From: Jani Nikula To: James Hilliard Cc: dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Linux Kernel Mailing List , "Rafael J . Wysocki" Subject: Re: [PATCH] component: Silence bind error on -EPROBE_DEFER In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200411054106.25366-1-james.hilliard1@gmail.com> <87lfmymilm.fsf@intel.com> Date: Wed, 15 Apr 2020 10:37:44 +0300 Message-ID: <87o8rt5hdj.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Apr 2020, James Hilliard wrote: > On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula wrote: >> >> On Fri, 10 Apr 2020, James Hilliard wrote: >> > If a component fails to bind due to -EPROBE_DEFER we should not log an >> > error as this is not a real failure. >> > >> > Fixes: >> > vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517 >> > vc4-drm soc:gpu: master bind failed: -517 >> >> I'd think the probe defer is useful information anyway. Maybe just tone >> down the severity and/or the message? > That's probably not needed as there's dev_dbg logging for -EPROBE_DEFER > elsewhere from what it looks like. If you say so; I don't have the time to go through all the code paths. BR, Jani. > > For example: > https://github.com/torvalds/linux/blob/v5.6/drivers/base/dd.c#L621 >> >> BR, >> Jani. >> >> > >> > Signed-off-by: James Hilliard >> > --- >> > drivers/base/component.c | 9 ++++++--- >> > 1 file changed, 6 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/base/component.c b/drivers/base/component.c >> > index e97704104784..157c6c790578 100644 >> > --- a/drivers/base/component.c >> > +++ b/drivers/base/component.c >> > @@ -256,7 +256,8 @@ static int try_to_bring_up_master(struct master *master, >> > ret = master->ops->bind(master->dev); >> > if (ret < 0) { >> > devres_release_group(master->dev, NULL); >> > - dev_info(master->dev, "master bind failed: %d\n", ret); >> > + if (ret != -EPROBE_DEFER) >> > + dev_info(master->dev, "master bind failed: %d\n", ret); >> > return ret; >> > } >> > >> > @@ -611,8 +612,10 @@ static int component_bind(struct component *component, struct master *master, >> > devres_release_group(component->dev, NULL); >> > devres_release_group(master->dev, NULL); >> > >> > - dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", >> > - dev_name(component->dev), component->ops, ret); >> > + if (ret != -EPROBE_DEFER) { >> > + dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", >> > + dev_name(component->dev), component->ops, ret); >> > + } >> > } >> > >> > return ret; >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center