All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthew" <matthew.zeng@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: [PATCH] wireshark: poppler: prevent PACKAGECONFIG change based on different layers
Date: Tue, 7 Apr 2020 15:34:13 -0400	[thread overview]
Message-ID: <87o8s3qedm.fsf@windriver.com> (raw)

    As per discussed in a previous email under the subject "Regarding
    poppler auto PACKAGECONFIG when qt5-layer exists", adding a layer
    but not using it should not change PACKAGECONFIG automatically. It
    may result unexpected error.

Signed-off-by: Matthew Zeng <matthew.zeng@windriver.com>
---
 meta-networking/recipes-support/wireshark/wireshark_3.2.2.bb | 2 +-
 meta-oe/recipes-support/poppler/poppler_0.85.0.bb            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-support/wireshark/wireshark_3.2.2.bb b/meta-networking/recipes-support/wireshark/wireshark_3.2.2.bb
index 91a7e1a36..db545028f 100644
--- a/meta-networking/recipes-support/wireshark/wireshark_3.2.2.bb
+++ b/meta-networking/recipes-support/wireshark/wireshark_3.2.2.bb
@@ -19,7 +19,7 @@ PE = "1"

 inherit cmake pkgconfig python3native perlnative upstream-version-is-even mime mime-xdg

-PACKAGECONFIG ?= "libpcap gnutls libnl libcap sbc ${@bb.utils.contains('BBFILE_COLLECTIONS', 'qt5-layer', 'qt5 plugins', '', d)}"
+PACKAGECONFIG ?= "libpcap gnutls libnl libcap sbc"

 PACKAGECONFIG_class-native = "libpcap gnutls ssl libssh"

diff --git a/meta-oe/recipes-support/poppler/poppler_0.85.0.bb b/meta-oe/recipes-support/poppler/poppler_0.85.0.bb
index 2f5d094fb..366f0c5cf 100644
--- a/meta-oe/recipes-support/poppler/poppler_0.85.0.bb
+++ b/meta-oe/recipes-support/poppler/poppler_0.85.0.bb
@@ -14,7 +14,7 @@ DEPENDS = "fontconfig zlib cairo lcms glib-2.0"

 inherit cmake pkgconfig gobject-introspection

-PACKAGECONFIG ??= "jpeg openjpeg png tiff nss ${@bb.utils.contains('BBFILE_COLLECTIONS', 'qt5-layer', 'qt5', '', d)}"
+PACKAGECONFIG ??= "jpeg openjpeg png tiff nss"
 PACKAGECONFIG[jpeg] = "-DWITH_JPEG=ON -DENABLE_DCTDECODER=libjpeg,-DWITH_JPEG=OFF -DENABLE_DCTDECODER=none,jpeg"
 PACKAGECONFIG[png] = "-DWITH_PNG=ON,-DWITH_PNG=OFF,libpng"
 PACKAGECONFIG[tiff] = "-DWITH_TIFF=ON,-DWITH_TIFF=OFF,tiff"
--
2.24.0

             reply	other threads:[~2020-04-07 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 19:34 Matthew [this message]
2020-04-08  0:52 ` [oe] [PATCH] wireshark: poppler: prevent PACKAGECONFIG change based on different layers Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8s3qedm.fsf@windriver.com \
    --to=matthew.zeng@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.