From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E9EC2BA16 for ; Sat, 4 Apr 2020 12:19:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 253F6206C3 for ; Sat, 4 Apr 2020 12:19:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FWPXcQeB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 253F6206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKhld-0007Pt-98 for qemu-devel@archiver.kernel.org; Sat, 04 Apr 2020 08:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53638) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKhl4-0006va-5L for qemu-devel@nongnu.org; Sat, 04 Apr 2020 08:18:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKhl2-0002WY-7G for qemu-devel@nongnu.org; Sat, 04 Apr 2020 08:18:41 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:58188 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKhl2-0002VR-1Y for qemu-devel@nongnu.org; Sat, 04 Apr 2020 08:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586002718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Moo3HU/4u/WEfDh9wKFzVWD/Qqq1GluNhxYXgW4QkRA=; b=FWPXcQeBtCIEjKUMd9yuzibG5cq6KfJbk95GTts7UxZBYq7r8tUH9TRtSr+V/z/y9IRB91 wBPixYo+EtQWhw0jzzFy+E8UIi36F7NjnMNkO/fUigQJ0UmT3IetGHkI+dKOiT6QZNV+8q URhavne4w7aBU0uzRl+wHBNyLBmsAzY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-j7kHl0KkMyGDIOuX6mdQ_w-1; Sat, 04 Apr 2020 08:18:36 -0400 X-MC-Unique: j7kHl0KkMyGDIOuX6mdQ_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51EC98018A3; Sat, 4 Apr 2020 12:18:06 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-152.ams2.redhat.com [10.36.112.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E534A1001B3F; Sat, 4 Apr 2020 12:18:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2ADDD1138610; Sat, 4 Apr 2020 14:18:01 +0200 (CEST) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH for-5.0 0/6] Several error use-after-free References: <20200324153630.11882-1-vsementsov@virtuozzo.com> Date: Sat, 04 Apr 2020 14:18:01 +0200 In-Reply-To: <20200324153630.11882-1-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 24 Mar 2020 18:36:24 +0300") Message-ID: <87o8s7fnra.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org, marcandre.lureau@redhat.com, den@openvz.org, mreitz@redhat.com, jsnow@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > Hi all! > > I accidentally found use-after-free of local_err in mirror, and decided > to search for similar cases with help of small coccinelle script > (patch 01). Happily, there no many cases. > > Better to fix zero Error* pointer after each freeing everywhere, but > this is too much for 5.0 and most of these cases will be covered by > error-auto-propagation series. > > Note also, that there are still a lot of use-after-free cases possible > when error is not local variable but field of some structure, shared by > several functions. I queued the part that hasn't been merged. Thanks!