From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CF2C2BA83 for ; Fri, 14 Feb 2020 11:49:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67885217F4 for ; Fri, 14 Feb 2020 11:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67885217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1D506E5C1; Fri, 14 Feb 2020 11:49:39 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4B7D6E5C1; Fri, 14 Feb 2020 11:49:38 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:38 -0800 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="227578838" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:34 -0800 From: Jani Nikula To: Chris Wilson , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma In-Reply-To: <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200214054706.33870-1-natechancellor@gmail.com> <87v9o965gg.fsf@intel.com> <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Date: Fri, 14 Feb 2020 13:49:31 +0200 Message-ID: <87o8u1wfqs.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Michel =?utf-8?Q?D=C3=A4nzer?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAxNCBGZWIgMjAyMCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgSmFuaSBOaWt1bGEgKDIwMjAtMDItMTQgMDY6MzY6MTUpCj4+ IE9uIFRodSwgMTMgRmViIDIwMjAsIE5hdGhhbiBDaGFuY2VsbG9yIDxuYXRlY2hhbmNlbGxvckBn bWFpbC5jb20+IHdyb3RlOgo+PiA+IEEgcmVjZW50IGNvbW1pdCBpbiBjbGFuZyBhZGRlZCAtV3Rh dXRvbG9naWNhbC1jb21wYXJlIHRvIC1XYWxsLCB3aGljaCBpcwo+PiA+IGVuYWJsZWQgZm9yIGk5 MTUgYWZ0ZXIgLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSBpcyBkaXNhYmxlZCBmb3IgdGhlIHJlc3QK Pj4gPiBvZiB0aGUga2VybmVsIHNvIHdlIHNlZSB0aGUgZm9sbG93aW5nIHdhcm5pbmcgb24geDg2 XzY0Ogo+PiA+Cj4+ID4gIC4uL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9leGVj YnVmZmVyLmM6MTQzMzoyMjogd2FybmluZzoKPj4gPiAgcmVzdWx0IG9mIGNvbXBhcmlzb24gb2Yg Y29uc3RhbnQgNTc2NDYwNzUyMzAzNDIzNDg3IHdpdGggZXhwcmVzc2lvbiBvZgo+PiA+ICB0eXBl ICd1bnNpZ25lZCBpbnQnIGlzIGFsd2F5cyBmYWxzZQo+PiA+ICBbLVd0YXV0b2xvZ2ljYWwtY29u c3RhbnQtb3V0LW9mLXJhbmdlLWNvbXBhcmVdCj4+ID4gICAgICAgICAgaWYgKHVubGlrZWx5KHJl bWFpbiA+IE5fUkVMT0MoVUxPTkdfTUFYKSkpCj4+ID4gICAgICAgICAgICAgfn5+fn5+fn5+fn5+ fn5+fl5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+PiA+ICAuLi9pbmNsdWRlL2xpbnV4L2NvbXBpbGVy Lmg6Nzg6NDI6IG5vdGU6IGV4cGFuZGVkIGZyb20gbWFjcm8gJ3VubGlrZWx5Jwo+PiA+ICAjIGRl ZmluZSB1bmxpa2VseSh4KSAgICBfX2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQo+PiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+PiA+ICAxIHdhcm5pbmcg Z2VuZXJhdGVkLgo+PiA+Cj4+ID4gSXQgaXMgbm90IHdyb25nIGluIHRoZSBjYXNlIHdoZXJlIFVM T05HX01BWCA+IFVJTlRfTUFYIGJ1dCBpdCBkb2VzIG5vdAo+PiA+IGFjY291bnQgZm9yIHRoZSBj YXNlIHdoZXJlIHRoaXMgZmlsZSBpcyBidWlsdCBmb3IgMzItYml0IHg4Niwgd2hlcmUKPj4gPiBV TE9OR19NQVggPT0gVUlOVF9NQVggYW5kIHRoaXMgY2hlY2sgaXMgc3RpbGwgcmVsZXZhbnQuCj4+ ID4KPj4gPiBDYXN0IHJlbWFpbiB0byB1bnNpZ25lZCBsb25nLCB3aGljaCBrZWVwcyB0aGUgZ2Vu ZXJhdGVkIGNvZGUgdGhlIHNhbWUKPj4gPiAodmVyaWZpZWQgd2l0aCBjbGFuZy0xMSBvbiB4ODZf NjQgYW5kIEdDQyA5LjIuMCBvbiB4ODYgYW5kIHg4Nl82NCkgYW5kCj4+ID4gdGhlIHdhcm5pbmcg aXMgc2lsZW5jZWQgc28gd2UgY2FuIGNhdGNoIG1vcmUgcG90ZW50aWFsIGlzc3VlcyBpbiB0aGUK Pj4gPiBmdXR1cmUuCj4+ID4KPj4gPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vQ2xhbmdCdWls dExpbnV4L2xpbnV4L2lzc3Vlcy83NzgKPj4gPiBTdWdnZXN0ZWQtYnk6IE1pY2hlbCBEw6RuemVy IDxtaWNoZWxAZGFlbnplci5uZXQ+Cj4+ID4gU2lnbmVkLW9mZi1ieTogTmF0aGFuIENoYW5jZWxs b3IgPG5hdGVjaGFuY2VsbG9yQGdtYWlsLmNvbT4KPj4gCj4+IFdvcmtzIGZvciBtZSBhcyBhIHdv cmthcm91bmQsCj4KPiBCdXQgdGhlIHdob2xlIHBvaW50IHdhcyB0aGF0IHRoZSBjb21waWxlciBj b3VsZCBzZWUgdGhhdCBpdCB3YXMKPiBpbXBvc3NpYmxlIGFuZCBub3QgZW1pdCB0aGUgY29kZS4g RG9lc24ndCB0aGlzIGJyZWFrIHRoYXQ/CgpJdCBzZWVtcyB0aGF0IGdvYWwgYW5kIHRoZSB3YXJu aW5nIGFyZSBmdW5kYW1lbnRhbGx5IGluY29tcGF0aWJsZS4KCkJhY2sgdG8gdGhlIG9yaWdpbmFs IHBhdGNoPwoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBH cmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51849C3B196 for ; Fri, 14 Feb 2020 11:49:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30064222C2 for ; Fri, 14 Feb 2020 11:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30064222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 962AF6E5BD; Fri, 14 Feb 2020 11:49:39 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4B7D6E5C1; Fri, 14 Feb 2020 11:49:38 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:38 -0800 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="227578838" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:34 -0800 From: Jani Nikula To: Chris Wilson , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi In-Reply-To: <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200214054706.33870-1-natechancellor@gmail.com> <87v9o965gg.fsf@intel.com> <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Date: Fri, 14 Feb 2020 13:49:31 +0200 Message-ID: <87o8u1wfqs.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Michel =?utf-8?Q?D=C3=A4nzer?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCAxNCBGZWIgMjAyMCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgSmFuaSBOaWt1bGEgKDIwMjAtMDItMTQgMDY6MzY6MTUpCj4+ IE9uIFRodSwgMTMgRmViIDIwMjAsIE5hdGhhbiBDaGFuY2VsbG9yIDxuYXRlY2hhbmNlbGxvckBn bWFpbC5jb20+IHdyb3RlOgo+PiA+IEEgcmVjZW50IGNvbW1pdCBpbiBjbGFuZyBhZGRlZCAtV3Rh dXRvbG9naWNhbC1jb21wYXJlIHRvIC1XYWxsLCB3aGljaCBpcwo+PiA+IGVuYWJsZWQgZm9yIGk5 MTUgYWZ0ZXIgLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSBpcyBkaXNhYmxlZCBmb3IgdGhlIHJlc3QK Pj4gPiBvZiB0aGUga2VybmVsIHNvIHdlIHNlZSB0aGUgZm9sbG93aW5nIHdhcm5pbmcgb24geDg2 XzY0Ogo+PiA+Cj4+ID4gIC4uL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9leGVj YnVmZmVyLmM6MTQzMzoyMjogd2FybmluZzoKPj4gPiAgcmVzdWx0IG9mIGNvbXBhcmlzb24gb2Yg Y29uc3RhbnQgNTc2NDYwNzUyMzAzNDIzNDg3IHdpdGggZXhwcmVzc2lvbiBvZgo+PiA+ICB0eXBl ICd1bnNpZ25lZCBpbnQnIGlzIGFsd2F5cyBmYWxzZQo+PiA+ICBbLVd0YXV0b2xvZ2ljYWwtY29u c3RhbnQtb3V0LW9mLXJhbmdlLWNvbXBhcmVdCj4+ID4gICAgICAgICAgaWYgKHVubGlrZWx5KHJl bWFpbiA+IE5fUkVMT0MoVUxPTkdfTUFYKSkpCj4+ID4gICAgICAgICAgICAgfn5+fn5+fn5+fn5+ fn5+fl5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+PiA+ICAuLi9pbmNsdWRlL2xpbnV4L2NvbXBpbGVy Lmg6Nzg6NDI6IG5vdGU6IGV4cGFuZGVkIGZyb20gbWFjcm8gJ3VubGlrZWx5Jwo+PiA+ICAjIGRl ZmluZSB1bmxpa2VseSh4KSAgICBfX2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQo+PiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+PiA+ICAxIHdhcm5pbmcg Z2VuZXJhdGVkLgo+PiA+Cj4+ID4gSXQgaXMgbm90IHdyb25nIGluIHRoZSBjYXNlIHdoZXJlIFVM T05HX01BWCA+IFVJTlRfTUFYIGJ1dCBpdCBkb2VzIG5vdAo+PiA+IGFjY291bnQgZm9yIHRoZSBj YXNlIHdoZXJlIHRoaXMgZmlsZSBpcyBidWlsdCBmb3IgMzItYml0IHg4Niwgd2hlcmUKPj4gPiBV TE9OR19NQVggPT0gVUlOVF9NQVggYW5kIHRoaXMgY2hlY2sgaXMgc3RpbGwgcmVsZXZhbnQuCj4+ ID4KPj4gPiBDYXN0IHJlbWFpbiB0byB1bnNpZ25lZCBsb25nLCB3aGljaCBrZWVwcyB0aGUgZ2Vu ZXJhdGVkIGNvZGUgdGhlIHNhbWUKPj4gPiAodmVyaWZpZWQgd2l0aCBjbGFuZy0xMSBvbiB4ODZf NjQgYW5kIEdDQyA5LjIuMCBvbiB4ODYgYW5kIHg4Nl82NCkgYW5kCj4+ID4gdGhlIHdhcm5pbmcg aXMgc2lsZW5jZWQgc28gd2UgY2FuIGNhdGNoIG1vcmUgcG90ZW50aWFsIGlzc3VlcyBpbiB0aGUK Pj4gPiBmdXR1cmUuCj4+ID4KPj4gPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vQ2xhbmdCdWls dExpbnV4L2xpbnV4L2lzc3Vlcy83NzgKPj4gPiBTdWdnZXN0ZWQtYnk6IE1pY2hlbCBEw6RuemVy IDxtaWNoZWxAZGFlbnplci5uZXQ+Cj4+ID4gU2lnbmVkLW9mZi1ieTogTmF0aGFuIENoYW5jZWxs b3IgPG5hdGVjaGFuY2VsbG9yQGdtYWlsLmNvbT4KPj4gCj4+IFdvcmtzIGZvciBtZSBhcyBhIHdv cmthcm91bmQsCj4KPiBCdXQgdGhlIHdob2xlIHBvaW50IHdhcyB0aGF0IHRoZSBjb21waWxlciBj b3VsZCBzZWUgdGhhdCBpdCB3YXMKPiBpbXBvc3NpYmxlIGFuZCBub3QgZW1pdCB0aGUgY29kZS4g RG9lc24ndCB0aGlzIGJyZWFrIHRoYXQ/CgpJdCBzZWVtcyB0aGF0IGdvYWwgYW5kIHRoZSB3YXJu aW5nIGFyZSBmdW5kYW1lbnRhbGx5IGluY29tcGF0aWJsZS4KCkJhY2sgdG8gdGhlIG9yaWdpbmFs IHBhdGNoPwoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBH cmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BCA4C2BA83 for ; Fri, 14 Feb 2020 11:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72341217F4 for ; Fri, 14 Feb 2020 11:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbgBNLti convert rfc822-to-8bit (ORCPT ); Fri, 14 Feb 2020 06:49:38 -0500 Received: from mga12.intel.com ([192.55.52.136]:16184 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727835AbgBNLti (ORCPT ); Fri, 14 Feb 2020 06:49:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:38 -0800 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="227578838" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 03:49:34 -0800 From: Jani Nikula To: Chris Wilson , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Michel =?utf-8?Q?D=C3=A4nzer?= Subject: Re: [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma In-Reply-To: <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200214054706.33870-1-natechancellor@gmail.com> <87v9o965gg.fsf@intel.com> <158166913989.4660.10674824117292988120@skylake-alporthouse-com> Date: Fri, 14 Feb 2020 13:49:31 +0200 Message-ID: <87o8u1wfqs.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Feb 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-02-14 06:36:15) >> On Thu, 13 Feb 2020, Nathan Chancellor wrote: >> > A recent commit in clang added -Wtautological-compare to -Wall, which is >> > enabled for i915 after -Wtautological-compare is disabled for the rest >> > of the kernel so we see the following warning on x86_64: >> > >> > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1433:22: warning: >> > result of comparison of constant 576460752303423487 with expression of >> > type 'unsigned int' is always false >> > [-Wtautological-constant-out-of-range-compare] >> > if (unlikely(remain > N_RELOC(ULONG_MAX))) >> > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ >> > ../include/linux/compiler.h:78:42: note: expanded from macro 'unlikely' >> > # define unlikely(x) __builtin_expect(!!(x), 0) >> > ^ >> > 1 warning generated. >> > >> > It is not wrong in the case where ULONG_MAX > UINT_MAX but it does not >> > account for the case where this file is built for 32-bit x86, where >> > ULONG_MAX == UINT_MAX and this check is still relevant. >> > >> > Cast remain to unsigned long, which keeps the generated code the same >> > (verified with clang-11 on x86_64 and GCC 9.2.0 on x86 and x86_64) and >> > the warning is silenced so we can catch more potential issues in the >> > future. >> > >> > Link: https://github.com/ClangBuiltLinux/linux/issues/778 >> > Suggested-by: Michel Dänzer >> > Signed-off-by: Nathan Chancellor >> >> Works for me as a workaround, > > But the whole point was that the compiler could see that it was > impossible and not emit the code. Doesn't this break that? It seems that goal and the warning are fundamentally incompatible. Back to the original patch? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center