All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] igc: Complete to commit Add basic skeleton for PTP
Date: Tue, 21 Jan 2020 13:59:04 -0800	[thread overview]
Message-ID: <87o8uw31zr.fsf@linux.intel.com> (raw)
In-Reply-To: <20200120063350.36467-1-sasha.neftin@intel.com>

Hi Sasha,

Sasha Neftin <sasha.neftin@intel.com> writes:

> commit 5f2958052c58 ("igc: Add basic skeleton for PTP")
> Add ptp suspend method to the igc_shutdown.

I guess the commit message could use a bit more text, something like
this:

"Commit 5f2958052c58 ("igc: Add basic skeleton for PTP") added basic
support for PTP, what's missing is support for suspending. By cleaning
the runtime storage for timestamp this avoids a possible invalid memory
access when the system comes back from suspend."

Apart from that, the code looks good.

Is this the only thing missing for suspend/resume to work? If so, that's
cool :-)


Cheers,
--
Vinicius

  reply	other threads:[~2020-01-21 21:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  6:33 [Intel-wired-lan] [PATCH v1] igc: Complete to commit Add basic skeleton for PTP Sasha Neftin
2020-01-21 21:59 ` Vinicius Costa Gomes [this message]
2020-01-22  6:28   ` Neftin, Sasha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8uw31zr.fsf@linux.intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.