From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Unexpected screen flicker during i915 initialization Date: Wed, 30 Oct 2019 15:07:34 +0200 Message-ID: <87o8xy8jqh.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chris Chiu , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel Cc: Linux Kernel , ville.syrjala@linux.intel.com List-Id: dri-devel@lists.freedesktop.org On Wed, 30 Oct 2019, Chris Chiu wrote: > Hi guys, > We have 2 laptops, ASUS Z406MA and Acer TravelMate B118, both > powered by the same Intel N5000 GemniLake CPU. On the Acer laptop, the > panel will blink once during boot which never happens on the ASUS > laptop. It caught my attention and I find the difference between them > but I need help for more information, > > The major difference happens in bxt_sanitize_cdclk() on the > following condition check. > if (cdctl == expected) > /* All well; nothing to sanitize */ > return; > > On the problematic Acer laptop, the value of cdctl is 0x27a while > the same cdctl is 0x278 on ASUS machine. Due to the 0x27a is not equal > to the expected value 0x278 so it needs to be sanitized by assigning > -1 to dev_priv->cdclk.hw.vco. Then the consequent bxt_set_cdclk() > will force the full PLL disable and enable. And that's the flicker > (blink) we observed during boot. > > Although I can't find the definition about the BIT(2) of CDCLK_CTL > which cause this difference. Can anyone suggest what exactly the > problem is and how should we deal with it? Thanks. The 11 least significant bits of that register are the cdclk frequency in 10.1 fixed point format. Apparently the Acer BIOS or GOP has a different idea of how to calculate the value from what i915 and the Asus think. To handle this in i915, we'd need to allow some deviation from the expected value, and only switch to use our value at the next modeset. We do need the sanitization though, because sometimes there have been completely bogus values to begin with. Please file a bug over at [1] and reference this thread. BR, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310E5CA9EC5 for ; Wed, 30 Oct 2019 13:07:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F7F20874 for ; Wed, 30 Oct 2019 13:07:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13F7F20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C7406E9DA; Wed, 30 Oct 2019 13:07:45 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A8D76E9CE; Wed, 30 Oct 2019 13:07:43 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:07:43 -0700 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="193962381" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:07:39 -0700 From: Jani Nikula To: Chris Chiu , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel Subject: Re: Unexpected screen flicker during i915 initialization In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 30 Oct 2019 15:07:34 +0200 Message-ID: <87o8xy8jqh.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191030130734.HIeeLwjx613Q-MqtIKHGcc6SWhz2muWdityH6QaquPM@z> T24gV2VkLCAzMCBPY3QgMjAxOSwgQ2hyaXMgQ2hpdSA8Y2hpdUBlbmRsZXNzbS5jb20+IHdyb3Rl Ogo+IEhpIGd1eXMsCj4gICAgIFdlIGhhdmUgMiBsYXB0b3BzLCBBU1VTIFo0MDZNQSBhbmQgQWNl ciBUcmF2ZWxNYXRlIEIxMTgsIGJvdGgKPiBwb3dlcmVkIGJ5IHRoZSBzYW1lIEludGVsIE41MDAw IEdlbW5pTGFrZSBDUFUuIE9uIHRoZSBBY2VyIGxhcHRvcCwgdGhlCj4gcGFuZWwgd2lsbCBibGlu ayBvbmNlIGR1cmluZyBib290IHdoaWNoIG5ldmVyIGhhcHBlbnMgb24gdGhlIEFTVVMKPiBsYXB0 b3AuIEl0IGNhdWdodCBteSBhdHRlbnRpb24gYW5kIEkgZmluZCB0aGUgZGlmZmVyZW5jZSBiZXR3 ZWVuIHRoZW0KPiBidXQgSSBuZWVkIGhlbHAgZm9yIG1vcmUgaW5mb3JtYXRpb24sCj4KPiAgICAg VGhlIG1ham9yIGRpZmZlcmVuY2UgaGFwcGVucyBpbiBieHRfc2FuaXRpemVfY2RjbGsoKSBvbiB0 aGUKPiBmb2xsb3dpbmcgY29uZGl0aW9uIGNoZWNrLgo+ICAgICAgICAgaWYgKGNkY3RsID09IGV4 cGVjdGVkKQo+ICAgICAgICAgICAgICAgICAvKiBBbGwgd2VsbDsgbm90aGluZyB0byBzYW5pdGl6 ZSAqLwo+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4KPiAgICAgT24gdGhlIHByb2JsZW1hdGlj IEFjZXIgbGFwdG9wLCB0aGUgdmFsdWUgb2YgY2RjdGwgaXMgMHgyN2Egd2hpbGUKPiB0aGUgc2Ft ZSBjZGN0bCBpcyAweDI3OCBvbiBBU1VTIG1hY2hpbmUuIER1ZSB0byB0aGUgMHgyN2EgaXMgbm90 IGVxdWFsCj4gdG8gdGhlIGV4cGVjdGVkIHZhbHVlIDB4Mjc4IHNvIGl0IG5lZWRzIHRvIGJlIHNh bml0aXplZCBieSBhc3NpZ25pbmcKPiAtMSB0byAgZGV2X3ByaXYtPmNkY2xrLmh3LnZjby4gVGhl biB0aGUgY29uc2VxdWVudCBieHRfc2V0X2NkY2xrKCkKPiB3aWxsIGZvcmNlIHRoZSBmdWxsIFBM TCBkaXNhYmxlIGFuZCBlbmFibGUuIEFuZCB0aGF0J3MgdGhlIGZsaWNrZXIKPiAoYmxpbmspIHdl IG9ic2VydmVkIGR1cmluZyBib290Lgo+Cj4gICAgIEFsdGhvdWdoIEkgY2FuJ3QgZmluZCB0aGUg ZGVmaW5pdGlvbiBhYm91dCB0aGUgQklUKDIpIG9mIENEQ0xLX0NUTAo+IHdoaWNoIGNhdXNlIHRo aXMgZGlmZmVyZW5jZS4gQ2FuIGFueW9uZSBzdWdnZXN0IHdoYXQgZXhhY3RseSB0aGUKPiBwcm9i bGVtIGlzIGFuZCBob3cgc2hvdWxkIHdlIGRlYWwgd2l0aCBpdD8gVGhhbmtzLgoKVGhlIDExIGxl YXN0IHNpZ25pZmljYW50IGJpdHMgb2YgdGhhdCByZWdpc3RlciBhcmUgdGhlIGNkY2xrIGZyZXF1 ZW5jeQppbiAxMC4xIGZpeGVkIHBvaW50IGZvcm1hdC4gQXBwYXJlbnRseSB0aGUgQWNlciBCSU9T IG9yIEdPUCBoYXMgYQpkaWZmZXJlbnQgaWRlYSBvZiBob3cgdG8gY2FsY3VsYXRlIHRoZSB2YWx1 ZSBmcm9tIHdoYXQgaTkxNSBhbmQgdGhlIEFzdXMKdGhpbmsuCgpUbyBoYW5kbGUgdGhpcyBpbiBp OTE1LCB3ZSdkIG5lZWQgdG8gYWxsb3cgc29tZSBkZXZpYXRpb24gZnJvbSB0aGUKZXhwZWN0ZWQg dmFsdWUsIGFuZCBvbmx5IHN3aXRjaCB0byB1c2Ugb3VyIHZhbHVlIGF0IHRoZSBuZXh0IG1vZGVz ZXQuIFdlCmRvIG5lZWQgdGhlIHNhbml0aXphdGlvbiB0aG91Z2gsIGJlY2F1c2Ugc29tZXRpbWVz IHRoZXJlIGhhdmUgYmVlbgpjb21wbGV0ZWx5IGJvZ3VzIHZhbHVlcyB0byBiZWdpbiB3aXRoLgoK UGxlYXNlIGZpbGUgYSBidWcgb3ZlciBhdCBbMV0gYW5kIHJlZmVyZW5jZSB0aGlzIHRocmVhZC4K CkJSLApKYW5pLgoKClsxXSBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL2VudGVyX2J1Zy5j Z2k/cHJvZHVjdD1EUkkmY29tcG9uZW50PURSTS9JbnRlbAoKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CC6CA9EC7 for ; Wed, 30 Oct 2019 13:07:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAC2320874 for ; Wed, 30 Oct 2019 13:07:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAC2320874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 553346E9CE; Wed, 30 Oct 2019 13:07:45 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A8D76E9CE; Wed, 30 Oct 2019 13:07:43 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:07:43 -0700 X-IronPort-AV: E=Sophos;i="5.68,247,1569308400"; d="scan'208";a="193962381" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 06:07:39 -0700 From: Jani Nikula To: Chris Chiu , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 30 Oct 2019 15:07:34 +0200 Message-ID: <87o8xy8jqh.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] Unexpected screen flicker during i915 initialization X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191030130734.4NrY0H8sHiI3RAawJsWam5_GBEQ42QVYmAaPtDlAmu0@z> T24gV2VkLCAzMCBPY3QgMjAxOSwgQ2hyaXMgQ2hpdSA8Y2hpdUBlbmRsZXNzbS5jb20+IHdyb3Rl Ogo+IEhpIGd1eXMsCj4gICAgIFdlIGhhdmUgMiBsYXB0b3BzLCBBU1VTIFo0MDZNQSBhbmQgQWNl ciBUcmF2ZWxNYXRlIEIxMTgsIGJvdGgKPiBwb3dlcmVkIGJ5IHRoZSBzYW1lIEludGVsIE41MDAw IEdlbW5pTGFrZSBDUFUuIE9uIHRoZSBBY2VyIGxhcHRvcCwgdGhlCj4gcGFuZWwgd2lsbCBibGlu ayBvbmNlIGR1cmluZyBib290IHdoaWNoIG5ldmVyIGhhcHBlbnMgb24gdGhlIEFTVVMKPiBsYXB0 b3AuIEl0IGNhdWdodCBteSBhdHRlbnRpb24gYW5kIEkgZmluZCB0aGUgZGlmZmVyZW5jZSBiZXR3 ZWVuIHRoZW0KPiBidXQgSSBuZWVkIGhlbHAgZm9yIG1vcmUgaW5mb3JtYXRpb24sCj4KPiAgICAg VGhlIG1ham9yIGRpZmZlcmVuY2UgaGFwcGVucyBpbiBieHRfc2FuaXRpemVfY2RjbGsoKSBvbiB0 aGUKPiBmb2xsb3dpbmcgY29uZGl0aW9uIGNoZWNrLgo+ICAgICAgICAgaWYgKGNkY3RsID09IGV4 cGVjdGVkKQo+ICAgICAgICAgICAgICAgICAvKiBBbGwgd2VsbDsgbm90aGluZyB0byBzYW5pdGl6 ZSAqLwo+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4KPiAgICAgT24gdGhlIHByb2JsZW1hdGlj IEFjZXIgbGFwdG9wLCB0aGUgdmFsdWUgb2YgY2RjdGwgaXMgMHgyN2Egd2hpbGUKPiB0aGUgc2Ft ZSBjZGN0bCBpcyAweDI3OCBvbiBBU1VTIG1hY2hpbmUuIER1ZSB0byB0aGUgMHgyN2EgaXMgbm90 IGVxdWFsCj4gdG8gdGhlIGV4cGVjdGVkIHZhbHVlIDB4Mjc4IHNvIGl0IG5lZWRzIHRvIGJlIHNh bml0aXplZCBieSBhc3NpZ25pbmcKPiAtMSB0byAgZGV2X3ByaXYtPmNkY2xrLmh3LnZjby4gVGhl biB0aGUgY29uc2VxdWVudCBieHRfc2V0X2NkY2xrKCkKPiB3aWxsIGZvcmNlIHRoZSBmdWxsIFBM TCBkaXNhYmxlIGFuZCBlbmFibGUuIEFuZCB0aGF0J3MgdGhlIGZsaWNrZXIKPiAoYmxpbmspIHdl IG9ic2VydmVkIGR1cmluZyBib290Lgo+Cj4gICAgIEFsdGhvdWdoIEkgY2FuJ3QgZmluZCB0aGUg ZGVmaW5pdGlvbiBhYm91dCB0aGUgQklUKDIpIG9mIENEQ0xLX0NUTAo+IHdoaWNoIGNhdXNlIHRo aXMgZGlmZmVyZW5jZS4gQ2FuIGFueW9uZSBzdWdnZXN0IHdoYXQgZXhhY3RseSB0aGUKPiBwcm9i bGVtIGlzIGFuZCBob3cgc2hvdWxkIHdlIGRlYWwgd2l0aCBpdD8gVGhhbmtzLgoKVGhlIDExIGxl YXN0IHNpZ25pZmljYW50IGJpdHMgb2YgdGhhdCByZWdpc3RlciBhcmUgdGhlIGNkY2xrIGZyZXF1 ZW5jeQppbiAxMC4xIGZpeGVkIHBvaW50IGZvcm1hdC4gQXBwYXJlbnRseSB0aGUgQWNlciBCSU9T IG9yIEdPUCBoYXMgYQpkaWZmZXJlbnQgaWRlYSBvZiBob3cgdG8gY2FsY3VsYXRlIHRoZSB2YWx1 ZSBmcm9tIHdoYXQgaTkxNSBhbmQgdGhlIEFzdXMKdGhpbmsuCgpUbyBoYW5kbGUgdGhpcyBpbiBp OTE1LCB3ZSdkIG5lZWQgdG8gYWxsb3cgc29tZSBkZXZpYXRpb24gZnJvbSB0aGUKZXhwZWN0ZWQg dmFsdWUsIGFuZCBvbmx5IHN3aXRjaCB0byB1c2Ugb3VyIHZhbHVlIGF0IHRoZSBuZXh0IG1vZGVz ZXQuIFdlCmRvIG5lZWQgdGhlIHNhbml0aXphdGlvbiB0aG91Z2gsIGJlY2F1c2Ugc29tZXRpbWVz IHRoZXJlIGhhdmUgYmVlbgpjb21wbGV0ZWx5IGJvZ3VzIHZhbHVlcyB0byBiZWdpbiB3aXRoLgoK UGxlYXNlIGZpbGUgYSBidWcgb3ZlciBhdCBbMV0gYW5kIHJlZmVyZW5jZSB0aGlzIHRocmVhZC4K CkJSLApKYW5pLgoKClsxXSBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL2VudGVyX2J1Zy5j Z2k/cHJvZHVjdD1EUkkmY29tcG9uZW50PURSTS9JbnRlbAoKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA==