From: Jakub Sitnicki <jakub@cloudflare.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: "bpf\@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-team\@cloudflare.com" <kernel-team@cloudflare.com>
Subject: Re: [PATCH bpf-next] scripts/bpf: Print an error when known types list needs updating
Date: Fri, 18 Oct 2019 11:07:59 +0200 [thread overview]
Message-ID: <87o8yectg0.fsf@cloudflare.com> (raw)
In-Reply-To: <1651dcc4-51a8-dfb2-a4ba-87c61fc0e2b4@fb.com>
On Thu, Oct 17, 2019 at 07:11 PM CEST, Andrii Nakryiko wrote:
> On 10/17/19 2:44 AM, Jakub Sitnicki wrote:
[...]
>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
>> index 75b538577c17..26c202261c5f 100644
>> --- a/tools/lib/bpf/Makefile
>> +++ b/tools/lib/bpf/Makefile
>> @@ -169,7 +169,8 @@ $(BPF_IN): force elfdep bpfdep bpf_helper_defs.h
>>
>> bpf_helper_defs.h: $(srctree)/include/uapi/linux/bpf.h
>> $(Q)$(srctree)/scripts/bpf_helpers_doc.py --header \
>> - --file $(srctree)/include/uapi/linux/bpf.h > bpf_helper_defs.h
>> + --file $(srctree)/include/uapi/linux/bpf.h > $@.tmp
>> + @mv $@.tmp $@
>
> This is unnecessary. Let's add ".DELETE_ON_ERROR:" at the end Makefile
> instead to trigger this auto-deletion of failed targets automatically.
Thanks for the hint. Will respin it.
-Jakub
prev parent reply other threads:[~2019-10-18 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:44 [PATCH bpf-next] scripts/bpf: Print an error when known types list needs updating Jakub Sitnicki
2019-10-17 17:11 ` Andrii Nakryiko
2019-10-18 9:07 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8yectg0.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.