From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Date: Fri, 02 Aug 2019 16:48:19 +0300 Message-ID: <87o917lluk.fsf@intel.com> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> <156346840026.24728.936589728458336617@skylake-alporthouse-com> <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> <87tvb5nh5c.fsf@intel.com> <20190729143555.GA16927@ravnborg.org> <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com> <20190729175011.GA1753@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190729175011.GA1753@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sam Ravnborg , "Koenig, Christian" Cc: Boris Brezillon , Maxime Ripard , Daniel Vetter , Intel Graphics Development , "dri-devel@lists.freedesktop.org" , David Airlie , "linux-mediatek@lists.infradead.org" , Thomas Zimmermann , Matthias Brugger , Sean Paul , Thierry Reding , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org T24gTW9uLCAyOSBKdWwgMjAxOSwgU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPiB3cm90 ZToKPiBIaSBDaHJpc3RpYW4uCj4KPiBPbiBNb24sIEp1bCAyOSwgMjAxOSBhdCAwMzoyODoxNVBN ICswMDAwLCBLb2VuaWcsIENocmlzdGlhbiB3cm90ZToKPj4gQW0gMjkuMDcuMTkgdW0gMTY6MzUg c2NocmllYiBTYW0gUmF2bmJvcmc6Cj4+ID4+Pj4gRXZlbiB0aGVuIGl0IHNvIHVzZWxlc3MgKHdo aWNoIGRybSBkcml2ZXIgaXMgdGhpcyBtZXNzYWdlIGZvcj8/PykgdGhhdCBJCj4+ID4+Pj4gd2Fu dCB0byByZW1vdmUgdGhlbSBhbGwgOigKPj4gPj4+IFllYWgsIGFncmVlLiBJIG1lYW4gaXQgaXMg bmljZSBpZiB0aGUgY29yZSBkcm0gZnVuY3Rpb25zIHVzZSBhIHByZWZpeAo+PiA+Pj4gZm9yIGRl YnVnIG91dHB1dC4KPj4gPj4+Cj4+ID4+PiBCdXQgSSBhY3R1YWxseSBkb24ndCBzZWUgdGhlIHBv aW50IGZvciBpbmRpdmlkdWFsIGRyaXZlcnMuCj4+ID4+IFdlIHNob3VsZCBhbGwgbWlncmF0ZSB0 byB0aGUgdmVyc2lvbnMgd2l0aCBkZXZpY2UuLi4KPj4gPiBKdXN0IHRvIGRvIGFuIHhrZGMuY29t LzkyNyBJIGhhdmUgY29uc2lkZXJlZDoKPj4gPgo+PiA+IGRybV9lcnIoY29uc3Qgc3RydWN0IGRy bV9kZXZpY2UgKmRybSwgLi4uKQo+PiA+IGRybV9pbmZvKGNvbnN0IHN0cnVjdCBkcm1fZGV2aWNl ICpkcm0sIC4uLikKPj4gPgo+PiA+IGRybV9rbXNfZXJyKGNvbnN0IHN0cnVjdCBkcm1fZGV2aWNl ICpkcm0sIC4uLikKPj4gPiBkcm1fa21zX2luZm8oY29uc3Qgc3RydWN0IGRybV9kZXZpY2UgKmRy bSwgLi4uKSkKPj4gCj4+IFdoeSBub3QgZ2V0IGNvbXBsZXRlbHkgcmlkIG9mIHRob3NlIGFuZCBq dXN0IHVzZSBkZXZfZXJyLCBkZXZfd2FybiwgCj4+IHByX2VyciwgcHJfd2FybiBldGM/Cj4+IAo+ PiBJIG1lYW4gaXMgaXQgdXNlZnVsIHRvIGhhdmUgdGhpcyBleHRyYSBwcmludGluZyBzdWJzeXN0 ZW0gaW4gRFJNIHdoaWxlIAo+PiB0aGUgc3RhbmRhcmQgTGludXggb25lIGFjdHVhbGx5IGRvZXMg YSBiZXR0ZXIgam9iPwo+IFRoZSBhZGRlZCBmdW5jdGlvbmFsaXR5IG9mIGRybV94eHhfZXJyIHdv dWxkIGJlIHRvIGtlZXAgdGhlIGN1cnJlbnQKPiBkcm0uZGVidWc9MHgxZiBmaWx0ZXJpbmcgb24g dGhlIGNvbW1hbmQtbGluZS4KPiBJIGRvIG5vdCB0aGluayB3ZSBjYW4gZG8gdGhpcyB3aXRoIHRo ZSBzdGFuZGFyZCBsb2dnaW5nLgoKQ29ycmVjdC4gSSdkIGxvdmUgdGhlIGJlbmVmaXRzIG9mIGR5 bmFtaWMgZGVidWcsIGJ1dCB0aGVyZSdzIG5vIHN1cHBvcnQKZm9yIHRoZSBraW5kIG9mIG1lc3Nh Z2UgY2F0ZWdvcmllcyB0aGF0IHdlIGRvIHdpdGggZHJtLmRlYnVnLgoKSSd2ZSBjb250ZW1wbGF0 ZWQgc3dpdGNoaW5nIGk5MTUgb3ZlciB0byB1c2luZyB0aGUgdmFyaWFudHMgd2hlcmUgeW91CnBh c3MgdGhlIGRldmljZSwgYnV0IEkgcmVhbGx5IHJlYWxseSBkb24ndCBsaWtlIHRoZSBpZGVhIG9m OgoKLSAJRFJNX0RFQlVHX0tNUygiaGVsbG9cbiIpOworIAlEUk1fREVWX0RFQlVHX0tNUyhpOTE1 LT5kcm0uZGV2LCAiaGVsbG9cbiIpOwoKV2hlcmUgaTkxNSBpcyBvdXIgcHJpdmF0ZSB3cmFwcGVy IGZvciBkcm1fZGV2aWNlLiBJIHRoaW5rIGl0J3MganVzdCB0b28KbXVjaCB1Z2x5IHVwcGVyY2Fz ZSBib2lsZXJwbGF0ZSwgYW5kIGEgbGFyZ2UgcG9ydGlvbiBvZiB0aGUgZGVidWdzIHdvdWxkCmhh dmUgdG8gc3BhbiBhdCBsZWFzdCBhbiBleHRyYSBsaW5lIGFmdGVyIHRoYXQuCgpJJ2QgYWxzbyB2 ZXJ5IG11Y2ggcHJlZmVyIHBhc3NpbmcganVzdCBzdHJ1Y3QgKmRybV9kZXZpY2UgaW5zdGVhZCBv ZgpzdHJ1Y3QgKmRldmljZS4gSW4gdGhhdCwgSSB0aGluayB0aGUgbmVlZHMgb2YgdGhlIGZldyBo YXZlIHByZXZhaWxlZApvdmVyIHRoZSBuZWVkcyBvZiB0aGUgbWFueS4gSSdkIGRlZmluaXRlbHkg cHJlZmVyIGRybV9lcnIoY29uc3Qgc3RydWN0CmRybV9kZXZpY2UgKmRybSwgLi4uKSBhbmQgZnJp ZW5kcyBvdmVyIHRoZSBjdXJyZW50IG9uZXMuCgpGcmFua2x5LCBJJ3ZlIGFjdHVhbGx5IGVuZGVk IHVwIHRoaW5raW5nIGFib3V0IGFkZGluZyBvdXIgb3duLCBzaG9ydAppOTE1IHdyYXBwZXJzIGZv ciBvdXIgbmVlZHMuIDooCgpCUiwKSmFuaS4KCgo+Cj4gQW5kIHRoZW4gd2UgY2FuIHByZWZpeCBl dmVyeSBsb2dnaW5nIHdpdGggZHJpdmVyIG5hbWUgYW5kIGRldmljZSBuYW1lLgo+Cj4gVGhlIGlk ZWEgaXMgdG8gbWFrZSBhIHRoaW4gbGF5ZXIgb24gdG9wIG9mIHRoZSBleGlzdGluZyBwcl94eHgo KSBmdW5jdGlvbnMuCj4gU28gbm90IGEgZnVsbCBzdWJzeXN0ZW0sIG9ubHkgYSB3cmFwcGVyIG9u IHRvcCBvZiB3aGF0IHdlIGFscmVhZHkgaGF2ZS4KPgo+IEFueXdheSwgaWRsZSB0YWxrIG9ubHku IFdlIG5lZWQgcGF0Y2hlcyBhbmQgc2FtcGxlIG91dHB1dCBpZiB3ZSBzaG91bGQKPiBkaXNjdXNz IG1vcmUuCj4KPiAJU2FtCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhp Y3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56124C32750 for ; Fri, 2 Aug 2019 13:44:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 294BB21773 for ; Fri, 2 Aug 2019 13:44:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LJroRnNQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 294BB21773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lQA1qWOs64/xL6p+uERbEeI41gQ8N76DpLgqLLH6KWw=; b=LJroRnNQ87CBsN ljJePdHi2OI0hI7Wx1zgzNDcyDbvdnbcnhyFV2Q1izakBndq9uHt9Vpdy73zr4bkstxwqpb0KI4f3 Sx8hlkfHukhSwjR72wrdgfvxj1bLKD4L+Q38PMYOoLn0wpzpigwMu7bG8FV3py8iey6KB+XWVoZZg lBb1lUrcve8rdQkG/xBt7WVYsr45U8T70y9ZRyMtiu0lApaKixBcbMSjet2Bgeq+MsR9UGI4H2S6j o9lkkW1SmVC03Cas3NQkaiE3NxdGlW5FA4jkEhcvPVXC9UDk+H8JIwrPXfHK9dmVXg38P4ulqdLlT t9E1VsBFBJMhDv9Xn5Lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1htXqq-0008N1-NF; Fri, 02 Aug 2019 13:44:08 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1htXqm-0008Lw-Qh; Fri, 02 Aug 2019 13:44:06 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 06:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,338,1559545200"; d="scan'208";a="191853555" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.150]) by fmsmga001.fm.intel.com with ESMTP; 02 Aug 2019 06:43:59 -0700 From: Jani Nikula To: Sam Ravnborg , "Koenig\, Christian" Subject: Re: [Intel-gfx] [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h In-Reply-To: <20190729175011.GA1753@ravnborg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> <156346840026.24728.936589728458336617@skylake-alporthouse-com> <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> <87tvb5nh5c.fsf@intel.com> <20190729143555.GA16927@ravnborg.org> <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com> <20190729175011.GA1753@ravnborg.org> Date: Fri, 02 Aug 2019 16:48:19 +0300 Message-ID: <87o917lluk.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190802_064404_908550_05BFC712 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Maxime Ripard , Daniel Vetter , Intel Graphics Development , "dri-devel@lists.freedesktop.org" , David Airlie , "linux-mediatek@lists.infradead.org" , Thomas Zimmermann , Matthias Brugger , Sean Paul , Thierry Reding , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 29 Jul 2019, Sam Ravnborg wrote: > Hi Christian. > > On Mon, Jul 29, 2019 at 03:28:15PM +0000, Koenig, Christian wrote: >> Am 29.07.19 um 16:35 schrieb Sam Ravnborg: >> >>>> Even then it so useless (which drm driver is this message for???) that I >> >>>> want to remove them all :( >> >>> Yeah, agree. I mean it is nice if the core drm functions use a prefix >> >>> for debug output. >> >>> >> >>> But I actually don't see the point for individual drivers. >> >> We should all migrate to the versions with device... >> > Just to do an xkdc.com/927 I have considered: >> > >> > drm_err(const struct drm_device *drm, ...) >> > drm_info(const struct drm_device *drm, ...) >> > >> > drm_kms_err(const struct drm_device *drm, ...) >> > drm_kms_info(const struct drm_device *drm, ...)) >> >> Why not get completely rid of those and just use dev_err, dev_warn, >> pr_err, pr_warn etc? >> >> I mean is it useful to have this extra printing subsystem in DRM while >> the standard Linux one actually does a better job? > The added functionality of drm_xxx_err would be to keep the current > drm.debug=0x1f filtering on the command-line. > I do not think we can do this with the standard logging. Correct. I'd love the benefits of dynamic debug, but there's no support for the kind of message categories that we do with drm.debug. I've contemplated switching i915 over to using the variants where you pass the device, but I really really don't like the idea of: - DRM_DEBUG_KMS("hello\n"); + DRM_DEV_DEBUG_KMS(i915->drm.dev, "hello\n"); Where i915 is our private wrapper for drm_device. I think it's just too much ugly uppercase boilerplate, and a large portion of the debugs would have to span at least an extra line after that. I'd also very much prefer passing just struct *drm_device instead of struct *device. In that, I think the needs of the few have prevailed over the needs of the many. I'd definitely prefer drm_err(const struct drm_device *drm, ...) and friends over the current ones. Frankly, I've actually ended up thinking about adding our own, short i915 wrappers for our needs. :( BR, Jani. > > And then we can prefix every logging with driver name and device name. > > The idea is to make a thin layer on top of the existing pr_xxx() functions. > So not a full subsystem, only a wrapper on top of what we already have. > > Anyway, idle talk only. We need patches and sample output if we should > discuss more. > > Sam > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel