From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZbqI-0000NE-Fj for ath10k@lists.infradead.org; Wed, 19 Dec 2018 13:24:55 +0000 From: Kalle Valo Subject: Re: [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling References: <1545181331-5288-1-git-send-email-rmanohar@codeaurora.org> <1545181331-5288-6-git-send-email-rmanohar@codeaurora.org> Date: Wed, 19 Dec 2018 15:24:37 +0200 In-Reply-To: <1545181331-5288-6-git-send-email-rmanohar@codeaurora.org> (Rajkumar Manoharan's message of "Tue, 18 Dec 2018 17:02:10 -0800") Message-ID: <87o99hvecq.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan Cc: make-wifi-fast@lists.bufferbloat.net, Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen?= , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org UmFqa3VtYXIgTWFub2hhcmFuIDxybWFub2hhckBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgoKPiBG cm9tOiBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gPHRva2VAdG9rZS5kaz4KPgo+IGF0aDEwayBt YWludGFpbnMgY29tbW9uIHR4cXMgbGlzdCBmb3IgYWxsIHN0YXRpb25zLiBUaGlzIHR4cQo+IG1h bmFnZW1lbnQgY2FuIGJlIHJlbW92ZWQgYnkgbWlncmF0aW5nIHRvIG1hYzgwMjExIHR4cSBBUElz Cj4gYW5kIGxldCBtYWM4MDIxMSBoYW5kbGUgdHhxcyByZW9yZGVyaW5nIGJhc2VkIG9uIHJlcG9y dGVkIGFpcnRpbWUuCj4gQnkgZG9pbmcgdGhpcywgdHhxIGZhaXJuZXNzIG1haW50YWluZWQgaW4g YXRoMTBrIGkuZSBwcm9jZXNzaW5nCj4gTiBmcmFtZXMgcGVyIHR4cSBpcyByZW1vdmVkLiBCeSBh ZGFwdGluZyB0byBtYWM4MDIxMSBBUElzLAo+IGF0aDEwayB3aWxsIHN1cHBvcnQgbWFjODAyMTEg YmFzZWQgYWlydGltZSBmYWlybmVzcyBhbGdvcml0aG0uCj4KPiBUZXN0ZWQtYnk6IFZlbmthdGVz d2FyYSBOYXJhbGFzZXR0eSA8dm5hcmFsYXNAY29kZWF1cm9yYS5vcmc+Cj4gQ28tZGV2ZWxvcGVk LWJ5OiBSYWprdW1hciBNYW5vaGFyYW4gPHJtYW5vaGFyQGNvZGVhdXJvcmEub3JnPgo+IFNpZ25l ZC1vZmYtYnk6IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9rZUB0b2tlLmRrPgo+IFNpZ25l ZC1vZmYtYnk6IFJhamt1bWFyIE1hbm9oYXJhbiA8cm1hbm9oYXJAY29kZWF1cm9yYS5vcmc+CgpQ bGVhc2UgYWx3YXlzIGFkZCBoYXJkd2FyZSBhbmQgZmlybXdhcmUgdmVyc2lvbnMgdXNlZCBmb3Ig dGVzdGluZy4gQnV0IEkKY2FuIGFkZCB0aGF0LCBzbyBubyBuZWVkIHRvIHJlc2VuZCBiZWNhdXNl IG9mIHRoaXMuIEp1c3QgbGV0IG1lIGtub3cKd2hhdCB0byBhZGQuCgotLSAKS2FsbGUgVmFsbwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1h aWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13267C43387 for ; Wed, 19 Dec 2018 13:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D18B420989 for ; Wed, 19 Dec 2018 13:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="WCNJR/e6"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="WCNJR/e6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728707AbeLSNYm (ORCPT ); Wed, 19 Dec 2018 08:24:42 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60650 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728638AbeLSNYm (ORCPT ); Wed, 19 Dec 2018 08:24:42 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DE30C61AF9; Wed, 19 Dec 2018 13:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1545225881; bh=yiIN4fur8lbH+uHQqh2udCBdjKxcORWwHVEUYTrKIpI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WCNJR/e6EGHAZoGk4e6/KcLgLx4GmCs+MLDwJhHy/0ln62/D5VX3LMNVl7y9wGjOc qp0dbJy4BJKY6/AVdV3F97yotYzx6R8dbcuyQiuK5vxAagVgMicfsc5fDvMQ8V7qxQ I5d89yVZBhxCN8+rR2QWciwopp6OVWwq8TiPmbOQ= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CC7CA61AF9; Wed, 19 Dec 2018 13:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1545225881; bh=yiIN4fur8lbH+uHQqh2udCBdjKxcORWwHVEUYTrKIpI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WCNJR/e6EGHAZoGk4e6/KcLgLx4GmCs+MLDwJhHy/0ln62/D5VX3LMNVl7y9wGjOc qp0dbJy4BJKY6/AVdV3F97yotYzx6R8dbcuyQiuK5vxAagVgMicfsc5fDvMQ8V7qxQ I5d89yVZBhxCN8+rR2QWciwopp6OVWwq8TiPmbOQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CC7CA61AF9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Rajkumar Manoharan Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, make-wifi-fast@lists.bufferbloat.net, Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen?= Subject: Re: [PATCH v5 5/6] ath10k: migrate to mac80211 txq scheduling References: <1545181331-5288-1-git-send-email-rmanohar@codeaurora.org> <1545181331-5288-6-git-send-email-rmanohar@codeaurora.org> Date: Wed, 19 Dec 2018 15:24:37 +0200 In-Reply-To: <1545181331-5288-6-git-send-email-rmanohar@codeaurora.org> (Rajkumar Manoharan's message of "Tue, 18 Dec 2018 17:02:10 -0800") Message-ID: <87o99hvecq.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rajkumar Manoharan writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > > ath10k maintains common txqs list for all stations. This txq > management can be removed by migrating to mac80211 txq APIs > and let mac80211 handle txqs reordering based on reported airtime. > By doing this, txq fairness maintained in ath10k i.e processing > N frames per txq is removed. By adapting to mac80211 APIs, > ath10k will support mac80211 based airtime fairness algorithm. > > Tested-by: Venkateswara Naralasetty > Co-developed-by: Rajkumar Manoharan > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > Signed-off-by: Rajkumar Manoharan Please always add hardware and firmware versions used for testing. But I can add that, so no need to resend because of this. Just let me know what to add. --=20 Kalle Valo