Re: [Qemu-devel] [RFC PATCH v2] contrib: add a basic gitdm config

["Alex Bennée" <alex.bennee@linaro.org>]

Markus Armbruster <armbru@redhat.com> writes:

> Alex Bennée <alex.bennee@linaro.org> writes:
>
>> This is a QEMU specific version of a gitdm config for generating
>> reports on the contributor base of the project. I've added enough
>> group maps and domain aliases to ensure the current top ten is as
>> reflective as it can be. As of this commit running:
>>
>>   git log --numstat --since "Last Year" | gitdm -n -l 10
<snip>
>> diff --git a/contrib/gitdm/filetypes.txt b/contrib/gitdm/filetypes.txt
>> new file mode 100644
>> index 0000000000..e24c396b48
>> --- /dev/null
>> +++ b/contrib/gitdm/filetypes.txt
> [...]
>
> This is a verbatim copy of upstream's sample-config/filetypes.txt.  If
> you have gitdm, you should have its filetypes.txt, shouldn't you?  Can
> we think of a way to use that instead?

Without introducing an explicit dependency which seems a little
overkill. That said a lot of the entries in this file aren't used by
QEMU so I could just trim it down.
>> diff --git a/contrib/gitdm/group-map-redhat b/contrib/gitdm/group-map-redhat
>> new file mode 100644
>> index 0000000000..252742d131
>> --- /dev/null
>> +++ b/contrib/gitdm/group-map-redhat
>> @@ -0,0 +1,7 @@
>> +#
>> +# RedHat contributors using non-corporate email
>> +#
>> +
>> +david@gibson.dropbear.id.au
>> +laurent@vivier.eu
>> +pjp@fedoraproject.org
>
> There are about a dozen commits I accidentally signed with my private
> address armbru@pond.sub.org.  Not sure we care.

For running lifetime stats maybe - it certainly won't hurt.

I really only concentrated of cleaning up the stats for the last year.
>
> Can't see anything bad, so
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks.

--
Alex Bennée