From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, Li Zhijian <lizhijian@cn.fujitsu.com>,
Jason Wang <jasowang@redhat.com>,
Zhang Chen <zhangckid@gmail.com>,
peterx@redhat.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 v4 3/7] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag
Date: Thu, 06 Dec 2018 06:45:18 +0100 [thread overview]
Message-ID: <87o99zky35.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181205203737.9011-4-marcandre.lureau@redhat.com> ("Marc-André Lureau"'s message of "Thu, 6 Dec 2018 00:37:33 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> QEMU_CHAR_FEATURE_GCONTEXT declares the character device can switch
> GMainContext.
>
> Assert we don't switch context when the character device doesn't
> provide this feature. Character device users must not violate this
> restriction. In particular, user configurations that violate them
> must be rejected.
>
> Existing frontend that rely on context switching would now assert() if
> the backend doesn't allow it (instead of silently producing undesired
> events in the default context). Following patches improve the
> situation by reporting an error earlier instead, on the frontend side.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2018-12-06 5:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 20:37 [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 1/7] monitor: inline ambiguous helper functions Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 2/7] monitor: accept chardev input from iothread Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 3/7] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag Marc-André Lureau
2018-12-06 5:45 ` Markus Armbruster [this message]
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB Marc-André Lureau
2018-12-06 5:46 ` Markus Armbruster
2018-12-06 6:08 ` Markus Armbruster
2018-12-06 6:23 ` Marc-André Lureau
2018-12-06 9:13 ` Markus Armbruster
2018-12-06 9:24 ` Marc-André Lureau
2018-12-06 9:38 ` Markus Armbruster
2018-12-06 9:55 ` Marc-André Lureau
2018-12-06 12:58 ` Markus Armbruster
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context Marc-André Lureau
2018-12-06 5:48 ` Markus Armbruster
2018-12-06 5:56 ` Li Zhijian
2018-12-06 6:23 ` Zhang Chen
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 6/7] monitor: prevent inserting new monitors after cleanup Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 7/7] monitor: avoid potential dead-lock when cleaning up Marc-André Lureau
2018-12-06 13:08 ` [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o99zky35.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.