Re: [PATCH] Revert "arm64: dts: marvell: add CPU Idle power state support on Armada 7K/8K"

From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
	Sergey Matyukevich <geomatsi@gmail.com>,
	linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	orenbh <orenbh@marvell.com>, Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] Revert "arm64: dts: marvell: add CPU Idle power state support on Armada 7K/8K"
Date: Tue, 04 Dec 2018 17:21:25 +0100	[thread overview]
Message-ID: <87o9a1w9dm.fsf@bootlin.com> (raw)
In-Reply-To: <3ece60154be74bd6534387db8da578194f823b43.1543938362.git.baruch@tkos.co.il> (Baruch Siach's message of "Tue, 4 Dec 2018 17:46:02 +0200")

Hi Baruch and Sergey,

 On mar., déc. 04 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> This reverts commit 8ed46368776b3bc93d74c1f8f2bfb9fd8a9ad805.
>
> This commit breaks boot on Armada 8K based systems. Reverting it makes
> affected systems boot again.
>
> Reported-by: Sergey Matyukevich <geomatsi@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

I would like to know more about it because on the McBin I use there is
no issue with 4.20-rc1.

Do you observe this issue with the arm64 defconfig or do you have some
specific configuration option?

Thanks,

Gregory

> ---
>  .../boot/dts/marvell/armada-ap806-quad.dtsi   |  4 ---
>  arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 27 -------------------
>  2 files changed, 31 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi
> index 64632c873888..01ea662afba8 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap806-quad.dtsi
> @@ -20,28 +20,24 @@
>  			compatible = "arm,cortex-a72", "arm,armv8";
>  			reg = <0x000>;
>  			enable-method = "psci";
> -			cpu-idle-states = <&CPU_SLEEP_0>;
>  		};
>  		cpu1: cpu@1 {
>  			device_type = "cpu";
>  			compatible = "arm,cortex-a72", "arm,armv8";
>  			reg = <0x001>;
>  			enable-method = "psci";
> -			cpu-idle-states = <&CPU_SLEEP_0>;
>  		};
>  		cpu2: cpu@100 {
>  			device_type = "cpu";
>  			compatible = "arm,cortex-a72", "arm,armv8";
>  			reg = <0x100>;
>  			enable-method = "psci";
> -			cpu-idle-states = <&CPU_SLEEP_0>;
>  		};
>  		cpu3: cpu@101 {
>  			device_type = "cpu";
>  			compatible = "arm,cortex-a72", "arm,armv8";
>  			reg = <0x101>;
>  			enable-method = "psci";
> -			cpu-idle-states = <&CPU_SLEEP_0>;
>  		};
>  	};
>  };
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> index 073610ac0a53..7d94c1fa592a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> @@ -28,33 +28,6 @@
>  		method = "smc";
>  	};
>  
> -	cpus {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		idle_states {
> -			entry_method = "arm,pcsi";
> -
> -			CPU_SLEEP_0: cpu-sleep-0 {
> -				compatible = "arm,idle-state";
> -				local-timer-stop;
> -				arm,psci-suspend-param = <0x0010000>;
> -				entry-latency-us = <80>;
> -				exit-latency-us  = <160>;
> -				min-residency-us = <320>;
> -			};
> -
> -			CLUSTER_SLEEP_0: cluster-sleep-0 {
> -				compatible = "arm,idle-state";
> -				local-timer-stop;
> -				arm,psci-suspend-param = <0x1010000>;
> -				entry-latency-us = <500>;
> -				exit-latency-us = <1000>;
> -				min-residency-us = <2500>;
> -			};
> -		};
> -	};
> -
>  	ap806 {
>  		#address-cells = <2>;
>  		#size-cells = <2>;
> -- 
> 2.19.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel