All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: add reason to SHUTDOWN and RESET events
Date: Fri, 30 Nov 2018 10:43:19 +0100	[thread overview]
Message-ID: <87o9a6lx3c.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181031115242.6558-4-d.csapak@proxmox.com> (Dominik Csapak's message of "Wed, 31 Oct 2018 12:52:42 +0100")

Dominik Csapak <d.csapak@proxmox.com> writes:

> this makes it possible to determine what the exact reason was for
> a RESET or a SHUTDOWN

Yes, but why is that useful?  I can guess, but the commit shouldn't make
me guess.

Please start your sentences with a capital letter and end them with
punctuation.

> this patch also fixes the iotests

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

  reply	other threads:[~2018-11-30  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 11:52 [Qemu-devel] [PATCH 0/3] qapi: return ShutdownCause for events Dominik Csapak
2018-10-31 11:52 ` [Qemu-devel] [PATCH 1/3] qapi: move ShutdownCause to qapi/run-state.json Dominik Csapak
2018-11-30  9:00   ` Markus Armbruster
2018-11-30  9:15     ` Markus Armbruster
2018-10-31 11:52 ` [Qemu-devel] [PATCH 2/3] qapi: split host-qmp into quit and system-reset Dominik Csapak
2018-11-30  9:41   ` Markus Armbruster
2018-11-30 13:20     ` Dominik Csapak
2018-11-30 13:55       ` Eric Blake
2018-10-31 11:52 ` [Qemu-devel] [PATCH 3/3] qapi: add reason to SHUTDOWN and RESET events Dominik Csapak
2018-11-30  9:43   ` Markus Armbruster [this message]
2018-11-19 13:45 ` [Qemu-devel] [PATCH 0/3] qapi: return ShutdownCause for events Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9a6lx3c.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=d.csapak@proxmox.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.