From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: core: Clean up ULPI device From: Felipe Balbi Message-Id: <87o9bbeeoy.fsf@linux.intel.com> Date: Tue, 30 Oct 2018 15:39:41 +0200 To: Linux USB Cc: Andy Shevchenko , stable@vger.kernel.org List-ID: SGksCgpGZWxpcGUgQmFsYmkgPGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5jb20+IHdyaXRlczoK PiBGcm9tOiBBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNv bT4KPgo+IElmIGR3YzNfY29yZV9pbml0X21vZGUoKSBmYWlscyB3aXRoIGRlZmVycmVkIHByb2Jl LAo+IG5leHQgcHJvYmUgZmFpbHMgb24gc3lzZnMgd2l0aAo+Cj4gc3lzZnM6IGNhbm5vdCBjcmVh dGUgZHVwbGljYXRlIGZpbGVuYW1lICcvZGV2aWNlcy9wY2kwMDAwOjAwLzAwMDA6MDA6MTEuMC9k d2MzLjAuYXV0by9kd2MzLjAuYXV0by51bHBpJwo+Cj4gVG8gYXZvaWQgdGhpcyBmYWlsdXJlLCBj bGVhbiB1cCBVTFBJIGRldmljZS4KPgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiBT aWduZWQtb2ZmLWJ5OiBBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4Lmlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBGZWxpcGUgQmFsYmkgPGZlbGlwZS5iYWxiaUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvdXNiL2R3YzMvY29yZS5jIHwgMSArCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L2R3YzMvY29yZS5jIGIvZHJpdmVycy91c2IvZHdjMy9jb3JlLmMKPiBpbmRleCA4OGM4MGZjYzM5 ZjUuLmZlYzk3NDY1Y2NhYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9kd2MzL2NvcmUuYwo+ ICsrKyBiL2RyaXZlcnMvdXNiL2R3YzMvY29yZS5jCj4gQEAgLTE0OTksNiArMTQ5OSw3IEBAIHN0 YXRpYyBpbnQgZHdjM19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAKPiAg ZXJyNToKPiAgCWR3YzNfZXZlbnRfYnVmZmVyc19jbGVhbnVwKGR3Yyk7Cj4gKwlkd2MzX3VscGlf ZXhpdChkd2MpOwo+ICAKPiAgZXJyNDoKPiAgCWR3YzNfZnJlZV9zY3JhdGNoX2J1ZmZlcnMoZHdj KTsKPiAtLSAKPiAyLjE5LjEKPgo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IEludGVsIEZpbmxhbmQgT3kKPiBS ZWdpc3RlcmVkIEFkZHJlc3M6IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCj4gQnVzaW5lc3MgSWRl bnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCj4gRG9taWNpbGVkIGluIEhlbHNpbmtpIAo+Cj4gVGhp cyBlLW1haWwgYW5kIGFueSBhdHRhY2htZW50cyBtYXkgY29udGFpbiBjb25maWRlbnRpYWwgbWF0 ZXJpYWwgZm9yCj4gdGhlIHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFu eSByZXZpZXcgb3IgZGlzdHJpYnV0aW9uCj4gYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0 ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZAo+IHJlY2lwaWVudCwgcGxlYXNlIGNvbnRh Y3QgdGhlIHNlbmRlciBhbmQgZGVsZXRlIGFsbCBjb3BpZXMuCgphcmdoLCBhcG9sb2dpZXMgZm9y IHRoaXMgZm9vdGVyLiBNYWlsIHNlcnZlciBoYWQgY2hhbmdlcyByZWNlbnRseS4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:56464 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727759AbeJ3WdT (ORCPT ); Tue, 30 Oct 2018 18:33:19 -0400 From: Felipe Balbi To: Linux USB Cc: Andy Shevchenko , stable@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: core: Clean up ULPI device In-Reply-To: <20181030131950.15422-1-felipe.balbi@linux.intel.com> References: <20181030131950.15422-1-felipe.balbi@linux.intel.com> Date: Tue, 30 Oct 2018 15:39:41 +0200 Message-ID: <87o9bbeeoy.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Felipe Balbi writes: > From: Andy Shevchenko > > If dwc3_core_init_mode() fails with deferred probe, > next probe fails on sysfs with > > sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0= /dwc3.0.auto/dwc3.0.auto.ulpi' > > To avoid this failure, clean up ULPI device. > > Cc: > Signed-off-by: Andy Shevchenko > Signed-off-by: Felipe Balbi > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 88c80fcc39f5..fec97465ccac 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1499,6 +1499,7 @@ static int dwc3_probe(struct platform_device *pdev) >=20=20 > err5: > dwc3_event_buffers_cleanup(dwc); > + dwc3_ulpi_exit(dwc); >=20=20 > err4: > dwc3_free_scratch_buffers(dwc); > --=20 > 2.19.1 > > --------------------------------------------------------------------- > Intel Finland Oy > Registered Address: PL 281, 00181 Helsinki=20 > Business Identity Code: 0357606 - 4=20 > Domiciled in Helsinki=20 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. argh, apologies for this footer. Mail server had changes recently. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlvYXx0ACgkQzL64meEa mQZpSA//RsFBBX56T7RaXNSzEIh1ckCQ5sFJD+1+3otUMV0hYL8+JgrxvkCcB7Xo juwUkrptBJzGoFwaC1U0LE5yXbqpwYGK+XsO50GX8WPzLyYGDzPKR1lyHmyCqQgx CRBFGHRlbeShVvDSdzZ++GO8kgo6JawVHbc0Oy6zJ63ZyyqArnm8JdxDUAb/ijKB mmsBB2mLHMIYmQVW1DxAwagcoAbgRhjb/5jmyUDb5Ra0fnwgEAZp6FpBGcMUeOSy W1m33wz/xZVqkYuqlsbKmGHB4wtDm7FemrURtdv6bhoW7nstP0x2VZdrX4msBl6a +75qswaZIrqMlMryZQtG1IJQ5vhqUyq5/o4jGhEyeIHitaAo+2MT/6/4mXQzzCHW NGw4g2zAwN2fX07rj5mWhIgVLrXHVa6WMTSQJ6de0pjKoJxkF3iSbBrNkhTd7kit DuJODVil2q+oGnENIkzKxxSRrANaFqdEHWG4EulHr2harNSMZNkdDZatx3r7Ef1n j7F/G+bWN2weWvb0PJrZJU1C9mKJS4FycmYhuI3N0w4SF+ZdUQHDqII/YFsSIHYd FcWykdOx5WsVOICIXkpsQ2shDud29XDBrP9Zq3Z+WbU1mCRhodhh65jm20xj5Hkp yVRDFsLTiiZENKsNqjHSWmCHMIAWkc7zkZr1AElJw7RMcXU8xSg= =kY3l -----END PGP SIGNATURE----- --=-=-=--