From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Pull seqno started checks together
Date: Tue, 07 Aug 2018 12:09:48 +0300 [thread overview]
Message-ID: <87o9eeee5f.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180806112605.20725-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> We have a few instances of checking seqno-1 to see if the HW has started
> the request. Pull those together under a helper.
>
> v2: Pull the !seqno assertion higher, as we given seqno==1 we may indeed
> check to see if we have started using seqno==0.
>
> Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
He is very quiet. But for me too it all reads better.
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-08-07 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 11:11 [PATCH] drm/i915: Pull seqno started checks together Chris Wilson
2018-08-06 11:17 ` Mika Kuoppala
2018-08-06 11:24 ` Chris Wilson
2018-08-06 11:26 ` Chris Wilson
2018-08-07 9:09 ` Mika Kuoppala [this message]
2018-08-07 11:47 ` Chris Wilson
2018-08-06 12:49 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Pull seqno started checks together (rev2) Patchwork
2018-08-06 13:05 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-06 15:18 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9eeee5f.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.