From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc
Date: Mon, 16 Jul 2018 19:56:00 +0200
Message-ID: <87o9f75akv.fsf@toke.dk>
References: <20180716163926.4826-1-toke@toke.dk> <20180716100646.788fc9c0@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:55557 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727957AbeGPSYl (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 16 Jul 2018 14:24:41 -0400
In-Reply-To: <20180716100646.788fc9c0@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Stephen Hemminger <stephen@networkplumber.org> writes:

> On Mon, 16 Jul 2018 18:39:26 +0200
> Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
>
>> +#define PRINT_TSTAT(name, attr, fmts, val)	do {		\
>> +			if (GET_TSTAT(0, attr)) {		\
>> +				fprintf(f, name);		\
>> +				for (i =3D 0; i < num_tins; i++)	\
>> +					fprintf(f, " %12" fmts,	val);	\
>> +				fprintf(f, "\n");			\
>> +			}						\
>> +		} while (0)
>
> Couldn't this be a function?

Guess so? But keeping it as a macro keeps it closer to where it is
defined, and keeps the macro definitions together. IMO this is more
readable than splitting things up...

-Toke