Re: [PATCH 1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 20 Jun 2018, José Roberto de Souza <jose.souza@intel.com> wrote:

Please add a commit message, always.

Please make the subject prefix just "drm/i915/fbc" because cnl is
misleading there.

BR,
Jani.

> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_fbc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index b431b6733cc1..eb0f95390968 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -714,7 +714,10 @@ static bool intel_fbc_hw_tracking_covers_screen(struct intel_crtc *crtc)
>  	struct intel_fbc *fbc = &dev_priv->fbc;
>  	unsigned int effective_w, effective_h, max_w, max_h;
>  
> -	if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) {
> +	if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) {
> +		max_w = 5120;
> +		max_h = 4096;
> +	} else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) {
>  		max_w = 4096;
>  		max_h = 4096;
>  	} else if (IS_G4X(dev_priv) || INTEL_GEN(dev_priv) >= 5) {

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx