From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Date: Wed, 30 May 2018 15:29:31 +0300 Subject: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency In-Reply-To: <20180525160729.92026-1-arnd@arndb.de> References: <20180525160729.92026-1-arnd@arndb.de> Message-ID: <87o9gxcono.fsf@linux.intel.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Arnd Bergmann writes: > Without that option, we run into a link failure: > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' > > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency From: Felipe Balbi Message-Id: <87o9gxcono.fsf@linux.intel.com> Date: Wed, 30 May 2018 15:29:31 +0300 To: Arnd Bergmann , Greg Kroah-Hartman Cc: Joel Stanley , Andrew Jeffery , Benjamin Herrenschmidt , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org List-ID: SGksCgpBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPiB3cml0ZXM6Cj4gV2l0aG91dCB0aGF0 IG9wdGlvbiwgd2UgcnVuIGludG8gYSBsaW5rIGZhaWx1cmU6Cj4KPiBkcml2ZXJzL3VzYi9nYWRn ZXQvdWRjL2FzcGVlZC12aHViL2h1Yi5vOiBJbiBmdW5jdGlvbiBgYXN0X3ZodWJfc3RkX2h1Yl9y ZXF1ZXN0JzoKPiBodWIuYzooLnRleHQrMHg1YjApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGB1 c2JfZ2FkZ2V0X2dldF9zdHJpbmcnCj4KPiBGaXhlczogN2VjY2EyYTQwODBjICgidXNiL2dhZGdl dDogQWRkIGRyaXZlciBmb3IgQXNwZWVkIFNvQyB2aXJ0dWFsIGh1YiIpCj4gU2lnbmVkLW9mZi1i eTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KCkFja2VkLWJ5OiBGZWxpcGUgQmFsYmkg PGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5jb20+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@kernel.org (Felipe Balbi) Date: Wed, 30 May 2018 15:29:31 +0300 Subject: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency In-Reply-To: <20180525160729.92026-1-arnd@arndb.de> References: <20180525160729.92026-1-arnd@arndb.de> Message-ID: <87o9gxcono.fsf@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Arnd Bergmann writes: > Without that option, we run into a link failure: > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' > > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbeE3Mbb (ORCPT ); Wed, 30 May 2018 08:31:31 -0400 Received: from mga12.intel.com ([192.55.52.136]:10929 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbeE3Mba (ORCPT ); Wed, 30 May 2018 08:31:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,460,1520924400"; d="asc'?scan'208";a="45916173" From: Felipe Balbi To: Arnd Bergmann , Greg Kroah-Hartman Cc: Arnd Bergmann , Joel Stanley , Andrew Jeffery , Benjamin Herrenschmidt , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency In-Reply-To: <20180525160729.92026-1-arnd@arndb.de> References: <20180525160729.92026-1-arnd@arndb.de> Date: Wed, 30 May 2018 15:29:31 +0300 Message-ID: <87o9gxcono.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Arnd Bergmann writes: > Without that option, we run into a link failure: > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_r= equest': > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' > > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlsOmSsACgkQzL64meEa mQYpww//bW0hiy5g1A740zHe4YOPu2u2iAT6MnYfmvEBKgqd0klf2HA28+Sn3+se zc6flrbIEQjUUGZY72fz8/sAl6JjjLX2O3GAV68UIy/YgXD4LNSels6Q8J+ybjFS 1xH6g/25c+jIqj2KGbEHY9rpU8GiEQPWJyuUPDQXBA2ye2VHaJmJsVG7/WyHaZbk F3wVKtSUMkRjqdTgmcsiaGbu08EdnaYLUB+CKP2671ICOs5s3iEcS+F7RBze8b31 Sq+XY80wybHWUmEiLzd6efzLlyWNFY4Z5JLFbVdgGEiTnPCJMCD3QSbYKIKkp6HE qijCOs/4VU3TdM/32qrbErmqZrM+82mstZ8TIhEjkQaG2yGeslB379+En6E8APNk uDTCRORyLzsLihdfxGPmlAo/ou9UIKJmid6V5L4hEGixfranxRwsQbbvXLoju88w GKpVcTjjRNh9Iiu5y5J2gFikontlXGgRRigKXmgDNH7s4sOrpfOmmucKMMU5PbS5 8se5ZWH0gtUVA6Lx19hPbn0rCPCBQUV8MmWwbIc6VTuyyHNSArmsudQMUd2AJrA2 nAg5yJ37cHlsnb0T4CZsNiudLUoSmONJ4fa2t+Ba6DDT9ViR3pRGtb6xdfXPpdpK 6b4TsX86/P4bhcrGLa7QPNraYId60VgnX/sZ/GXkmy2la2nItus= =skhR -----END PGP SIGNATURE----- --=-=-=--