From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v10 03/18] arm64: Use update{,_tsk}_thread_flag() Date: Wed, 23 May 2018 14:48:56 +0100 Message-ID: <87o9h6trcn.fsf@linaro.org> References: <1527005119-6842-1-git-send-email-Dave.Martin@arm.com> <1527005119-6842-4-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1527005119-6842-4-git-send-email-Dave.Martin@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dave Martin Cc: Christoffer Dall , Ard Biesheuvel , Marc Zyngier , Catalin Marinas , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu CkRhdmUgTWFydGluIDxEYXZlLk1hcnRpbkBhcm0uY29tPiB3cml0ZXM6Cgo+IFRoaXMgcGF0Y2gg dXNlcyB0aGUgbmV3IHVwZGF0ZV90aHJlYWRfZmxhZygpIGhlbHBlcnMgdG8gc2ltcGxpZnkgYQo+ IGNvdXBsZSBvZiBpZiAoKSBzZXQ7IGVsc2UgY2xlYXI7IGNvbnN0cnVjdHMuCj4KPiBObyBmdW5j dGlvbmFsIGNoYW5nZS4KPgo+IFNpZ25lZC1vZmYtYnk6IERhdmUgTWFydGluIDxEYXZlLk1hcnRp bkBhcm0uY29tPgo+IEFja2VkLWJ5OiBNYXJjIFp5bmdpZXIgPG1hcmMuenluZ2llckBhcm0uY29t Pgo+IEFja2VkLWJ5OiBDYXRhbGluIE1hcmluYXMgPGNhdGFsaW4ubWFyaW5hc0Bhcm0uY29tPgo+ IENjOiBXaWxsIERlYWNvbiA8d2lsbC5kZWFjb25AYXJtLmNvbT4KClJldmlld2VkLWJ5OiBBbGV4 IEJlbm7DqWUgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+Cgo+IC0tLQo+ICBhcmNoL2FybTY0L2tl cm5lbC9mcHNpbWQuYyB8IDE4ICsrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg OCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2tlcm5lbC9mcHNpbWQuYyBiL2FyY2gvYXJtNjQva2VybmVsL2Zwc2ltZC5jCj4gaW5kZXgg MTJlMWM5Ni4uOWQ4NTM3MyAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2tlcm5lbC9mcHNpbWQu Ywo+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL2Zwc2ltZC5jCj4gQEAgLTYxOCwxMCArNjE4LDgg QEAgaW50IHN2ZV9zZXRfdmVjdG9yX2xlbmd0aChzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRhc2ssCj4g IAl0YXNrLT50aHJlYWQuc3ZlX3ZsID0gdmw7Cj4KPiAgb3V0Ogo+IC0JaWYgKGZsYWdzICYgUFJf U1ZFX1ZMX0lOSEVSSVQpCj4gLQkJc2V0X3Rza190aHJlYWRfZmxhZyh0YXNrLCBUSUZfU1ZFX1ZM X0lOSEVSSVQpOwo+IC0JZWxzZQo+IC0JCWNsZWFyX3Rza190aHJlYWRfZmxhZyh0YXNrLCBUSUZf U1ZFX1ZMX0lOSEVSSVQpOwo+ICsJdXBkYXRlX3Rza190aHJlYWRfZmxhZyh0YXNrLCBUSUZfU1ZF X1ZMX0lOSEVSSVQsCj4gKwkJCSAgICAgICBmbGFncyAmIFBSX1NWRV9WTF9JTkhFUklUKTsKPgo+ ICAJcmV0dXJuIDA7Cj4gIH0KPiBAQCAtOTEwLDEyICs5MDgsMTIgQEAgdm9pZCBmcHNpbWRfdGhy ZWFkX3N3aXRjaChzdHJ1Y3QgdGFza19zdHJ1Y3QgKm5leHQpCj4gIAkJICogdGhlIFRJRl9GT1JF SUdOX0ZQU1RBVEUgZmxhZyBzbyB0aGUgc3RhdGUgd2lsbCBiZSBsb2FkZWQKPiAgCQkgKiB1cG9u IHRoZSBuZXh0IHJldHVybiB0byB1c2VybGFuZC4KPiAgCQkgKi8KPiAtCQlpZiAoX190aGlzX2Nw dV9yZWFkKGZwc2ltZF9sYXN0X3N0YXRlLnN0KSA9PQo+IC0JCQkmbmV4dC0+dGhyZWFkLnV3LmZw c2ltZF9zdGF0ZQo+IC0JCSAgICAmJiBuZXh0LT50aHJlYWQuZnBzaW1kX2NwdSA9PSBzbXBfcHJv Y2Vzc29yX2lkKCkpCj4gLQkJCWNsZWFyX3Rza190aHJlYWRfZmxhZyhuZXh0LCBUSUZfRk9SRUlH Tl9GUFNUQVRFKTsKPiAtCQllbHNlCj4gLQkJCXNldF90c2tfdGhyZWFkX2ZsYWcobmV4dCwgVElG X0ZPUkVJR05fRlBTVEFURSk7Cj4gKwkJYm9vbCB3cm9uZ190YXNrID0gX190aGlzX2NwdV9yZWFk KGZwc2ltZF9sYXN0X3N0YXRlLnN0KSAhPQo+ICsJCQkJCSZuZXh0LT50aHJlYWQudXcuZnBzaW1k X3N0YXRlOwo+ICsJCWJvb2wgd3JvbmdfY3B1ID0gbmV4dC0+dGhyZWFkLmZwc2ltZF9jcHUgIT0g c21wX3Byb2Nlc3Nvcl9pZCgpOwo+ICsKPiArCQl1cGRhdGVfdHNrX3RocmVhZF9mbGFnKG5leHQs IFRJRl9GT1JFSUdOX0ZQU1RBVEUsCj4gKwkJCQkgICAgICAgd3JvbmdfdGFzayB8fCB3cm9uZ19j cHUpOwo+ICAJfQo+ICB9CgoKLS0KQWxleCBCZW5uw6llCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Wed, 23 May 2018 14:48:56 +0100 Subject: [PATCH v10 03/18] arm64: Use update{,_tsk}_thread_flag() In-Reply-To: <1527005119-6842-4-git-send-email-Dave.Martin@arm.com> References: <1527005119-6842-1-git-send-email-Dave.Martin@arm.com> <1527005119-6842-4-git-send-email-Dave.Martin@arm.com> Message-ID: <87o9h6trcn.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dave Martin writes: > This patch uses the new update_thread_flag() helpers to simplify a > couple of if () set; else clear; constructs. > > No functional change. > > Signed-off-by: Dave Martin > Acked-by: Marc Zyngier > Acked-by: Catalin Marinas > Cc: Will Deacon Reviewed-by: Alex Benn?e > --- > arch/arm64/kernel/fpsimd.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index 12e1c96..9d85373 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -618,10 +618,8 @@ int sve_set_vector_length(struct task_struct *task, > task->thread.sve_vl = vl; > > out: > - if (flags & PR_SVE_VL_INHERIT) > - set_tsk_thread_flag(task, TIF_SVE_VL_INHERIT); > - else > - clear_tsk_thread_flag(task, TIF_SVE_VL_INHERIT); > + update_tsk_thread_flag(task, TIF_SVE_VL_INHERIT, > + flags & PR_SVE_VL_INHERIT); > > return 0; > } > @@ -910,12 +908,12 @@ void fpsimd_thread_switch(struct task_struct *next) > * the TIF_FOREIGN_FPSTATE flag so the state will be loaded > * upon the next return to userland. > */ > - if (__this_cpu_read(fpsimd_last_state.st) == > - &next->thread.uw.fpsimd_state > - && next->thread.fpsimd_cpu == smp_processor_id()) > - clear_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE); > - else > - set_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE); > + bool wrong_task = __this_cpu_read(fpsimd_last_state.st) != > + &next->thread.uw.fpsimd_state; > + bool wrong_cpu = next->thread.fpsimd_cpu != smp_processor_id(); > + > + update_tsk_thread_flag(next, TIF_FOREIGN_FPSTATE, > + wrong_task || wrong_cpu); > } > } -- Alex Benn?e