From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/5] drm/i915: Check for IVB instead of gen7 when we think about IVB CPU eDP Date: Thu, 17 May 2018 20:45:36 +0300 Message-ID: <87o9he41mn.fsf@intel.com> References: <20180517170309.28630-1-ville.syrjala@linux.intel.com> <20180517170309.28630-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BF496EAF3 for ; Thu, 17 May 2018 17:45:39 +0000 (UTC) In-Reply-To: <20180517170309.28630-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNyBNYXkgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBBbG1vc3QgYWxsIG9mIHRoZSBHRU43IGNoZWNrcyBpbiB0aGUg RFAgY29kZSBhcmUgYWN0dWFsbHkgbG9va2luZyBmb3IKPiBJVkIuIEhTVyBkb2Vzbid0IGV2ZW4g dGFrZSB0aGVzZSBjb2RlcGF0aHMsIGFuZCBWTFYgaXMgZXhjbHVkZWQgb24KPiBhY2NvdW50IG9m IG5vdCBoYXZpbmcgcG9ydCBBLiBTbyBsZXQncyBjaGFuZ2UgdGhlIGNoZWNrcyB0byBJU19JVkIg dG8KPiBtYWtlIHRoZSBjb2RlIGxlc3MgY29uZnVzaW5nLgo+Cj4gUmV2aWV3ZWQtYnk6IEphbmkg TmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+CgpZdXAuCgo+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAxNCArKysrKysrLS0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gaW5kZXggNTM4YjEwMDg0YTlkLi4yNjNlNGIxZDFkYjkgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMTk4OSw3ICsxOTg5LDcgQEAgc3RhdGljIHZvaWQg aW50ZWxfZHBfcHJlcGFyZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCj4gIAkv KiBTcGxpdCBvdXQgdGhlIElCWC9DUFUgdnMgQ1BUIHNldHRpbmdzICovCj4gIAo+IC0JaWYgKElT X0dFTjcoZGV2X3ByaXYpICYmIHBvcnQgPT0gUE9SVF9BKSB7Cj4gKwlpZiAoSVNfSVZZQlJJREdF KGRldl9wcml2KSAmJiBwb3J0ID09IFBPUlRfQSkgewo+ICAJCWlmIChhZGp1c3RlZF9tb2RlLT5m bGFncyAmIERSTV9NT0RFX0ZMQUdfUEhTWU5DKQo+ICAJCQlpbnRlbF9kcC0+RFAgfD0gRFBfU1lO Q19IU19ISUdIOwo+ICAJCWlmIChhZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdf UFZTWU5DKQo+IEBAIC0yNjY5LDcgKzI2NjksNyBAQCBzdGF0aWMgYm9vbCBpbnRlbF9kcF9nZXRf aHdfc3RhdGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlpZiAoISh0bXAgJiBE UF9QT1JUX0VOKSkKPiAgCQlnb3RvIG91dDsKPiAgCj4gLQlpZiAoSVNfR0VONyhkZXZfcHJpdikg JiYgcG9ydCA9PSBQT1JUX0EpIHsKPiArCWlmIChJU19JVllCUklER0UoZGV2X3ByaXYpICYmIHBv cnQgPT0gUE9SVF9BKSB7Cj4gIAkJKnBpcGUgPSBQT1JUX1RPX1BJUEVfQ1BUKHRtcCk7Cj4gIAl9 IGVsc2UgaWYgKEhBU19QQ0hfQ1BUKGRldl9wcml2KSAmJiBwb3J0ICE9IFBPUlRfQSkgewo+ICAJ CWVudW0gcGlwZSBwOwo+IEBAIC0yOTA4LDcgKzI5MDgsNyBAQCBfaW50ZWxfZHBfc2V0X2xpbmtf dHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAgCQl9Cj4gIAkJSTkxNV9XUklURShE UF9UUF9DVEwocG9ydCksIHRlbXApOwo+ICAKPiAtCX0gZWxzZSBpZiAoKElTX0dFTjcoZGV2X3By aXYpICYmIHBvcnQgPT0gUE9SVF9BKSB8fAo+ICsJfSBlbHNlIGlmICgoSVNfSVZZQlJJREdFKGRl dl9wcml2KSAmJiBwb3J0ID09IFBPUlRfQSkgfHwKPiAgCQkgICAoSEFTX1BDSF9DUFQoZGV2X3By aXYpICYmIHBvcnQgIT0gUE9SVF9BKSkgewo+ICAJCSpEUCAmPSB+RFBfTElOS19UUkFJTl9NQVNL X0NQVDsKPiAgCj4gQEAgLTMyMjcsNyArMzIyNyw3IEBAIGludGVsX2RwX3ZvbHRhZ2VfbWF4KHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkJcmV0dXJuIGludGVsX2RkaV9kcF92b2x0YWdl X21heChlbmNvZGVyKTsKPiAgCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElT X0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ICAJCXJldHVybiBEUF9UUkFJTl9WT0xUQUdFX1NXSU5H X0xFVkVMXzM7Cj4gLQllbHNlIGlmIChJU19HRU43KGRldl9wcml2KSAmJiBwb3J0ID09IFBPUlRf QSkKPiArCWVsc2UgaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikgJiYgcG9ydCA9PSBQT1JUX0Ep Cj4gIAkJcmV0dXJuIERQX1RSQUlOX1ZPTFRBR0VfU1dJTkdfTEVWRUxfMjsKPiAgCWVsc2UgaWYg KEhBU19QQ0hfQ1BUKGRldl9wcml2KSAmJiBwb3J0ICE9IFBPUlRfQSkKPiAgCQlyZXR1cm4gRFBf VFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8zOwo+IEBAIC0zMjU2LDcgKzMyNTYsNyBAQCBpbnRl bF9kcF9wcmVfZW1waGFzaXNfbWF4KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHVpbnQ4X3Qg dm9sdGFnZV9zd2luZykKPiAgCQlkZWZhdWx0Ogo+ICAJCQlyZXR1cm4gRFBfVFJBSU5fUFJFX0VN UEhfTEVWRUxfMDsKPiAgCQl9Cj4gLQl9IGVsc2UgaWYgKElTX0dFTjcoZGV2X3ByaXYpICYmIHBv cnQgPT0gUE9SVF9BKSB7Cj4gKwl9IGVsc2UgaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikgJiYg cG9ydCA9PSBQT1JUX0EpIHsKPiAgCQlzd2l0Y2ggKHZvbHRhZ2Vfc3dpbmcgJiBEUF9UUkFJTl9W T0xUQUdFX1NXSU5HX01BU0spIHsKPiAgCQljYXNlIERQX1RSQUlOX1ZPTFRBR0VfU1dJTkdfTEVW RUxfMDoKPiAgCQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBIX0xFVkVMXzI7Cj4gQEAgLTM1NjUs NyArMzU2NSw3IEBAIGludGVsX2RwX3NldF9zaWduYWxfbGV2ZWxzKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHApCj4gIAkJc2lnbmFsX2xldmVscyA9IGNodl9zaWduYWxfbGV2ZWxzKGludGVsX2Rw KTsKPiAgCX0gZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikpIHsKPiAgCQlzaWduYWxf bGV2ZWxzID0gdmx2X3NpZ25hbF9sZXZlbHMoaW50ZWxfZHApOwo+IC0JfSBlbHNlIGlmIChJU19H RU43KGRldl9wcml2KSAmJiBwb3J0ID09IFBPUlRfQSkgewo+ICsJfSBlbHNlIGlmIChJU19JVllC UklER0UoZGV2X3ByaXYpICYmIHBvcnQgPT0gUE9SVF9BKSB7Cj4gIAkJc2lnbmFsX2xldmVscyA9 IGdlbjdfZWRwX3NpZ25hbF9sZXZlbHModHJhaW5fc2V0KTsKPiAgCQltYXNrID0gRURQX0xJTktf VFJBSU5fVk9MX0VNUF9NQVNLX0lWQjsKPiAgCX0gZWxzZSBpZiAoSVNfR0VONihkZXZfcHJpdikg JiYgcG9ydCA9PSBQT1JUX0EpIHsKPiBAQCAtMzY1NSw3ICszNjU1LDcgQEAgaW50ZWxfZHBfbGlu a19kb3duKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAKPiAgCURSTV9ERUJVR19L TVMoIlxuIik7Cj4gIAo+IC0JaWYgKChJU19HRU43KGRldl9wcml2KSAmJiBwb3J0ID09IFBPUlRf QSkgfHwKPiArCWlmICgoSVNfSVZZQlJJREdFKGRldl9wcml2KSAmJiBwb3J0ID09IFBPUlRfQSkg fHwKPiAgCSAgICAoSEFTX1BDSF9DUFQoZGV2X3ByaXYpICYmIHBvcnQgIT0gUE9SVF9BKSkgewo+ ICAJCURQICY9IH5EUF9MSU5LX1RSQUlOX01BU0tfQ1BUOwo+ICAJCURQIHw9IERQX0xJTktfVFJB SU5fUEFUX0lETEVfQ1BUOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw aGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==