From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/atomic: Add sanity checks to drm_atomic_helper_async_commit() Date: Fri, 30 Mar 2018 11:39:05 -0700 Message-ID: <87o9j5jtme.fsf@anholt.net> References: <20180330145518.29770-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1768316418==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CBC86E0FD for ; Fri, 30 Mar 2018 18:42:26 +0000 (UTC) In-Reply-To: <20180330145518.29770-1-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Boris Brezillon List-Id: dri-devel@lists.freedesktop.org --===============1768316418== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Boris Brezillon writes: > ->atomic_async_update() requires that drivers update the plane->state > object before returning. Make sure at least common properties have been > updated. > > Cc: Gustavo Padovan > Signed-off-by: Boris Brezillon > --- > Hello, > > This is a problem I had when debugging the VC4 ->atomic_async_update() > implementation. The function was not updating plane->fb as it's > supposed thus leaving plane->state->fb in an inconsistent state after > each async update. > > Not sure if such WARN_ON_ONCE() are accepted in the core though, so > I'll maintainers decide whether this is relevant or not and whether > they prefer to have WARN_ON() or DRM_ERROR() messages. I'm a huge fan of this kind of safety check. FWIW, Acked-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlq+hEkACgkQtdYpNtH8 nuirlg/+MAZN8LBXhxssIUTw+IWlbK2BbLFuvKKrQCaa6sRrAkQIhjEAZcO286II CZG3Q3UKH80/gehTeNWbtiD9HjwH8j25RjgrdDoxL8csPSxAQZrbB4uPLBvSAiWn FvP/XPIYUqSCgjd58Bjqe+MTEaXSmHVYpFD0X70IrkbY7V7VbYEuHx9VOvaaDqQE maNBAsGIFhxe/Chc7TEM5CPCuUivZgSLQnERzlEl3qInX3WcfSAPMryuQwBIWiHI +l4FjY3d1zkEk5KgFQSzMeFiq0Nx/oA04TJMCxCYXwCf7wg/gsXfs7lBg8Zas3mD 8qp/QlXduWbDd4TyLu99lkPbTgFxVx70XJaO6Th7Qd9DVtRSuEpxXYh5xWxwKpD8 irO/aNI6MWm0MmLCnzEMklDHCoiYy6Lw56T/9XnOccJv7/Qw7I1L2XQcx8RpuEqV FXb7cdG6VJwk41uIVZtH2wkWoTZKM0kYadt6Vp5jEQzO3oEvz+ZURJ8cOeRaeptH boPCja15GWXMKuhmdhC32WXe2lFpsSb9O66aQ1OJo5ogywXVLUvn4YzxEc1n3fpo /OyYfv2XsF6sBjhbcsQFncIKolT6FZJQYNvQ8HWmPlMwW3Gy6OHcjDX/vQdUQv4e emtkILVtuniA2OaXs/QpW8DPFp8Zt5H863062D7dO2AydvZl5U8= =SeIX -----END PGP SIGNATURE----- --=-=-=-- --===============1768316418== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1768316418==--