From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Check rq->timeline before deference Date: Wed, 14 Mar 2018 16:16:08 +0200 Message-ID: <87o9jqn3o7.fsf@gaia.fi.intel.com> References: <20180314101630.8933-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A255C6E229 for ; Wed, 14 Mar 2018 14:22:27 +0000 (UTC) In-Reply-To: <20180314101630.8933-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gTm90IG9u bHkgaXMgdGhlIGNvbnRleHQgc3VzcGVjdCB0byBkaXNhcHBlYXJpbmcsIGJ1dCBzbyBpcyBpdCdz Cj4gdGltZWxpbmUuIFVuZGVyIGEgbG9ja2xlc3MgaW5zcGVjdGlvbiBvZiB0aGUgcmVxdWVzdHMg Zm9yCj4gZGVidWdnaW5nIGZyb20gaW50ZWxfZW5naW5lX2R1bXAoKSwgdGhlIGNvbnRleHQgbWF5 IGFscmVhZHkgaGF2ZSBiZWVuCj4gZnJlZWQgYW5kIHdlIGhhdmUgdG8gY2hlY2sgYmVmb3JlIGNo YXNpbmcgdGhlIGRhbmdsaW5nIHBvaW50ZXIuCj4KPiBbMjgwMzMuNjgxNzU1XSBNb2R1bGVzIGxp bmtlZCBpbjogdmdlbSBzbmRfaGRhX2NvZGVjX2hkbWkgc25kX2hkYV9jb2RlY19yZWFsdGVrIHNu ZF9oZGFfY29kZWNfZ2VuZXJpYyB4ODZfcGtnX3RlbXBfdGhlcm1hbCBpbnRlbF9wb3dlcmNsYW1w IGNvcmV0ZW1wIHNuZF9oZGFfaW50ZWwgY3JjdDEwZGlmX3BjbG11bCBjcmMzMl9wY2xtdWwgc25k X2hkYV9jb2RlYyBzbmRfaHdkZXAgc25kX2hkYV9jb3JlIGdoYXNoX2NsbXVsbmlfaW50ZWwgc25k X3BjbSBtZWlfbWUgbWVpIGk5MTUgcjgxNjkgbWlpIHByaW1lX251bWJlcnMgaTJjX2hpZAo+IFsy ODAzMy42ODE3OTZdIENQVTogMyBQSUQ6IDMwNTggQ29tbTogZ2VtX2V4ZWNfc2NoZWR1IFRhaW50 ZWQ6IEcgICAgIFUgICAgICAgICAgIDQuMTYuMC1yYzUrICM5Cj4gWzI4MDMzLjY4MTgwNF0gSGFy ZHdhcmUgbmFtZTogQWNlciBBc3BpcmUgRTUtNTc1Ry9Jcm9ubWFuX1NLICAsIEJJT1MgVjEuMTIg MDgvMDIvMjAxNgo+IFsyODAzMy42ODE4MzRdIFJJUDogMDAxMDpwcmludF9yZXF1ZXN0KzB4MmIv MHhiMCBbaTkxNV0KPiBbMjgwMzMuNjgxODQwXSBSU1A6IDAwMTg6ZmZmZmM5MDAwNGFmYmMxOCBF RkxBR1M6IDAwMDEwMjAyCj4gWzI4MDMzLjY4MTg0N10gUkFYOiA2YjZiNmI2YjZiNmI2YjZiIFJC WDogZmZmZjg4MDE5MjFiNWE0MCBSQ1g6IDAwMDAwMDAwMDAwMDAwMDYKPiBbMjgwMzMuNjgxODU0 XSBSRFg6IGZmZmZjOTAwMDRhZmJjNjAgUlNJOiBmZmZmODgwMTkyMWI1YTQwIFJESTogMDAwMDAw MDAwMDAwMDAwNAo+IFsyODAzMy42ODE4NjFdIFJCUDogZmZmZmM5MDAwNGFmYmQ4MCBSMDg6IDAw MDAwMDAwMDAwMDAwMDAgUjA5OiAwMDAwMDAwMDAwMDAwMDAxCj4gWzI4MDMzLjY4MTg2OF0gUjEw OiBmZmZmYzkwMDA0YWZiYmQwIFIxMTogZmZmZmM5MDAwNGFmYmM3MyBSMTI6IGZmZmZjOTAwMDRh ZmJjNjAKPiBbMjgwMzMuNjgxODc1XSBSMTM6IGZmZmZjOTAwMDRhZmJkODAgUjE0OiBmZmZmODgw MWQ0MGVjNjcwIFIxNTogZmZmZjg4MDE5MjFiNWE0MAo+IFsyODAzMy42ODE4ODNdIEZTOiAgMDAw MDdmYmJhNWY2YzhjMCgwMDAwKSBHUzpmZmZmODgwMWU4NDAwMDAwKDAwMDApIGtubEdTOjAwMDAw MDAwMDAwMDAwMDAKPiBbMjgwMzMuNjgxODkxXSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAg Q1IwOiAwMDAwMDAwMDgwMDUwMDMzCj4gWzI4MDMzLjY4MTg5N10gQ1IyOiAwMDAwN2ZiYmE1Zjhm MDAwIENSMzogMDAwMDAwMDFiMmVmYTAwMiBDUjQ6IDAwMDAwMDAwMDAzNjA2ZTAKPiBbMjgwMzMu NjgxOTA0XSBDYWxsIFRyYWNlOgo+IFsyODAzMy42ODE5MzJdICBpbnRlbF9lbmdpbmVfcHJpbnRf cmVnaXN0ZXJzKzB4NmE3LzB4OTMwIFtpOTE1XQo+IFsyODAzMy42ODE5NjJdICBpbnRlbF9lbmdp bmVfZHVtcCsweDMwZC8weDc0MCBbaTkxNV0KPiBbMjgwMzMuNjgxOTcxXSAgPyBzZXFfcHJpbnRm KzB4M2EvMHg1MAo+IFsyODAzMy42ODE5OTVdICBpOTE1X2VuZ2luZV9pbmZvKzB4YjgvMHhlMCBb aTkxNV0KPiBbMjgwMzMuNjgyMDAzXSAgPyBkcm1fZ2V0X2NvbG9yX3JhbmdlX25hbWUrMHgyMC8w eDIwCj4gWzI4MDMzLjY4MjAxMF0gIHNlcV9yZWFkKzB4ZTEvMHg0NDAKPiBbMjgwMzMuNjgyMDE4 XSAgZnVsbF9wcm94eV9yZWFkKzB4NTEvMHg4MAo+IFsyODAzMy42ODIwMjVdICBfX3Zmc19yZWFk KzB4MjEvMHgxMzAKPiBbMjgwMzMuNjgyMDMxXSAgPyBkb19zeXNfb3BlbisweDEzNC8weDIyMAo+ IFsyODAzMy42ODIwMzddICA/IGttZW1fY2FjaGVfZnJlZSsweDE3Ny8weDJiMAo+IFsyODAzMy42 ODIwNDNdICB2ZnNfcmVhZCsweGExLzB4MTUwCj4gWzI4MDMzLjY4MjA0OV0gIFN5U19yZWFkKzB4 NDAvMHhhMAo+IFsyODAzMy42ODIwNTVdICBkb19zeXNjYWxsXzY0KzB4NmIvMHgxYjAKPiBbMjgw MzMuNjgyMDYzXSAgZW50cnlfU1lTQ0FMTF82NF9hZnRlcl9od2ZyYW1lKzB4NDIvMHhiNwo+IFsy ODAzMy42ODIwNjldIFJJUDogMDAzMzoweDdmYmJhNDY1NWQxMQo+IFsyODAzMy42ODIwNzRdIFJT UDogMDAyYjowMDAwN2ZmZDhjNDlkYTU4IEVGTEFHUzogMDAwMDAyNDYgT1JJR19SQVg6IDAwMDAw MDAwMDAwMDAwMDAKPiBbMjgwMzMuNjgyMDgyXSBSQVg6IGZmZmZmZmZmZmZmZmZmZGEgUkJYOiAw MDAwMDAwMDAwMDAwMDAwIFJDWDogMDAwMDdmYmJhNDY1NWQxMQo+IFsyODAzMy42ODIwODldIFJE WDogMDAwMDAwMDAwMDAwMDAzZiBSU0k6IDAwMDA1NjQ3YmZiZmMyNjAgUkRJOiAwMDAwMDAwMDAw MDAwMDA2Cj4gWzI4MDMzLjY4MjA5Nl0gUkJQOiAwMDAwMDAwMDAwMDAwMDNmIFIwODogMDAwMDAw MDBmZmZmZmZmZiBSMDk6IDAwMDAwMDAwMDAwMDAwMDAKPiBbMjgwMzMuNjgyMTA0XSBSMTA6IDAw MDAwMDAwMDAwMDAwMDAgUjExOiAwMDAwMDAwMDAwMDAwMjQ2IFIxMjogMDAwMDU2NDdiZmJmYzI2 MAo+IFsyODAzMy42ODIxMTFdIFIxMzogMDAwMDAwMDAwMDAwMDAwNiBSMTQ6IDAwMDAwMDAwMDAw MDAwMDAgUjE1OiAwMDAwNTY0N2JmYmZjMjYwCj4gWzI4MDMzLjY4MjExOV0gQ29kZTogNDEgNTUg NDEgNTQgNDkgODkgZDQgNTUgNTMgNDggODkgZmQgNDggOGIgODYgYzggMDAgMDAgMDAgNDggOGIg M2QgZDYgMWUgMTQgZTIgNDggODkgZjMgNDggMmIgYmUgYTggMDIgMDAgMDAgNDggOGIgODAgYjAg MDAgMDAgMDAgPDRjPiA4YiA2OCAxOCBlOCBiYyA4MCAwMiBlMSA4YiA4YiA3MCAwMiAwMCAwMCA4 YiBiMyAyOCAwMiAwMCAwMAo+IFsyODAzMy42ODIyMDZdIFJJUDogcHJpbnRfcmVxdWVzdCsweDJi LzB4YjAgW2k5MTVdIFJTUDogZmZmZmM5MDAwNGFmYmMxOAo+Cj4gUmVwb3J0ZWQtYnk6IE1pa2Eg S3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWthIEt1b3Bw YWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgfCA0ICsrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZW5naW5lX2NzLmMKPiBpbmRleCBhMmIxZTllMmMwMDguLmYyMmM1ZjcyZGY4ZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gQEAgLTE3MTYsMTMgKzE3MTYsMTUg QEAgc3RhdGljIHZvaWQgcHJpbnRfcmVxdWVzdChzdHJ1Y3QgZHJtX3ByaW50ZXIgKm0sCj4gIAkJ CSAgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4gIAkJCSAgY29uc3QgY2hhciAqcHJlZml4KQo+ ICB7Cj4gKwljb25zdCBjaGFyICpuYW1lID0gcnEtPmZlbmNlLm9wcy0+Z2V0X3RpbWVsaW5lX25h bWUoJnJxLT5mZW5jZSk7Cj4gKwoKU28gd2UgZ2V0ICJzaWduYWxlZCIKClJldmlld2VkLWJ5OiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gIAlkcm1fcHJp bnRmKG0sICIlcyV4JXMgWyVsbHg6JXhdIHByaW89JWQgQCAlZG1zOiAlc1xuIiwgcHJlZml4LAo+ ICAJCSAgIHJxLT5nbG9iYWxfc2Vxbm8sCj4gIAkJICAgaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChy cSkgPyAiISIgOiAiIiwKPiAgCQkgICBycS0+ZmVuY2UuY29udGV4dCwgcnEtPmZlbmNlLnNlcW5v LAo+ICAJCSAgIHJxLT5wcmlvdHJlZS5wcmlvcml0eSwKPiAgCQkgICBqaWZmaWVzX3RvX21zZWNz KGppZmZpZXMgLSBycS0+ZW1pdHRlZF9qaWZmaWVzKSwKPiAtCQkgICBycS0+dGltZWxpbmUtPmNv bW1vbi0+bmFtZSk7Cj4gKwkJICAgbmFtZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGhleGR1 bXAoc3RydWN0IGRybV9wcmludGVyICptLCBjb25zdCB2b2lkICpidWYsIHNpemVfdCBsZW4pCj4g LS0gCj4gMi4xNi4yCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=