From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Suspend submission tasklets around wedging Date: Fri, 02 Mar 2018 15:39:18 +0200 Message-ID: <87o9k6ppfd.fsf@gaia.fi.intel.com> References: <20180302113324.23189-1-chris@chris-wilson.co.uk> <20180302113324.23189-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AAEF89009 for ; Fri, 2 Mar 2018 13:43:54 +0000 (UTC) In-Reply-To: <20180302113324.23189-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQWZ0ZXIg c3RhcnRpbmcgaGFyZCBhdCBzZXF1ZW5jZXMgbGlrZQo+Cj4gWyAgIDI4LjE5OTAxM10gIHN5c3Rl bWQtMSAgICAgICAyLi5zLiAyNjA2MjIyOHVzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xl dDogcmNzMCBjcy1pcnEgaGVhZD0wIFswP10sIHRhaWw9MSBbMT9dCj4gWyAgIDI4LjE5OTA5NV0g IHN5c3RlbWQtMSAgICAgICAyLi5zLiAyNjA2MjIyOXVzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25f dGFza2xldDogcmNzMCBjc2JbMV06IHN0YXR1cz0weDAwMDAwMDE4OjB4MDAwMDAwMDAsIGFjdGl2 ZT0weDEKPiBbICAgMjguMTk5MTc3XSAgc3lzdGVtZC0xICAgICAgIDIuLnMuIDI2MDYyMjMwdXMg OiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIG91dFswXTogY3R4PTAuMSwgc2Vx bm89MywgcHJpbz0tMTAyNAo+IFsgICAyOC4xOTkyNThdICBzeXN0ZW1kLTEgICAgICAgMi4ucy4g MjYwNjIyMzF1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgY29tcGxldGVk IGN0eD0wCj4gWyAgIDI4LjE5OTM0MF0gIGdlbV9laW8tODI5ICAgICAxLi5zMSAyNjA2Njg1M3Vz IDogZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMCBpblswXTogIGN0eD0xLjEsIHNl cW5vPTEsIHByaW89MAo+IFsgICAyOC4xOTk0MjFdICAgPGlkbGU+LTAgICAgICAgMi4ucy4gMjYw NjY4NjN1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgY3MtaXJxIGhlYWQ9 MSBbMT9dLCB0YWlsPTIgWzI/XQo+IFsgICAyOC4xOTk1MDNdICAgPGlkbGU+LTAgICAgICAgMi4u cy4gMjYwNjY4NjV1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgY3NiWzJd OiBzdGF0dXM9MHgwMDAwMDAwMToweDAwMDAwMDAwLCBhY3RpdmU9MHgxCj4gWyAgIDI4LjE5OTU4 NV0gIGdlbV9laW8tODI5ICAgICAxLi5zMSAyNjA2NzA3N3VzIDogZXhlY2xpc3RzX3N1Ym1pc3Np b25fdGFza2xldDogcmNzMCBpblsxXTogIGN0eD0zLjEsIHNlcW5vPTIsIHByaW89MAo+IFsgICAy OC4xOTk2NjddICBnZW1fZWlvLTgyOSAgICAgMS4uczEgMjYwNjcwNzh1cyA6IGV4ZWNsaXN0c19z dWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgaW5bMF06ICBjdHg9MS4yLCBzZXFubz0xLCBwcmlvPTAK PiBbICAgMjguMTk5NzQ5XSAgIDxpZGxlPi0wICAgICAgIDIuLnMuIDI2MDY3MDg0dXMgOiBleGVj bGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGNzLWlycSBoZWFkPTIgWzI/XSwgdGFpbD0z IFszP10KPiBbICAgMjguMTk5ODMwXSAgIDxpZGxlPi0wICAgICAgIDIuLnMuIDI2MDY3MDg1dXMg OiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGNzYlszXTogc3RhdHVzPTB4MDAw MDgwMDI6MHgwMDAwMDAwMSwgYWN0aXZlPTB4MQo+IFsgICAyOC4xOTk5MTJdICAgPGlkbGU+LTAg ICAgICAgMi4ucy4gMjYwNjcwODZ1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJj czAgb3V0WzBdOiBjdHg9MS4yLCBzZXFubz0xLCBwcmlvPTAKPiBbICAgMjguMTk5OTk0XSAgZ2Vt X2Vpby04MjkgICAgIDIuLnMuIDI4MjQ2MDg0dXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNr bGV0OiByY3MwIGNzLWlycSBoZWFkPTMgWzM/XSwgdGFpbD00IFs0P10KPiBbICAgMjguMjAwMDk2 XSAgZ2VtX2Vpby04MjkgICAgIDIuLnMuIDI4MjQ2MDg4dXMgOiBleGVjbGlzdHNfc3VibWlzc2lv bl90YXNrbGV0OiByY3MwIGNzYls0XTogc3RhdHVzPTB4MDAwMDAwMTQ6MHgwMDAwMDAwMSwgYWN0 aXZlPTB4NQo+IFsgICAyOC4yMDAxNzhdICBnZW1fZWlvLTgyOSAgICAgMi4ucy4gMjgyNDYwODl1 cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgb3V0WzBdOiBjdHg9MC4wLCBz ZXFubz0wLCBwcmlvPTAKPiBbICAgMjguMjAwMjYwXSAgZ2VtX2Vpby04MjkgICAgIDIuLnMuIDI4 MjQ2MTI3dXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiBleGVjbGlzdHNfc3VibWlz c2lvbl90YXNrbGV0Ojg4NiBHRU1fQlVHX09OKGJ1ZlsyICogaGVhZCArIDFdICE9IHBvcnQtPmNv bnRleHRfaWQpCj4KPiB0aGUgY29uY2x1c2lvbiBpcyB0aGF0IHRoZSBvbmx5IHBsYWNlIHdoZXJl IHRoZSBwb3J0cyBhcmUgcmVzZXQgdG8gemVybywKPiBpcyBmcm9tIGVuZ2luZS0+Y2FuY2VsX3Jl cXVlc3RzIGNhbGxlZCBkdXJpbmcgaTkxNV9nZW1fc2V0X3dlZGdlZCgpLgo+Cj4gVGhlIHJhY2Ug aXMgaG9ycmlibGUgYXMgaXQgcmVzdWx0cyBmcm9tIGNhbGxpbmcgc2V0LXdlZGdlZCBvbiBhY3Rp dmUgSFcKPiAodGhlIEdQVSByZXNldCBmYWlsZWQpIGFuZCBhcyBzdWNoIHdlIG5lZWQgdG8gYmUg Y2FyZWZ1bCBhcyB0aGUgSFcgc3RhdGUKPiBjaGFuZ2VzIGJlbmVhdGggdXMuIEZvcnR1bmF0ZWx5 LCBpdCdzIHRoZSBzYW1lIHNjYXJ5IGNvbmRpdGlvbnMgYXMKPiBhZmZlY3Qgbm9ybWFsIHJlc2V0 LCBzbyB3ZSBjYW4gcmV1c2UgdGhlIHNhbWUgbWFjaGluZXJ5IHRvIGRpc2FibGUgc3RhdGUKPiB0 cmFja2luZyBhcyB3ZSBjbG9iYmVyIGl0Lgo+Cj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVl ZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDk0NQo+IFNpZ25lZC1vZmYtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWthIEt1b3BwYWxhIDxt aWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hl bC50aGllcnJ5QGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyAgfCA2ICsrKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyB8IDUg KysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBjMjliMWExY2JlOTYuLmRjZGNjMDky NDBiOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0zMjEyLDggKzMyMTIsMTAg QEAgdm9pZCBpOTE1X2dlbV9zZXRfd2VkZ2VkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1 KQo+ICAJICogcm9sbGluZyB0aGUgZ2xvYmFsIHNlcW5vIGZvcndhcmQgKHNpbmNlIHRoaXMgd291 bGQgY29tcGxldGUgcmVxdWVzdHMKPiAgCSAqIGZvciB3aGljaCB3ZSBoYXZlbid0IHNldCB0aGUg ZmVuY2UgZXJyb3IgdG8gRUlPIHlldCkuCj4gIAkgKi8KPiAtCWZvcl9lYWNoX2VuZ2luZShlbmdp bmUsIGk5MTUsIGlkKQo+ICsJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgaTkxNSwgaWQpIHsKPiAr CQlpOTE1X2dlbV9yZXNldF9wcmVwYXJlX2VuZ2luZShlbmdpbmUpOwo+ICAJCWVuZ2luZS0+c3Vi bWl0X3JlcXVlc3QgPSBub3Bfc3VibWl0X3JlcXVlc3Q7Cj4gKwl9Cj4gIAo+ICAJLyoKPiAgCSAq IE1ha2Ugc3VyZSBubyBvbmUgaXMgcnVubmluZyB0aGUgb2xkIGNhbGxiYWNrIGJlZm9yZSB3ZSBw cm9jZWVkIHdpdGgKPiBAQCAtMzI1NSw2ICszMjU3LDggQEAgdm9pZCBpOTE1X2dlbV9zZXRfd2Vk Z2VkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJCWludGVsX2VuZ2luZV9pbml0 X2dsb2JhbF9zZXFubyhlbmdpbmUsCj4gIAkJCQkJICAgICAgIGludGVsX2VuZ2luZV9sYXN0X3N1 Ym1pdChlbmdpbmUpKTsKPiAgCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVs aW5lLT5sb2NrLCBmbGFncyk7Cj4gKwo+ICsJCWk5MTVfZ2VtX3Jlc2V0X2ZpbmlzaF9lbmdpbmUo ZW5naW5lKTsKPiAgCX0KPiAgCj4gIAl3YWtlX3VwX2FsbCgmaTkxNS0+Z3B1X2Vycm9yLnJlc2V0 X3F1ZXVlKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDE0Mjg4NzQzOTA5Zi4u YzFhMzYzNmU5NGZjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtNjg3LDYg KzY4Nyw4IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19jYW5jZWxfcmVxdWVzdHMoc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJc3RydWN0IHJiX25vZGUgKnJiOwo+ICAJdW5zaWdu ZWQgbG9uZyBmbGFnczsKPiAgCj4gKwlHRU1fVFJBQ0UoIiVzXG4iLCBlbmdpbmUtPm5hbWUpOwo+ ICsKPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrLCBmbGFncyk7 Cj4gIAo+ICAJLyogQ2FuY2VsIHRoZSByZXF1ZXN0cyBvbiB0aGUgSFcgYW5kIGNsZWFyIHRoZSBF TFNQIHRyYWNrZXIuICovCj4gQEAgLTczMyw2ICs3MzUsOSBAQCBzdGF0aWMgdm9pZCBleGVjbGlz dHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCSAq Lwo+ICAJY2xlYXJfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1QsICZlbmdpbmUtPmlycV9wb3N0ZWQp Owo+ICAKPiArCS8qIE1hcmsgYWxsIENTIGludGVycnVwdHMgYXMgY29tcGxldGUgKi8KPiArCWV4 ZWNsaXN0cy0+YWN0aXZlID0gMDsKCldpdGggdGhlIGZvbGxvd3VwIHBhdGNoIHRvIGhhbmRsZSB0 aGUgb3RoZXIgaXJxIHN0YXRlIG1hbmlwdWxhdGlvbiBpbnNpZGUKdGltZWxpbmUgbG9jaywgYWxi ZWl0IGl0IGZlZWxzIGEgbGl0dGxlIGxpa2UgYm9ycm93aW5nIGEgbG9jaywgSSBhbSBjb250ZW50 LgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwu Y29tPgoKPiArCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLT5s b2NrLCBmbGFncyk7Cj4gIH0KPiAgCj4gLS0gCj4gMi4xNi4yCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=